[jira] [Commented] (LUCENE-8723) Bad interaction bewteen WordDelimiterGraphFilter, StopFilter and FlattenGraphFilter

2021-08-31 Thread Geoffrey Lawson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407830#comment-17407830 ] Geoffrey Lawson commented on LUCENE-8723: - I know SynonymGraphFilter still has issues consuming

[GitHub] [lucene] zacharymorn commented on a change in pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

2021-08-31 Thread GitBox
zacharymorn commented on a change in pull request #240: URL: https://github.com/apache/lucene/pull/240#discussion_r699834253 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java ## @@ -209,61 +212,14 @@ public static TopScoreDocCollector

[GitHub] [lucene] zacharymorn commented on a change in pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

2021-08-31 Thread GitBox
zacharymorn commented on a change in pull request #240: URL: https://github.com/apache/lucene/pull/240#discussion_r699834141 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ## @@ -407,97 +410,14 @@ public static TopFieldCollector create(Sort

[GitHub] [lucene] zacharymorn commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index check across segments

2021-08-31 Thread GitBox
zacharymorn commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-909872219 Hi @mikemccand, I've merged this PR and will wait for an update on the [nightly check index time page](https://home.apache.org/~mikemccand/lucenebench/checkIndexTime.html).

[GitHub] [lucene] msokolov commented on a change in pull request #267: LUCENE-10054 Handle hierarchy in graph construction and search

2021-08-31 Thread GitBox
msokolov commented on a change in pull request #267: URL: https://github.com/apache/lucene/pull/267#discussion_r699806490 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -107,32 +113,82 @@ public static NeighborQueue search( Random

[jira] [Commented] (LUCENE-9662) CheckIndex should be concurrent

2021-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407763#comment-17407763 ] ASF subversion and git services commented on LUCENE-9662: - Commit

[GitHub] [lucene] zacharymorn merged pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index check across segments

2021-08-31 Thread GitBox
zacharymorn merged pull request #128: URL: https://github.com/apache/lucene/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] msokolov commented on pull request #273: LUCENE-10063: test fixes relating to SimpleTextKnnVectorsReader

2021-08-31 Thread GitBox
msokolov commented on pull request #273: URL: https://github.com/apache/lucene/pull/273#issuecomment-909813740 I ran all tests with `-Dtests.codec=SimpleText` and I ran `TestSimpleTextKnnVectorsFormat` 100 times -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-31 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r699792786 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,140 @@ public

[jira] [Commented] (LUCENE-10068) Switch to a "double barrel" HPPC cache for the taxonomy LRU cache

2021-08-31 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407758#comment-17407758 ] Gautam Worah commented on LUCENE-10068: --- I was initially trying to benchmark the hit rate of the

[jira] [Comment Edited] (LUCENE-10068) Switch to a "double barrel" HPPC cache for the taxonomy LRU cache

2021-08-31 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407758#comment-17407758 ] Gautam Worah edited comment on LUCENE-10068 at 9/1/21, 2:11 AM: I was

[jira] [Updated] (LUCENE-10068) Switch to a "double barrel" HPPC cache for the taxonomy LRU cache

2021-08-31 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gautam Worah updated LUCENE-10068: -- Attachment: disable_taxo_category_cache_benchmark > Switch to a "double barrel" HPPC cache

[jira] [Commented] (LUCENE-10063) SimpleTextKnnVectorsReader.search needs an implementation

2021-08-31 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407740#comment-17407740 ] Michael Sokolov commented on LUCENE-10063: -- Ooh, thank you for pointing that out. Sorry for

[GitHub] [lucene] jtibshirani commented on a change in pull request #267: LUCENE-10054 Handle hierarchy in graph construction and search

2021-08-31 Thread GitBox
jtibshirani commented on a change in pull request #267: URL: https://github.com/apache/lucene/pull/267#discussion_r699760822 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -154,7 +210,7 @@ public static NeighborQueue search(

[GitHub] [lucene] jimczi opened a new pull request #272: LUCENE-10081: KoreanTokenizer should check the max backtrace gap on whitespaces

2021-08-31 Thread GitBox
jimczi opened a new pull request #272: URL: https://github.com/apache/lucene/pull/272 This change ensures that we don't skip consecutive whitespaces without checking the maximum backtrace gap. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (LUCENE-10063) SimpleTextKnnVectorsReader.search needs an implementation

2021-08-31 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407693#comment-17407693 ] Julie Tibshirani commented on LUCENE-10063: --- I noticed a few test failures pop up. Here are

[jira] [Created] (LUCENE-10081) KoreanTokenizer should check the max backtrace gap on whitespaces

2021-08-31 Thread Jim Ferenczi (Jira)
Jim Ferenczi created LUCENE-10081: - Summary: KoreanTokenizer should check the max backtrace gap on whitespaces Key: LUCENE-10081 URL: https://issues.apache.org/jira/browse/LUCENE-10081 Project:

[jira] [Commented] (LUCENE-10077) Closing the DirTaxonomyReader while another thread access the cache can throw NPE

2021-08-31 Thread Marc D'Mello (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407667#comment-17407667 ] Marc D'Mello commented on LUCENE-10077: --- Hi, I would like to work on this issue. > Closing the

[jira] [Commented] (LUCENE-9460) getPath in DirectoryTaxonomyReader should throw an exception

2021-08-31 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407660#comment-17407660 ] Gautam Worah commented on LUCENE-9460: -- We are addressing this in this LUCENE-9476

[GitHub] [lucene] mikemccand commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-31 Thread GitBox
mikemccand commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r699665391 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,140 @@ public FacetLabel

[GitHub] [lucene-site] msokolov commented on pull request #60: Remove Google Analytics from Lucene site

2021-08-31 Thread GitBox
msokolov commented on pull request #60: URL: https://github.com/apache/lucene-site/pull/60#issuecomment-909479543 Thanks, Jan and Uwe! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (LUCENE-8723) Bad interaction bewteen WordDelimiterGraphFilter, StopFilter and FlattenGraphFilter

2021-08-31 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407572#comment-17407572 ] Michael Sokolov commented on LUCENE-8723: - I wonder if WDGF and SynonymGraphFilter can also be

[jira] [Commented] (LUCENE-10063) SimpleTextKnnVectorsReader.search needs an implementation

2021-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407558#comment-17407558 ] ASF subversion and git services commented on LUCENE-10063: -- Commit

[GitHub] [lucene] msokolov commented on pull request #262: LUCENE-10063: implement SimpleTextKnnvectorsReader.search

2021-08-31 Thread GitBox
msokolov commented on pull request #262: URL: https://github.com/apache/lucene/pull/262#issuecomment-909460252 Thanks for the reminder! I had lost track... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] msokolov merged pull request #262: LUCENE-10063: implement SimpleTextKnnvectorsReader.search

2021-08-31 Thread GitBox
msokolov merged pull request #262: URL: https://github.com/apache/lucene/pull/262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene-solr] HoustonPutman merged pull request #2563: SOLR-15599: Upgrade AWS SDK from v1 to v2

2021-08-31 Thread GitBox
HoustonPutman merged pull request #2563: URL: https://github.com/apache/lucene-solr/pull/2563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene-solr] madrob closed pull request #937: SOLR-13209 fixed by adding a null check that throws a SolrException

2021-08-31 Thread GitBox
madrob closed pull request #937: URL: https://github.com/apache/lucene-solr/pull/937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene-site] janhoy merged pull request #60: Remove Google Analytics from Lucene site

2021-08-31 Thread GitBox
janhoy merged pull request #60: URL: https://github.com/apache/lucene-site/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene-site] janhoy merged pull request #61: Remove GA from Lucene site (prod)

2021-08-31 Thread GitBox
janhoy merged pull request #61: URL: https://github.com/apache/lucene-site/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] jpountz commented on pull request #224: LUCENE-10035: Simple text codec add multi level skip list data

2021-08-31 Thread GitBox
jpountz commented on pull request #224: URL: https://github.com/apache/lucene/pull/224#issuecomment-908326788 > In the meantime that failing test should add an assume that the current codec is not SimpleText. Or let's just merge https://github.com/apache/lucene/pull/262? :) --

[GitHub] [lucene-site] uschindler commented on pull request #60: Remove Google Analytics from Lucene site

2021-08-31 Thread GitBox
uschindler commented on pull request #60: URL: https://github.com/apache/lucene-site/pull/60#issuecomment-909291912 (sorry for late reply) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene] jpountz merged pull request #224: LUCENE-10035: Simple text codec add multi level skip list data

2021-08-31 Thread GitBox
jpountz merged pull request #224: URL: https://github.com/apache/lucene/pull/224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] jpountz commented on pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-08-31 Thread GitBox
jpountz commented on pull request #242: URL: https://github.com/apache/lucene/pull/242#issuecomment-909123525 > Does it make sense to have a count API return -1 as the result if the number of matches are greater than a threshold? > Also, in an unoptimized query with >

[GitHub] [lucene] jpountz commented on a change in pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-08-31 Thread GitBox
jpountz commented on a change in pull request #242: URL: https://github.com/apache/lucene/pull/242#discussion_r699205142 ## File path: lucene/core/src/java/org/apache/lucene/search/FilterWeight.java ## @@ -67,4 +67,9 @@ public Scorer scorer(LeafReaderContext context) throws

[jira] [Commented] (LUCENE-10079) DocValues new iterator API is missing in migration guide

2021-08-31 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407411#comment-17407411 ] Michael McCandless commented on LUCENE-10079: - Hrmph, you are right!  We clearly should

[GitHub] [lucene] wuda0112 commented on pull request #224: LUCENE-10035: Simple text codec add multi level skip list data

2021-08-31 Thread GitBox
wuda0112 commented on pull request #224: URL: https://github.com/apache/lucene/pull/224#issuecomment-908356737 @jpountz Thank you, you helped me a lot, and thanks for your patience to review ! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene] gautamworah96 commented on pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-08-31 Thread GitBox
gautamworah96 commented on pull request #242: URL: https://github.com/apache/lucene/pull/242#issuecomment-908676085 Hmmm. So this is indeed multi-threaded but I am still confused. Does it make sense to have a count API return `-1` as the result if the number of matches are greater than a

[GitHub] [lucene] jpountz commented on pull request #262: LUCENE-10063: implement SimpleTextKnnvectorsReader.search

2021-08-31 Thread GitBox
jpountz commented on pull request #262: URL: https://github.com/apache/lucene/pull/262#issuecomment-908331029 @msokolov Let's merge this PR to stop test failures? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene-site] janhoy commented on pull request #60: Remove Google Analytics from Lucene site

2021-08-31 Thread GitBox
janhoy commented on pull request #60: URL: https://github.com/apache/lucene-site/pull/60#issuecomment-909272342 @msokolov please review if you want Lucene to be GA free :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene-site] uschindler commented on pull request #60: Remove Google Analytics from Lucene site

2021-08-31 Thread GitBox
uschindler commented on pull request #60: URL: https://github.com/apache/lucene-site/pull/60#issuecomment-909291912 (sorry for late reply) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene-site] janhoy commented on pull request #60: Remove Google Analytics from Lucene site

2021-08-31 Thread GitBox
janhoy commented on pull request #60: URL: https://github.com/apache/lucene-site/pull/60#issuecomment-909272342 @msokolov please review if you want Lucene to be GA free :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (LUCENE-9969) DirectoryTaxonomyReader.taxoArray占用内存较大导致系统OOM宕机

2021-08-31 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407363#comment-17407363 ] Michael McCandless commented on LUCENE-9969: Imagine we had a {{NUMERIC}} doc values field,

[jira] [Created] (LUCENE-10080) Use a bit set to count long-tail of singleton FacetLabels?

2021-08-31 Thread Michael McCandless (Jira)
Michael McCandless created LUCENE-10080: --- Summary: Use a bit set to count long-tail of singleton FacetLabels? Key: LUCENE-10080 URL: https://issues.apache.org/jira/browse/LUCENE-10080 Project:

[GitHub] [lucene] jpountz commented on pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-08-31 Thread GitBox
jpountz commented on pull request #242: URL: https://github.com/apache/lucene/pull/242#issuecomment-909123525 > Does it make sense to have a count API return -1 as the result if the number of matches are greater than a threshold? > Also, in an unoptimized query with >

[GitHub] [lucene] jpountz commented on a change in pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-08-31 Thread GitBox
jpountz commented on a change in pull request #242: URL: https://github.com/apache/lucene/pull/242#discussion_r699205142 ## File path: lucene/core/src/java/org/apache/lucene/search/FilterWeight.java ## @@ -67,4 +67,9 @@ public Scorer scorer(LeafReaderContext context) throws

[jira] [Created] (LUCENE-10079) DocValues new iterator API is missing in migration guide

2021-08-31 Thread Bernhard Scholz (Jira)
Bernhard Scholz created LUCENE-10079: Summary: DocValues new iterator API is missing in migration guide Key: LUCENE-10079 URL: https://issues.apache.org/jira/browse/LUCENE-10079 Project: Lucene -