rmuir commented on a change in pull request #286:
URL: https://github.com/apache/lucene/pull/286#discussion_r704816931
##
File path: lucene/core/src/java/org/apache/lucene/search/SortField.java
##
@@ -606,4 +609,26 @@ public IndexSorter getIndexSorter() {
return null;
[
https://issues.apache.org/jira/browse/LUCENE-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412204#comment-17412204
]
Marc D'Mello commented on LUCENE-10080:
---
Here is the pull request link for the ch
mdmarshmallow opened a new pull request #288:
URL: https://github.com/apache/lucene/pull/288
# Description
This change is a possible improvement to how we do facet counting. Today, we
accumulate counts in an HPPC int/int map or an `int[]` array. However, it is
possible m
mikemccand commented on a change in pull request #2567:
URL: https://github.com/apache/lucene-solr/pull/2567#discussion_r704763696
##
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##
@@ -465,9 +493,22 @@ public void setChecksumsOnly(boolean v) {
mikemccand commented on pull request #2567:
URL: https://github.com/apache/lucene-solr/pull/2567#issuecomment-915557112
Did you also include backport for fixing `Usage: ...` output?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
mayya-sharipova commented on a change in pull request #286:
URL: https://github.com/apache/lucene/pull/286#discussion_r704733017
##
File path: lucene/core/src/java/org/apache/lucene/search/SortField.java
##
@@ -606,4 +609,26 @@ public IndexSorter getIndexSorter() {
ret
mayya-sharipova commented on a change in pull request #286:
URL: https://github.com/apache/lucene/pull/286#discussion_r704732855
##
File path: lucene/core/src/java/org/apache/lucene/search/SortField.java
##
@@ -130,6 +130,9 @@
// Used for 'sortMissingFirst/Last'
protected
mayya-sharipova commented on a change in pull request #286:
URL: https://github.com/apache/lucene/pull/286#discussion_r704707532
##
File path: lucene/core/src/java/org/apache/lucene/search/SortField.java
##
@@ -606,4 +609,26 @@ public IndexSorter getIndexSorter() {
ret
[
https://issues.apache.org/jira/browse/LUCENE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless resolved LUCENE-10092.
-
Fix Version/s: main (9.0)
Resolution: Fixed
Thanks [~jpountz].
We will
[
https://issues.apache.org/jira/browse/LUCENE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412117#comment-17412117
]
ASF subversion and git services commented on LUCENE-10092:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412111#comment-17412111
]
Zach Chen commented on LUCENE-10092:
Thanks Michael! I appreciate it!
> TestCheckI
[
https://issues.apache.org/jira/browse/LUCENE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412108#comment-17412108
]
Michael McCandless commented on LUCENE-10092:
-
No worries [~zacharymorn] –
[
https://issues.apache.org/jira/browse/LUCENE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412105#comment-17412105
]
Zach Chen commented on LUCENE-10092:
Sorry for (another) TestCheckIndex failure! Th
mikemccand commented on pull request #2567:
URL: https://github.com/apache/lucene-solr/pull/2567#issuecomment-915401627
Let's remember to also backport [fix for
LUCENE-10092](https://issues.apache.org/jira/browse/LUCENE-10092).
--
This is an automated message from the Apache Git Service.
xiaoshi2013 commented on pull request #173:
URL: https://github.com/apache/lucene/pull/173#issuecomment-915366162
so cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
msokolov commented on pull request #274:
URL: https://github.com/apache/lucene/pull/274#issuecomment-915314874
Yes, looks OK. Note I also did add some overloads to avoid autoboxing, so I
think mostly we didn't add any. May not have been needed.
On Wed, Sep 8, 2021 at 7:59 AM Adrien
[
https://issues.apache.org/jira/browse/LUCENE-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411974#comment-17411974
]
xiaoshi edited comment on LUCENE-10091 at 9/8/21, 2:41 PM:
---
T
[
https://issues.apache.org/jira/browse/LUCENE-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411974#comment-17411974
]
xiaoshi commented on LUCENE-10091:
--
Thanks @mikemccand , request you a review of my pr
xiaoshi2013 removed a comment on pull request #2566:
URL: https://github.com/apache/lucene-solr/pull/2566#issuecomment-915296398
Thanks @mikemccand , request you a review of my pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
xiaoshi2013 commented on pull request #2566:
URL: https://github.com/apache/lucene-solr/pull/2566#issuecomment-915296398
Thanks @mikemccand , request you a review of my pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
rmuir commented on a change in pull request #286:
URL: https://github.com/apache/lucene/pull/286#discussion_r704440549
##
File path: lucene/core/src/java/org/apache/lucene/search/SortField.java
##
@@ -130,6 +130,9 @@
// Used for 'sortMissingFirst/Last'
protected Object mi
[
https://issues.apache.org/jira/browse/LUCENE-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411913#comment-17411913
]
Michael McCandless commented on LUCENE-10088:
-
OK the 8.x failure repros fo
[
https://issues.apache.org/jira/browse/LUCENE-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411911#comment-17411911
]
Michael McCandless commented on LUCENE-10088:
-
Yeah now that we understand
[
https://issues.apache.org/jira/browse/LUCENE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411909#comment-17411909
]
Michael McCandless commented on LUCENE-10092:
-
This seems to work:
{noforma
[
https://issues.apache.org/jira/browse/LUCENE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411908#comment-17411908
]
Michael McCandless commented on LUCENE-10092:
-
I added {{-Dtests.verbose=tr
[
https://issues.apache.org/jira/browse/LUCENE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411907#comment-17411907
]
Michael McCandless commented on LUCENE-10092:
-
Repros for me ... looks like
[
https://issues.apache.org/jira/browse/LUCENE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-10092:
--
Description:
We got the below test failure on Elastic's CI:
{noformat}
10:07:08 org.apache.l
Adrien Grand created LUCENE-10092:
-
Summary: TestCheckIndex failure
Key: LUCENE-10092
URL: https://issues.apache.org/jira/browse/LUCENE-10092
Project: Lucene - Core
Issue Type: Bug
jpountz commented on a change in pull request #286:
URL: https://github.com/apache/lucene/pull/286#discussion_r704360843
##
File path: lucene/CHANGES.txt
##
@@ -141,6 +141,10 @@ API Changes
The Weight#count API represents a cleaner way for Query classes to optimize
their co
mayya-sharipova commented on pull request #286:
URL: https://github.com/apache/lucene/pull/286#issuecomment-915181037
@romseygeek Thanks for the review.
@jpountz I've addressed your comments. Can you please continue the review.
--
This is an automated message from the Apache Git S
mayya-sharipova commented on a change in pull request #286:
URL: https://github.com/apache/lucene/pull/286#discussion_r704358532
##
File path: lucene/core/src/java/org/apache/lucene/search/SortField.java
##
@@ -606,4 +609,20 @@ public IndexSorter getIndexSorter() {
ret
mayya-sharipova commented on a change in pull request #286:
URL: https://github.com/apache/lucene/pull/286#discussion_r704358433
##
File path: lucene/core/src/java/org/apache/lucene/search/SortField.java
##
@@ -606,4 +609,20 @@ public IndexSorter getIndexSorter() {
ret
[
https://issues.apache.org/jira/browse/LUCENE-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411887#comment-17411887
]
Adrien Grand commented on LUCENE-10088:
---
[~simonw] I'd be interested in your take
jpountz commented on pull request #274:
URL: https://github.com/apache/lucene/pull/274#issuecomment-915171475
Indexing rate and GC/JIT times look stable. :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
[
https://issues.apache.org/jira/browse/LUCENE-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411882#comment-17411882
]
Michael McCandless commented on LUCENE-10010:
-
Thanks for the update [~zhai
[
https://issues.apache.org/jira/browse/LUCENE-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411881#comment-17411881
]
Michael McCandless commented on LUCENE-10091:
-
Thanks [~xiaoshi_2021]! You
[
https://issues.apache.org/jira/browse/LUCENE-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411880#comment-17411880
]
Michael McCandless commented on LUCENE-9662:
{quote}it seems like it's ok fo
jpountz commented on a change in pull request #286:
URL: https://github.com/apache/lucene/pull/286#discussion_r704166498
##
File path: lucene/core/src/java/org/apache/lucene/search/SortField.java
##
@@ -606,4 +609,20 @@ public IndexSorter getIndexSorter() {
return null
38 matches
Mail list logo
