[GitHub] [lucene] gsmiller commented on a change in pull request #420: [DRAFT] LUCENE-10122 Explore using NumericDocValue to store taxonomy parent array

2021-11-02 Thread GitBox
gsmiller commented on a change in pull request #420: URL: https://github.com/apache/lucene/pull/420#discussion_r741472877 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java ## @@ -129,39 +124,19 @@ private void initParents(I

[GitHub] [lucene] jtibshirani commented on a change in pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-11-02 Thread GitBox
jtibshirani commented on a change in pull request #416: URL: https://github.com/apache/lucene/pull/416#discussion_r740706179 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -99,32 +121,72 @@ public static NeighborQueue search( Bits acc

[GitHub] [lucene] jtibshirani commented on pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-11-02 Thread GitBox
jtibshirani commented on pull request #416: URL: https://github.com/apache/lucene/pull/416#issuecomment-957098407 Got it, it sounds like you already adjusted my set-up to include warm-ups. Overall it looks like a positive performance improvement. I'm in favor of merging this even though th

[GitHub] [lucene] gsmiller commented on pull request #422: LUCENE-10120: Lazy initialize FixedBitSet in LRUQueryCache

2021-11-02 Thread GitBox
gsmiller commented on pull request #422: URL: https://github.com/apache/lucene/pull/422#issuecomment-957946153 I really like that you're experimenting with this idea! I commented over on the associated Jira issue in more detail, but just for completeness, I'll add a brief note here as well

[GitHub] [lucene] jprinet commented on a change in pull request #421: LUCENE-10195: Add gradle cache option and make some tasks cacheable

2021-11-02 Thread GitBox
jprinet commented on a change in pull request #421: URL: https://github.com/apache/lucene/pull/421#discussion_r740939233 ## File path: gradle/documentation/render-javadoc.gradle ## @@ -284,8 +300,14 @@ class RenderJavadocTask extends DefaultTask { @Input boolean relativeP

[GitHub] [lucene] dweiss merged pull request #421: LUCENE-10195: Add gradle cache option and make some tasks cacheable

2021-11-02 Thread GitBox
dweiss merged pull request #421: URL: https://github.com/apache/lucene/pull/421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [lucene] uschindler commented on pull request #421: LUCENE-10195: Add gradle cache option and make some tasks cacheable

2021-11-02 Thread GitBox
uschindler commented on pull request #421: URL: https://github.com/apache/lucene/pull/421#issuecomment-956588955 Wasn't the idea to make the cache optional? Looks like it is enabled by default. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene] uschindler removed a comment on pull request #421: LUCENE-10195: Add gradle cache option and make some tasks cacheable

2021-11-02 Thread GitBox
uschindler removed a comment on pull request #421: URL: https://github.com/apache/lucene/pull/421#issuecomment-956588955 Wasn't the idea to make the cache optional? Looks like it is enabled by default. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [lucene-solr] thelabdude merged pull request #2595: LUCENE-10141: Add the next minor version on Lucene's main branch in the split repo so the backcompat_master task works

2021-11-02 Thread GitBox
thelabdude merged pull request #2595: URL: https://github.com/apache/lucene-solr/pull/2595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene-solr] thelabdude merged pull request #2598: SOLR-12666: Add authn & authz plugins that supports multiple authentication schemes, such as Bearer and Basic

2021-11-02 Thread GitBox
thelabdude merged pull request #2598: URL: https://github.com/apache/lucene-solr/pull/2598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene] uschindler commented on pull request #421: LUCENE-10195: Add gradle cache option and make some tasks cacheable

2021-11-02 Thread GitBox
uschindler commented on pull request #421: URL: https://github.com/apache/lucene/pull/421#issuecomment-956588955 Wasn't the idea to make the cache optional? Looks like it is enabled by default. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene] jtibshirani commented on a change in pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-11-02 Thread GitBox
jtibshirani commented on a change in pull request #416: URL: https://github.com/apache/lucene/pull/416#discussion_r740706179 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -99,32 +121,72 @@ public static NeighborQueue search( Bits acc

[GitHub] [lucene] jtibshirani commented on pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-11-02 Thread GitBox
jtibshirani commented on pull request #416: URL: https://github.com/apache/lucene/pull/416#issuecomment-957098407 Got it, it sounds like you already adjusted my set-up to include warm-ups. Overall it looks like a positive performance improvement. I'm in favor of merging this even though th

[GitHub] [lucene-solr] thelabdude merged pull request #2598: SOLR-12666: Add authn & authz plugins that supports multiple authentication schemes, such as Bearer and Basic

2021-11-02 Thread GitBox
thelabdude merged pull request #2598: URL: https://github.com/apache/lucene-solr/pull/2598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene] gsmiller commented on pull request #422: LUCENE-10120: Lazy initialize FixedBitSet in LRUQueryCache

2021-11-02 Thread GitBox
gsmiller commented on pull request #422: URL: https://github.com/apache/lucene/pull/422#issuecomment-957946153 I really like that you're experimenting with this idea! I commented over on the associated Jira issue in more detail, but just for completeness, I'll add a brief note here as well

[GitHub] [lucene] uschindler removed a comment on pull request #421: LUCENE-10195: Add gradle cache option and make some tasks cacheable

2021-11-02 Thread GitBox
uschindler removed a comment on pull request #421: URL: https://github.com/apache/lucene/pull/421#issuecomment-956588955 Wasn't the idea to make the cache optional? Looks like it is enabled by default. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [lucene] bruno-roustant closed pull request #404: LUCENE-10196: Improve IntroSorter with 3-ways partitioning.

2021-11-02 Thread GitBox
bruno-roustant closed pull request #404: URL: https://github.com/apache/lucene/pull/404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[GitHub] [lucene] jprinet commented on a change in pull request #421: LUCENE-10195: Add gradle cache option and make some tasks cacheable

2021-11-02 Thread GitBox
jprinet commented on a change in pull request #421: URL: https://github.com/apache/lucene/pull/421#discussion_r740939233 ## File path: gradle/documentation/render-javadoc.gradle ## @@ -284,8 +300,14 @@ class RenderJavadocTask extends DefaultTask { @Input boolean relativeP

[GitHub] [lucene] dweiss merged pull request #421: LUCENE-10195: Add gradle cache option and make some tasks cacheable

2021-11-02 Thread GitBox
dweiss merged pull request #421: URL: https://github.com/apache/lucene/pull/421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [lucene-solr] thelabdude merged pull request #2595: LUCENE-10141: Add the next minor version on Lucene's main branch in the split repo so the backcompat_master task works

2021-11-02 Thread GitBox
thelabdude merged pull request #2595: URL: https://github.com/apache/lucene-solr/pull/2595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene] gsmiller commented on pull request #422: LUCENE-10120: Lazy initialize FixedBitSet in LRUQueryCache

2021-11-02 Thread GitBox
gsmiller commented on pull request #422: URL: https://github.com/apache/lucene/pull/422#issuecomment-957946153 I really like that you're experimenting with this idea! I commented over on the associated Jira issue in more detail, but just for completeness, I'll add a brief note here as well

[jira] [Commented] (LUCENE-10120) Lazy initialize FixedBitSet in LRUQueryCache

2021-11-02 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437368#comment-17437368 ] Greg Miller commented on LUCENE-10120: -- Ah [~ChrisLu] I just saw you posted a PR.

[jira] [Updated] (LUCENE-10120) Lazy initialize FixedBitSet in LRUQueryCache

2021-11-02 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller updated LUCENE-10120: - Attachment: LUCENE-10120.patch > Lazy initialize FixedBitSet in LRUQueryCache > ---

[jira] [Commented] (LUCENE-10120) Lazy initialize FixedBitSet in LRUQueryCache

2021-11-02 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437365#comment-17437365 ] Greg Miller commented on LUCENE-10120: -- So I don't think there's any need to "crea

[jira] [Updated] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

2021-11-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-10126: -- Fix Version/s: (was: 9.10) > CompetitiveIterator of NumericComparator can wrongly skip do

[jira] [Commented] (LUCENE-10120) Lazy initialize FixedBitSet in LRUQueryCache

2021-11-02 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437319#comment-17437319 ] Lu Xugang commented on LUCENE-10120: Hi [~jpountz] {quote}So trying to optimize fo

[jira] [Commented] (LUCENE-10195) Add gradle cache option and make some tasks cacheable

2021-11-02 Thread Jerome Prinet (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437310#comment-17437310 ] Jerome Prinet commented on LUCENE-10195: Thanks to you [~dweiss]! > Add gradle

[jira] [Resolved] (LUCENE-10195) Add gradle cache option and make some tasks cacheable

2021-11-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10195. -- Fix Version/s: main (9.0) Resolution: Fixed > Add gradle cache option and make some ta

[jira] [Commented] (LUCENE-10195) Add gradle cache option and make some tasks cacheable

2021-11-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437302#comment-17437302 ] ASF subversion and git services commented on LUCENE-10195: -- Co

[jira] [Assigned] (LUCENE-10195) Add gradle cache option and make some tasks cacheable

2021-11-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned LUCENE-10195: Assignee: Dawid Weiss > Add gradle cache option and make some tasks cacheable >

[jira] [Commented] (LUCENE-10195) Add gradle cache option and make some tasks cacheable

2021-11-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437303#comment-17437303 ] ASF subversion and git services commented on LUCENE-10195: -- Co

[GitHub] [lucene] dweiss merged pull request #421: LUCENE-10195: Add gradle cache option and make some tasks cacheable

2021-11-02 Thread GitBox
dweiss merged pull request #421: URL: https://github.com/apache/lucene/pull/421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (LUCENE-10195) Add gradle cache option and make some tasks cacheable

2021-11-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437299#comment-17437299 ] Dawid Weiss commented on LUCENE-10195: -- Thanks [~JeromeP]! > Add gradle cache opt

[GitHub] [lucene] LuXugang opened a new pull request #422: LUCENE-10120: Lazy initialize FixedBitSet in LRUQueryCache

2021-11-02 Thread GitBox
LuXugang opened a new pull request #422: URL: https://github.com/apache/lucene/pull/422 Detailed discussion see: https://issues.apache.org/jira/browse/LUCENE-10120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Comment Edited] (LUCENE-10120) Lazy initialize FixedBitSet in LRUQueryCache

2021-11-02 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437291#comment-17437291 ] Lu Xugang edited comment on LUCENE-10120 at 11/2/21, 11:06 AM: --

[jira] [Commented] (LUCENE-10120) Lazy initialize FixedBitSet in LRUQueryCache

2021-11-02 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437291#comment-17437291 ] Lu Xugang commented on LUCENE-10120: {quote}it sounds like your proposal here is to

[jira] [Commented] (LUCENE-10120) Lazy initialize FixedBitSet in LRUQueryCache

2021-11-02 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437288#comment-17437288 ] Lu Xugang commented on LUCENE-10120: {quote}Or is the idea that we create a FixedBi

[jira] [Comment Edited] (LUCENE-10195) Add gradle cache option and make some tasks cacheable

2021-11-02 Thread Jerome Prinet (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437286#comment-17437286 ] Jerome Prinet edited comment on LUCENE-10195 at 11/2/21, 10:56 AM: --

[jira] [Commented] (LUCENE-10195) Add gradle cache option and make some tasks cacheable

2021-11-02 Thread Jerome Prinet (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437286#comment-17437286 ] Jerome Prinet commented on LUCENE-10195: Just reviewed and approved the second

[GitHub] [lucene] jprinet commented on a change in pull request #421: LUCENE-10195: Add gradle cache option and make some tasks cacheable

2021-11-02 Thread GitBox
jprinet commented on a change in pull request #421: URL: https://github.com/apache/lucene/pull/421#discussion_r740939233 ## File path: gradle/documentation/render-javadoc.gradle ## @@ -284,8 +300,14 @@ class RenderJavadocTask extends DefaultTask { @Input boolean relativeP

[jira] [Commented] (LUCENE-10216) Add concurrency to addIndexes(CodecReader…) API

2021-11-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437255#comment-17437255 ] Adrien Grand commented on LUCENE-10216: --- One bit from this proposal I'm not fully

[jira] [Commented] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-11-02 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437247#comment-17437247 ] Bruno Roustant commented on LUCENE-10196: - Oh! Thank you [~jpountz]! I was wron

[jira] [Commented] (LUCENE-10103) QueryCache not estimating query size properly

2021-11-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437228#comment-17437228 ] ASF subversion and git services commented on LUCENE-10103: -- Co

[jira] [Commented] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-11-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437225#comment-17437225 ] ASF subversion and git services commented on LUCENE-10196: -- Co

[jira] [Commented] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-11-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437227#comment-17437227 ] Adrien Grand commented on LUCENE-10196: --- [~broustant] FYI I was reviewing change

[jira] [Comment Edited] (LUCENE-9714) 8.7 document link is broken

2021-11-02 Thread spike liu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437177#comment-17437177 ] spike liu edited comment on LUCENE-9714 at 11/2/21, 7:52 AM: -

[jira] [Commented] (LUCENE-9714) 8.7 document link is broken

2021-11-02 Thread spike liu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437177#comment-17437177 ] spike liu commented on LUCENE-9714: --- [~xiaohuiliu] could you provide the broken link?

[jira] [Commented] (LUCENE-10120) Lazy initialize FixedBitSet in LRUQueryCache

2021-11-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437174#comment-17437174 ] Adrien Grand commented on LUCENE-10120: --- Ah, thanks for the clarifications, I had

[jira] [Commented] (LUCENE-10120) Lazy initialize FixedBitSet in LRUQueryCache

2021-11-02 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437163#comment-17437163 ] Vigya Sharma commented on LUCENE-10120: --- {quote}it sounds like your proposal here