pquentin commented on a change in pull request #445:
URL: https://github.com/apache/lucene/pull/445#discussion_r750955229
##
File path:
lucene/core/src/java/org/apache/lucene/search/DocValuesFieldExistsQuery.java
##
@@ -74,6 +74,16 @@ public Scorer scorer(LeafReaderContext
pquentin commented on a change in pull request #445:
URL: https://github.com/apache/lucene/pull/445#discussion_r750954007
##
File path:
lucene/core/src/java/org/apache/lucene/search/DocValuesFieldExistsQuery.java
##
@@ -74,6 +74,16 @@ public Scorer scorer(LeafReaderContext
pquentin commented on a change in pull request #445:
URL: https://github.com/apache/lucene/pull/445#discussion_r750953697
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestDocValuesFieldExistsQuery.java
##
@@ -17,17 +17,17 @@
package org.apache.lucene.search;
zacharymorn commented on pull request #444:
URL: https://github.com/apache/lucene/pull/444#issuecomment-971181479
Thanks @jimczi @jtibshirani for the review and feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
zacharymorn commented on a change in pull request #444:
URL: https://github.com/apache/lucene/pull/444#discussion_r750881073
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiNormsLeafSimScorer.java
##
@@ -61,7 +63,14 @@
if (needsScores) {
zacharymorn commented on a change in pull request #444:
URL: https://github.com/apache/lucene/pull/444#discussion_r750880606
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestCombinedFieldQuery.java
##
@@ -165,6 +169,117 @@ public void testSameScore()
gsmiller commented on pull request #443:
URL: https://github.com/apache/lucene/pull/443#issuecomment-971118953
OK should be ready for another look now. Thanks for the feedback everyone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
zhaih commented on a change in pull request #442:
URL: https://github.com/apache/lucene/pull/442#discussion_r750831307
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java
##
@@ -130,15 +125,49 @@ private void
[
https://issues.apache.org/jira/browse/LUCENE-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-10232:
-
Description:
When {{MultiRangeQuery}} iterates the multiple dimensions to see if any of them
[
https://issues.apache.org/jira/browse/LUCENE-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444883#comment-17444883
]
Greg Miller edited comment on LUCENE-10232 at 11/17/21, 12:26 AM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444883#comment-17444883
]
Greg Miller commented on LUCENE-10232:
--
[~mikemccand] not sure who uses it. There are no direct
zhaih commented on a change in pull request #442:
URL: https://github.com/apache/lucene/pull/442#discussion_r750735847
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java
##
@@ -161,12 +165,14 @@ public
zhaih commented on a change in pull request #442:
URL: https://github.com/apache/lucene/pull/442#discussion_r750735067
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java
##
@@ -130,15 +125,49 @@ private void
zhaih commented on a change in pull request #442:
URL: https://github.com/apache/lucene/pull/442#discussion_r750733549
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java
##
@@ -130,15 +125,49 @@ private void
zhaih commented on a change in pull request #442:
URL: https://github.com/apache/lucene/pull/442#discussion_r750733364
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java
##
@@ -130,15 +125,49 @@ private void
zhaih commented on a change in pull request #442:
URL: https://github.com/apache/lucene/pull/442#discussion_r750733313
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java
##
@@ -130,15 +125,49 @@ private void
[
https://issues.apache.org/jira/browse/LUCENE-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444845#comment-17444845
]
Michael McCandless commented on LUCENE-10232:
-
Egads, this is awful. Who/what uses
gsmiller commented on pull request #443:
URL: https://github.com/apache/lucene/pull/443#issuecomment-970739154
> I wonder if we could make the bw compat logic simpler by creating a
SortedNumericDocValues instance that is backed by BinaryDocValues for 8.x
indices?
I like this idea.
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r750715374
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java
##
@@ -81,4 +84,18 @@ public long cost() {
}
};
}
+
+ /**
+ *
mikemccand commented on a change in pull request #442:
URL: https://github.com/apache/lucene/pull/442#discussion_r750653939
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java
##
@@ -130,15 +125,49 @@ private void
[
https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444838#comment-17444838
]
Robert Muir commented on LUCENE-10238:
--
all done, everything seems happy. {{hacks -= 2}}
> Update
[
https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444831#comment-17444831
]
Robert Muir commented on LUCENE-10238:
--
I'm fixing the input file for the impacted characters.
HoustonPutman commented on pull request #2607:
URL: https://github.com/apache/lucene-solr/pull/2607#issuecomment-970699660
It's in the 8.11.1 Changelog, so it should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444824#comment-17444824
]
Robert Muir commented on LUCENE-10238:
--
i'll check out your branch. i don't think this is a bug
[
https://issues.apache.org/jira/browse/LUCENE-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9921.
-
Resolution: Invalid
> Can ICU regeneration tasks treat icu version as input?
>
[
https://issues.apache.org/jira/browse/LUCENE-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444818#comment-17444818
]
Dawid Weiss commented on LUCENE-9921:
-
Thanks Robert. I'll close this issue and maybe straighten
[
https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444817#comment-17444817
]
Dawid Weiss commented on LUCENE-10238:
--
Incomplete PR at
[
https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444815#comment-17444815
]
Dawid Weiss commented on LUCENE-10238:
--
I have some errors trying to regenerate resources.
{code}
mikemccand commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r750659421
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -409,9 +410,26 @@ private void processFacetFields(
[
https://issues.apache.org/jira/browse/LUCENE-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444811#comment-17444811
]
Robert Muir commented on LUCENE-9921:
-
[~dweiss] the older icu is only used for regeneration of
[
https://issues.apache.org/jira/browse/LUCENE-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444809#comment-17444809
]
Dawid Weiss commented on LUCENE-9921:
-
Also, think this task is actually obsolete - I see this
jpountz commented on a change in pull request #445:
URL: https://github.com/apache/lucene/pull/445#discussion_r750644758
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestDocValuesFieldExistsQuery.java
##
@@ -17,17 +17,17 @@
package org.apache.lucene.search;
mkhludnev merged pull request #2611:
URL: https://github.com/apache/lucene-solr/pull/2611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Dawid Weiss created LUCENE-10238:
Summary: Update icu4j to 70.1
Key: LUCENE-10238
URL: https://issues.apache.org/jira/browse/LUCENE-10238
Project: Lucene - Core
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/LUCENE-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444792#comment-17444792
]
Dawid Weiss commented on LUCENE-9921:
-
[~rmuir] do you remember why there are two different versions
[
https://issues.apache.org/jira/browse/LUCENE-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444789#comment-17444789
]
Dawid Weiss commented on LUCENE-9921:
-
> I even fixated it in my build.gradle at 62.2 to prevent
gsmiller commented on pull request #264:
URL: https://github.com/apache/lucene/pull/264#issuecomment-970619510
Please note I've opened a separate PR (#443) to add this change to 9.0.
After iterating on that PR and merging to 9.0/9.x, I'll come back to this PR
and remove the back-compat
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r750605208
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java
##
@@ -81,4 +84,18 @@ public long cost() {
}
};
}
+
+ /**
+ *
magibney commented on pull request #380:
URL: https://github.com/apache/lucene/pull/380#issuecomment-970573111
I'm definitely not the ideal reviewer for this either, but fwiw: the only
potential issue I can see here is the sharing of this component (and ultimately
the underlying opennlp
jtibshirani commented on a change in pull request #444:
URL: https://github.com/apache/lucene/pull/444#discussion_r750528027
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestCombinedFieldQuery.java
##
@@ -165,6 +169,117 @@ public void testSameScore()
magibney commented on a change in pull request #380:
URL: https://github.com/apache/lucene/pull/380#discussion_r750515187
##
File path:
lucene/analysis/opennlp/src/java/org/apache/lucene/analysis/opennlp/tools/OpenNLPOpsFactory.java
##
@@ -169,11 +169,14 @@ public static
rmuir commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r750426411
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java
##
@@ -81,4 +84,18 @@ public long cost() {
}
};
}
+
+ /**
+ *
jpountz commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r750386018
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java
##
@@ -81,4 +84,18 @@ public long cost() {
}
};
}
+
+ /**
+ *
jpountz commented on a change in pull request #445:
URL: https://github.com/apache/lucene/pull/445#discussion_r750295570
##
File path:
lucene/core/src/java/org/apache/lucene/search/DocValuesFieldExistsQuery.java
##
@@ -74,6 +74,16 @@ public Scorer scorer(LeafReaderContext
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444540#comment-17444540
]
Adrien Grand commented on LUCENE-10233:
---
I like how it makes contracts simpler, but I now worry
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444527#comment-17444527
]
Feng Guo edited comment on LUCENE-10233 at 11/16/21, 1:40 PM:
--
[~jpountz]
jpountz commented on a change in pull request #430:
URL: https://github.com/apache/lucene/pull/430#discussion_r750279415
##
File path: lucene/core/src/java/org/apache/lucene/util/MathUtil.java
##
@@ -24,13 +24,36 @@
// No instance:
private MathUtil() {}
+ /**
+ *
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444527#comment-17444527
]
Feng Guo commented on LUCENE-10233:
---
Sadly, I found that the implementation of {{SparseFixedBitSet}}
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444527#comment-17444527
]
Feng Guo edited comment on LUCENE-10233 at 11/16/21, 1:18 PM:
--
[~jpountz]
codaitya opened a new pull request #446:
URL: https://github.com/apache/lucene/pull/446
# Description
Add MergeOnCommitTieredMergePolicy to sandbox
# Solution
Add MergeOnCommitTieredMergePolicy and tests to sandbox module
# Tests
Added tests
bruno-roustant commented on pull request #430:
URL: https://github.com/apache/lucene/pull/430#issuecomment-970150412
I tried different variations (e.g. median of min/max instead of min/max of
medians) but without more gain.
I finally tried to fully remove the top-k shortcut, and it
Anand Kotriwal created LUCENE-10237:
---
Summary: Add merge on commit merge policy to Lucene Sandbox
Key: LUCENE-10237
URL: https://issues.apache.org/jira/browse/LUCENE-10237
Project: Lucene - Core
pquentin opened a new pull request #445:
URL: https://github.com/apache/lucene/pull/445
# Description
Now that we require all documents to use the same features (LUCENE-9334),
implement `Weight#count()` to return `docCount` if either terms or points are
indexed.
# Solution
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444362#comment-17444362
]
Feng Guo commented on LUCENE-10233:
---
Thanks! I'll try SparseFixedBitSet :)
> Store docIds as bitset
jpountz commented on a change in pull request #418:
URL: https://github.com/apache/lucene/pull/418#discussion_r750020101
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java
##
@@ -441,6 +491,273 @@ public boolean
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444346#comment-17444346
]
Adrien Grand commented on LUCENE-10233:
---
Indeed, I was thinking of implementing
56 matches
Mail list logo
