mocobeta edited a comment on pull request #481:
URL: https://github.com/apache/lucene/pull/481#issuecomment-980814245
Ok I found the datasets download tasks.
`gradlew tasks` now shows:
```
Utility launchers tasks
---
run - Run a perf test
mocobeta commented on pull request #481:
URL: https://github.com/apache/lucene/pull/481#issuecomment-980814245
Ok I found the datasets download tasks.
`gradlew tasks` now shows:
```
Utility launchers tasks
---
run - Run a perf test (optional:
mocobeta commented on pull request #481:
URL: https://github.com/apache/lucene/pull/481#issuecomment-980810486
It's not related to the task group definition though,
```
./gradlew -p lucene/benchmark/ run
```
seems to fail without proper data preparation. Before the very
mocobeta commented on a change in pull request #482:
URL: https://github.com/apache/lucene/pull/482#discussion_r757823244
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -154,7 +158,12 @@ public Analyzer
mocobeta commented on pull request #482:
URL: https://github.com/apache/lucene/pull/482#issuecomment-980806417
I replaced the default to `StandardAnalyzer`.
> I did some quick tests. I was expecting to see the standard analyzer
defaults already predefined in the UI.
> As this is
uschindler commented on pull request #482:
URL: https://github.com/apache/lucene/pull/482#issuecomment-980783528
Hi,
I did some quick tests. I was expecting to see the standard analyzer
defaults already predefined in the UI.
As this is not the case, I would stay with `new
uschindler commented on a change in pull request #482:
URL: https://github.com/apache/lucene/pull/482#discussion_r757797871
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -154,7 +158,12 @@ public Analyzer
uschindler commented on a change in pull request #482:
URL: https://github.com/apache/lucene/pull/482#discussion_r757797473
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -154,7 +158,12 @@ public Analyzer
dweiss commented on pull request #481:
URL: https://github.com/apache/lucene/pull/481#issuecomment-980646469
I think the context here can be provided via gradle's built-in mechanisms.
This (gradlew :lucene:luke:run) is clearer to me than having differently named
tasks for each type of
mocobeta commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757786046
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -152,6 +152,14 @@ public Analyzer
mocobeta opened a new pull request #482:
URL: https://github.com/apache/lucene/pull/482
This mimics the StandardAnalyzer.
https://github.com/apache/lucene/pull/480#pullrequestreview-817120063
--
This is an automated message from the Apache Git Service.
To respond to the
mocobeta commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757784309
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -152,6 +152,14 @@ public Analyzer
uschindler commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757783926
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -152,6 +152,14 @@ public Analyzer
[
https://issues.apache.org/jira/browse/LUCENE-10265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449841#comment-17449841
]
Michael McCandless commented on LUCENE-10265:
-
{quote}it should't beyond the
[
https://issues.apache.org/jira/browse/LUCENE-10266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449838#comment-17449838
]
Michael McCandless commented on LUCENE-10266:
-
+1
> Move nearest-neighbor search on points
mocobeta commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757781501
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -152,6 +152,14 @@ public Analyzer
mocobeta commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757781501
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -152,6 +152,14 @@ public Analyzer
mocobeta commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757781501
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -152,6 +152,14 @@ public Analyzer
mocobeta commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757781017
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -152,6 +152,14 @@ public Analyzer
uschindler commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757779571
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -152,6 +152,14 @@ public Analyzer
mocobeta commented on pull request #481:
URL: https://github.com/apache/lucene/pull/481#issuecomment-980585757
I understand sharing the same name between multiple tasks is perfectly fine;
meanwhile, my feeling is it could also be a good convention to have
well-distinguished names for
mocobeta commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757776870
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -152,6 +152,14 @@ public Analyzer
mocobeta commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757776560
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -152,6 +152,14 @@ public Analyzer
mocobeta commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757776079
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -152,6 +152,14 @@ public Analyzer
uschindler commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757773515
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -152,6 +152,14 @@ public Analyzer
uschindler commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757773262
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -152,6 +152,14 @@ public Analyzer
mocobeta commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757763988
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -152,6 +152,14 @@ public Analyzer
mocobeta opened a new pull request #481:
URL: https://github.com/apache/lucene/pull/481
A spin-off from #479.
```
./gradlew tasks
Utility launchers tasks
---
run - Run a perf test (optional: -PtaskAlg=conf/your-algorithm-file
-PmaxHeapSize=1G)
uschindler commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757762651
##
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##
@@ -152,6 +152,14 @@ public Analyzer
mocobeta closed pull request #479:
URL: https://github.com/apache/lucene/pull/479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mocobeta commented on pull request #479:
URL: https://github.com/apache/lucene/pull/479#issuecomment-980525416
Yes, I've always run `gradlew -p lucene/luke run`.
(While it isn't a bug, it could be a bit puzzling since there is no mention
about "run" task for "benchmark" project, also
31 matches
Mail list logo
