[jira] [Commented] (LUCENE-10327) gradle emits an empty sourcepath for forked javac and breaks compilation

2021-12-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462096#comment-17462096 ] ASF subversion and git services commented on LUCENE-10327: -- Commit

[jira] [Resolved] (LUCENE-10327) gradle emits an empty sourcepath for forked javac and breaks compilation

2021-12-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10327. -- Resolution: Staged The workaround on jms2 seems to work. > gradle emits an empty sourcepath

[GitHub] [lucene] dsmiley commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-18 Thread GitBox
dsmiley commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r771899727 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -383,6 +564,15 @@ public

[jira] [Commented] (LUCENE-10327) gradle emits an empty sourcepath for forked javac and breaks compilation

2021-12-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462025#comment-17462025 ] Dawid Weiss commented on LUCENE-10327: -- It's this thing:

[jira] [Updated] (LUCENE-10327) gradle emits an empty sourcepath for forked javac and breaks compilation

2021-12-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10327: - Description: {code} gradlew -p lucene/core compileJava -Pruntime.java.home=... cat

[jira] [Updated] (LUCENE-10327) gradle emits an empty sourcepath for forked javac and breaks compilation

2021-12-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10327: - Description: {code} gradlew -p lucene/core compileJava -Pruntime.java.home=... {code} >

[jira] [Updated] (LUCENE-10327) gradle emits an empty sourcepath for forked javac and breaks compilation

2021-12-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10327: - Priority: Blocker (was: Major) > gradle emits an empty sourcepath for forked javac and breaks

[jira] [Created] (LUCENE-10327) gradle emits an empty sourcepath for forked javac and breaks compilation

2021-12-18 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10327: Summary: gradle emits an empty sourcepath for forked javac and breaks compilation Key: LUCENE-10327 URL: https://issues.apache.org/jira/browse/LUCENE-10327 Project:

[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)

2021-12-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461997#comment-17461997 ] Dawid Weiss commented on LUCENE-8930: - I added a rough sketch of a more realistic test for

[GitHub] [lucene] apanimesh061 commented on pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-18 Thread GitBox
apanimesh061 commented on pull request #412: URL: https://github.com/apache/lucene/pull/412#issuecomment-997280739 @dsmiley I've made an attempt at making this back-portable as suggested. - `@Deprecated` the setters and constructor - Have not added any tests for the non-builder

[jira] [Commented] (LUCENE-10308) Make ecj and javadoc run with modular paths

2021-12-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461975#comment-17461975 ] ASF subversion and git services commented on LUCENE-10308: -- Commit

[jira] [Commented] (LUCENE-10308) Make ecj and javadoc run with modular paths

2021-12-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461976#comment-17461976 ] ASF subversion and git services commented on LUCENE-10308: -- Commit

[jira] [Resolved] (LUCENE-10308) Make ecj and javadoc run with modular paths

2021-12-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10308. -- Resolution: Fixed I sorted all source files for ecj so that their order is predictable and a

[jira] [Reopened] (LUCENE-10308) Make ecj and javadoc run with modular paths

2021-12-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reopened LUCENE-10308: -- We're hitting this one on jenkins: https://bugs.eclipse.org/bugs/show_bug.cgi?id=569833 > Make

[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)

2021-12-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461973#comment-17461973 ] Dawid Weiss commented on LUCENE-8930: - Hi Tomoko. Let me add a scaffolding for such a test I already

[jira] [Commented] (LUCENE-10255) Fully embrace the java module system

2021-12-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461972#comment-17461972 ] ASF subversion and git services commented on LUCENE-10255: -- Commit

[jira] [Commented] (LUCENE-10255) Fully embrace the java module system

2021-12-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461970#comment-17461970 ] ASF subversion and git services commented on LUCENE-10255: -- Commit

[jira] [Commented] (LUCENE-10255) Fully embrace the java module system

2021-12-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461967#comment-17461967 ] ASF subversion and git services commented on LUCENE-10255: -- Commit

[jira] [Commented] (LUCENE-10255) Fully embrace the java module system

2021-12-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461966#comment-17461966 ] ASF subversion and git services commented on LUCENE-10255: -- Commit

[jira] [Commented] (LUCENE-10308) Make ecj and javadoc run with modular paths

2021-12-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461965#comment-17461965 ] ASF subversion and git services commented on LUCENE-10308: -- Commit

[GitHub] [lucene] dweiss merged pull request #533: LUCENE-10255: cleaned up module system support and other sub-issues

2021-12-18 Thread GitBox
dweiss merged pull request #533: URL: https://github.com/apache/lucene/pull/533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (LUCENE-9360) might be NEEDED. ToParentDocValues uses advanceExact() of underneath DocValues

2021-12-18 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev closed LUCENE-9360. > might be NEEDED. ToParentDocValues uses advanceExact() of underneath DocValues >

[jira] [Resolved] (LUCENE-9360) might be NEEDED. ToParentDocValues uses advanceExact() of underneath DocValues

2021-12-18 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev resolved LUCENE-9360. -- Resolution: Won't Fix will be addressed under enclosing issue > might be NEEDED.

[jira] [Closed] (LUCENE-9357) AssertingSorted(Set|Numeric)DocValues should be unwrappable

2021-12-18 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev closed LUCENE-9357. > AssertingSorted(Set|Numeric)DocValues should be unwrappable >

[jira] [Resolved] (LUCENE-9357) AssertingSorted(Set|Numeric)DocValues should be unwrappable

2021-12-18 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev resolved LUCENE-9357. -- Resolution: Won't Fix will be addressed in enclosing issue >

[GitHub] [lucene] msokolov commented on pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-12-18 Thread GitBox
msokolov commented on pull request #416: URL: https://github.com/apache/lucene/pull/416#issuecomment-997209709 @mayya-sharipova I don't have strong feelings about the file structure; either way seems OK to me. I guess if pressed I would probably choose to keep a smaller number of files

[GitHub] [lucene-solr] uschindler commented on pull request #2631: SOLR-15843 Upgrade log4j from 2.15 to 2.16

2021-12-18 Thread GitBox
uschindler commented on pull request #2631: URL: https://github.com/apache/lucene-solr/pull/2631#issuecomment-997208157 > Thank you for the fix. We need now a fix for 2.17.0 https://search.maven.org/search?q=g:org.apache.logging.log4j%20AND%20a:log4j-core Also, please a new

[GitHub] [lucene-solr] mkurde edited a comment on pull request #2631: SOLR-15843 Upgrade log4j from 2.15 to 2.16

2021-12-18 Thread GitBox
mkurde edited a comment on pull request #2631: URL: https://github.com/apache/lucene-solr/pull/2631#issuecomment-997206959 Thank you for the fix. We need now a fix for 2.17.0 https://search.maven.org/search?q=g:org.apache.logging.log4j%20AND%20a:log4j-core Also, please a new

[GitHub] [lucene-solr] mkurde edited a comment on pull request #2631: SOLR-15843 Upgrade log4j from 2.15 to 2.16

2021-12-18 Thread GitBox
mkurde edited a comment on pull request #2631: URL: https://github.com/apache/lucene-solr/pull/2631#issuecomment-997206959 We need now a fix for 2.17.0 https://search.maven.org/search?q=g:org.apache.logging.log4j%20AND%20a:log4j-core Also, please a new solr-core@8.11.2

[GitHub] [lucene-solr] mkurde commented on pull request #2631: SOLR-15843 Upgrade log4j from 2.15 to 2.16

2021-12-18 Thread GitBox
mkurde commented on pull request #2631: URL: https://github.com/apache/lucene-solr/pull/2631#issuecomment-997206959 We need now a fix for 2.17.0 https://search.maven.org/search?q=g:org.apache.logging.log4j%20AND%20a:log4j-core Also, please a new solr-core@8.11.2 -- This is an

[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)

2021-12-18 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461878#comment-17461878 ] Tomoko Uchida commented on LUCENE-8930: --- I think I can start this once

[jira] [Updated] (LUCENE-10319) Make ForUtil#BLOCK_SIZE changeable

2021-12-18 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Guo updated LUCENE-10319: -- Description: In LUCENE-10315, I tried to generate a {{ForUtil}} whose {{{}BLOCK_SIZE=512{}}}, I

[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)

2021-12-18 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461875#comment-17461875 ] Tomoko Uchida commented on LUCENE-8930: --- The launch script for Windows uses "javaw" to spawn the

[jira] [Updated] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)

2021-12-18 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-8930: -- Summary: Integrate Luke app health check to nightly tests (CI) (was: Add smoke tests for

[jira] [Reopened] (LUCENE-8930) Add smoke tests for Luke

2021-12-18 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida reopened LUCENE-8930: --- I'd reopen this to allow to make sure that Luke app and its launch scripts are not broken by

[GitHub] [lucene] mocobeta edited a comment on pull request #533: LUCENE-10255: cleaned up module system support and other sub-issues

2021-12-18 Thread GitBox
mocobeta edited a comment on pull request #533: URL: https://github.com/apache/lucene/pull/533#issuecomment-997141676 I did some sanity checks on this branch. Looks everything is fine. https://gist.github.com/mocobeta/387585d846714aab86205ab92bc0beba I'm on IntelliJ IDEA -