[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)

2021-12-19 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462434#comment-17462434 ] Tomoko Uchida commented on LUCENE-8930: --- I will try to take a look this week. I mi

[GitHub] [lucene] zacharymorn commented on pull request #444: LUCENE-10236: Updated field-weight used in CombinedFieldQuery scoring calculation, and added a test

2021-12-19 Thread GitBox
zacharymorn commented on pull request #444: URL: https://github.com/apache/lucene/pull/444#issuecomment-997621234 > Will backport this to 8.11 and 8x. Hi @jimczi @jtibshirani @mikemccand, just to confirm as I saw there was a thread on the proper handling of `branch_8x`, this change s

[jira] [Commented] (LUCENE-10236) CombinedFieldsQuery to use fieldAndWeights.values() when constructing MultiNormsLeafSimScorer for scoring

2021-12-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462398#comment-17462398 ] ASF subversion and git services commented on LUCENE-10236: -- Co

[GitHub] [lucene] zacharymorn merged pull request #456: LUCENE-10236: Add change entry

2021-12-19 Thread GitBox
zacharymorn merged pull request #456: URL: https://github.com/apache/lucene/pull/456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [lucene] zacharymorn commented on pull request #456: LUCENE-10236: Add change entry

2021-12-19 Thread GitBox
zacharymorn commented on pull request #456: URL: https://github.com/apache/lucene/pull/456#issuecomment-997616583 > Aha, perfect, looks great! +1 to push. Sorry for the delay @zacharymorn. No problem! Thanks for the review and approval! -- This is an automated message from the Apac

[GitHub] [lucene] mikemccand commented on pull request #518: Initial rewrite of MMapDirectory for JDK-18 preview (incubating) Panama APIs (>= JDK-18-ea-b26)

2021-12-19 Thread GitBox
mikemccand commented on pull request #518: URL: https://github.com/apache/lucene/pull/518#issuecomment-997480562 > Take your time and enjoy the complexity of setting this up! ;-) LOL! OK I will try to test this @uschindler :) -- This is an automated message from the Apache Git Ser

[GitHub] [lucene] mikemccand commented on pull request #456: LUCENE-10236: Add change entry

2021-12-19 Thread GitBox
mikemccand commented on pull request #456: URL: https://github.com/apache/lucene/pull/456#issuecomment-997473896 Aha, perfect, looks great! +1 to push. Sorry for the delay @zacharymorn. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462301#comment-17462301 ] Dawid Weiss commented on LUCENE-10301: -- [https://github.com/apache/lucene/pull/551

[GitHub] [lucene] zacharymorn commented on pull request #418: LUCENE-10061: Implements dynamic pruning support for CombinedFieldsQuery

2021-12-19 Thread GitBox
zacharymorn commented on pull request #418: URL: https://github.com/apache/lucene/pull/418#issuecomment-997460370 > > These numbers are super interesting. Let's go with the approach of you baseline for now since it performs better, sorry for putting you on a track that performs worse. :)

[GitHub] [lucene] zacharymorn commented on pull request #456: LUCENE-10236: Add change entry

2021-12-19 Thread GitBox
zacharymorn commented on pull request #456: URL: https://github.com/apache/lucene/pull/456#issuecomment-997458592 > > Hmm actually this issue was fixed in 9.0.0, I think? > > This change entry is for [07ee3ba#diff-27a1984493254d0af3e9c50caee47443abbbdc79a87b4c348300bcb317a0a5b2](http

[GitHub] [lucene] zacharymorn commented on pull request #534: LUCENE-10183: KnnVectorsWriter#writeField to take KnnVectorsReader instead of VectorValues

2021-12-19 Thread GitBox
zacharymorn commented on pull request #534: URL: https://github.com/apache/lucene/pull/534#issuecomment-997458442 Hi @jpountz @msokolov @jtibshirani , just want to check back on this and see if the changes look good? -- This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (LUCENE-10197) UnifiedHighlighter should use builders for thread-safety

2021-12-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462295#comment-17462295 ] David Smiley commented on LUCENE-10197: --- Both paths are viable (do now or do late

[jira] [Comment Edited] (LUCENE-10197) UnifiedHighlighter should use builders for thread-safety

2021-12-19 Thread Animesh Pandey (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462291#comment-17462291 ] Animesh Pandey edited comment on LUCENE-10197 at 12/19/21, 8:22 PM: -

[jira] [Commented] (LUCENE-10197) UnifiedHighlighter should use builders for thread-safety

2021-12-19 Thread Animesh Pandey (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462291#comment-17462291 ] Animesh Pandey commented on LUCENE-10197: - Thanks a lot David for helping me ou

[jira] [Resolved] (LUCENE-10197) UnifiedHighlighter should use builders for thread-safety

2021-12-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved LUCENE-10197. --- Fix Version/s: 9.1 Resolution: Fixed Woohoo; thanks Animesh! > UnifiedHighlighter s

[jira] [Commented] (LUCENE-10197) UnifiedHighlighter should use builders for thread-safety

2021-12-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462243#comment-17462243 ] ASF subversion and git services commented on LUCENE-10197: -- Co

[jira] [Commented] (LUCENE-10197) UnifiedHighlighter should use builders for thread-safety

2021-12-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462242#comment-17462242 ] ASF subversion and git services commented on LUCENE-10197: -- Co

[GitHub] [lucene] dsmiley merged pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-19 Thread GitBox
dsmiley merged pull request #412: URL: https://github.com/apache/lucene/pull/412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene] apanimesh061 commented on pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-19 Thread GitBox
apanimesh061 commented on pull request #412: URL: https://github.com/apache/lucene/pull/412#issuecomment-997424641 @dsmiley I've made the suggested modifications. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [lucene] apanimesh061 commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-19 Thread GitBox
apanimesh061 commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r771974831 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -97,6 +97,23 @@ public static final in

[GitHub] [lucene] apanimesh061 commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-19 Thread GitBox
apanimesh061 commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r771974822 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -383,6 +564,15 @@ public UnifiedHighlighter

[GitHub] [lucene] apanimesh061 commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-19 Thread GitBox
apanimesh061 commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r771973219 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -360,14 +451,104 @@ public UnifiedHighlight

[jira] [Commented] (LUCENE-10328) Module path for compiling and running tests is empty

2021-12-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462223#comment-17462223 ] Dawid Weiss commented on LUCENE-10328: -- Sure. I find this sequence quite reasonabl

[jira] [Comment Edited] (LUCENE-10328) Module path for compiling and running tests is empty

2021-12-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462220#comment-17462220 ] Uwe Schindler edited comment on LUCENE-10328 at 12/19/21, 3:48 PM: --

[jira] [Comment Edited] (LUCENE-10328) Module path for compiling and running tests is empty

2021-12-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462220#comment-17462220 ] Uwe Schindler edited comment on LUCENE-10328 at 12/19/21, 3:48 PM: --

[jira] [Comment Edited] (LUCENE-10328) Module path for compiling and running tests is empty

2021-12-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462220#comment-17462220 ] Uwe Schindler edited comment on LUCENE-10328 at 12/19/21, 3:48 PM: --

[jira] [Commented] (LUCENE-10328) Module path for compiling and running tests is empty

2021-12-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462220#comment-17462220 ] Uwe Schindler commented on LUCENE-10328: bq. True. You can work around this by

[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)

2021-12-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462170#comment-17462170 ] Dawid Weiss commented on LUCENE-8930: - Please do continue, Tomoko. I don't think it'

[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)

2021-12-19 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462168#comment-17462168 ] Tomoko Uchida commented on LUCENE-8930: --- Thank you - the work seems almost complet

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462167#comment-17462167 ] Dawid Weiss commented on LUCENE-10301: -- I started playing by just moving stuff. St

[jira] [Assigned] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)

2021-12-19 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida reassigned LUCENE-8930: - Assignee: (was: Tomoko Uchida) > Integrate Luke app health check to nightly tests (

[jira] [Commented] (LUCENE-10328) Module path for compiling and running tests is empty

2021-12-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462166#comment-17462166 ] Dawid Weiss commented on LUCENE-10328: -- True. You can work around this by placing

[jira] [Commented] (LUCENE-10328) Module path for compiling and running tests is empty

2021-12-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462160#comment-17462160 ] Uwe Schindler commented on LUCENE-10328: Still test tests of a module itself ne

[jira] [Commented] (LUCENE-10328) Module path for compiling and running tests is empty

2021-12-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462159#comment-17462159 ] Dawid Weiss commented on LUCENE-10328: -- I would rather fix the test framework to b

[jira] [Commented] (LUCENE-10328) Module path for compiling and running tests is empty

2021-12-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462158#comment-17462158 ] Uwe Schindler commented on LUCENE-10328: bq. Maven does it, I was part of the m

[jira] [Comment Edited] (LUCENE-10328) Module path for compiling and running tests is empty

2021-12-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462157#comment-17462157 ] Uwe Schindler edited comment on LUCENE-10328 at 12/19/21, 11:51 AM: -

[jira] [Commented] (LUCENE-10328) Module path for compiling and running tests is empty

2021-12-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462157#comment-17462157 ] Uwe Schindler commented on LUCENE-10328: To make this work we must use Patch-Mo

[jira] [Commented] (LUCENE-10328) Module path for compiling and running tests is empty

2021-12-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462153#comment-17462153 ] Dawid Weiss commented on LUCENE-10328: -- Exactly. {code:java} > Task :lucene:codecs

[jira] [Commented] (LUCENE-10328) Module path for compiling and running tests is empty

2021-12-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462152#comment-17462152 ] Dawid Weiss commented on LUCENE-10328: -- I'm not so sure it'll be possible to place

[jira] [Created] (LUCENE-10328) Module path for compiling and running tests is empty

2021-12-19 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10328: Summary: Module path for compiling and running tests is empty Key: LUCENE-10328 URL: https://issues.apache.org/jira/browse/LUCENE-10328 Project: Lucene - Core

[jira] [Commented] (LUCENE-10327) gradle emits an empty sourcepath for forked javac and breaks compilation

2021-12-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462148#comment-17462148 ] ASF subversion and git services commented on LUCENE-10327: -- Co

[jira] [Comment Edited] (LUCENE-10319) Make ForUtil#BLOCK_SIZE changeable

2021-12-19 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461367#comment-17461367 ] Feng Guo edited comment on LUCENE-10319 at 12/19/21, 9:25 AM: ---