[jira] [Commented] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-26 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465310#comment-17465310 ] Feng Guo commented on LUCENE-10334: --- Thanks [~rcmuir] for suggestion! I tried some op

[jira] [Comment Edited] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-26 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465310#comment-17465310 ] Feng Guo edited comment on LUCENE-10334 at 12/26/21, 8:52 AM: ---

[jira] [Created] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Tomoko Uchida (Jira)
Tomoko Uchida created LUCENE-10341: -- Summary: AttributeFactory.DefaultAttributeFactory does not work on module mode Key: LUCENE-10341 URL: https://issues.apache.org/jira/browse/LUCENE-10341 Project:

[jira] [Resolved] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-10341. Resolution: Invalid Sorry, I mistook the problem - there is a different issue. I will loo

[jira] [Commented] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465343#comment-17465343 ] Tomoko Uchida commented on LUCENE-10341: The example was bad - JapaneseAnalyzer

[jira] [Commented] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465346#comment-17465346 ] Tomoko Uchida commented on LUCENE-10341: As for DefaultAttributeFactory, it wor

[GitHub] [lucene] mocobeta edited a comment on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

2021-12-26 Thread GitBox
mocobeta edited a comment on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1001112886 Browsing through this issue, I am wondering if it'd be helpful that we have an entry to forbid ~Class#getClassLoader()~ ClassLoadr#getResourceAsStream() (and so on) by def

[GitHub] [lucene] mocobeta edited a comment on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

2021-12-26 Thread GitBox
mocobeta edited a comment on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1001112886 Browsing through this issue, I am wondering if it'd be helpful that we have an entry to forbid ~Class#getClassLoader()~ ClassLoadr#getResourceAsStream() (and so on) by def

[jira] [Commented] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465350#comment-17465350 ] Uwe Schindler commented on LUCENE-10341: Hi, I was hoping this would not happe

[jira] [Assigned] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reassigned LUCENE-10341: -- Assignee: Uwe Schindler > AttributeFactory.DefaultAttributeFactory does not work on

[jira] [Reopened] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reopened LUCENE-10341: Why did you close it? Custom interfaces won't work. > AttributeFactory.DefaultAttributeFact

[jira] [Commented] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465353#comment-17465353 ] Uwe Schindler commented on LUCENE-10341: So does it work or not? Your posts her

[jira] [Commented] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465354#comment-17465354 ] Uwe Schindler commented on LUCENE-10341: Class#forName says: "Note that this me

[jira] [Commented] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465356#comment-17465356 ] Tomoko Uchida commented on LUCENE-10341: I'm sorry, the original test code was

[jira] [Commented] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465358#comment-17465358 ] Uwe Schindler commented on LUCENE-10341: And the constructor should be allowed

[jira] [Resolved] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-10341. Resolution: Not A Problem > AttributeFactory.DefaultAttributeFactory does not work on mod

[jira] [Comment Edited] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465361#comment-17465361 ] Uwe Schindler edited comment on LUCENE-10341 at 12/26/21, 12:33 PM: -

[jira] [Commented] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465361#comment-17465361 ] Uwe Schindler commented on LUCENE-10341: OK, I verified everything: - Class#for

[jira] [Comment Edited] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465361#comment-17465361 ] Uwe Schindler edited comment on LUCENE-10341 at 12/26/21, 12:34 PM: -

[jira] [Comment Edited] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465361#comment-17465361 ] Uwe Schindler edited comment on LUCENE-10341 at 12/26/21, 12:34 PM: -

[jira] [Commented] (LUCENE-10341) AttributeFactory.DefaultAttributeFactory does not work on module mode

2021-12-26 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465367#comment-17465367 ] Tomoko Uchida commented on LUCENE-10341: Thank you for the clarification. Pleas

[GitHub] [lucene] mocobeta edited a comment on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

2021-12-26 Thread GitBox
mocobeta edited a comment on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1001112886 Browsing through this issue, I am wondering if it'd be helpful that we have entries to forbid ~Class#getClassLoader()~ ClassLoadr#getResourceAsStream() (and so on) by defa

[GitHub] [lucene] dweiss merged pull request #565: LUCENE-10338: Scan for tests only by convention file name pattern

2021-12-26 Thread GitBox
dweiss merged pull request #565: URL: https://github.com/apache/lucene/pull/565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Resolved] (LUCENE-10338) Scan for tests only by convention file name pattern (Test*)

2021-12-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10338. -- Fix Version/s: 9.1 Resolution: Fixed > Scan for tests only by convention file name pat

[jira] [Commented] (LUCENE-10338) Scan for tests only by convention file name pattern (Test*)

2021-12-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465408#comment-17465408 ] ASF subversion and git services commented on LUCENE-10338: -- Co

[jira] [Commented] (LUCENE-10338) Scan for tests only by convention file name pattern (Test*)

2021-12-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465407#comment-17465407 ] ASF subversion and git services commented on LUCENE-10338: -- Co

[GitHub] [lucene] gf2121 opened a new pull request #570: Lucene-10334: Detected warm up of directreader

2021-12-26 Thread GitBox
gf2121 opened a new pull request #570: URL: https://github.com/apache/lucene/pull/570 see: https://issues.apache.org/jira/browse/LUCENE-10334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-26 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465416#comment-17465416 ] Feng Guo commented on LUCENE-10334: --- Another idea coming to my mind to solve the regr

[jira] [Comment Edited] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-26 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465416#comment-17465416 ] Feng Guo edited comment on LUCENE-10334 at 12/26/21, 6:09 PM: ---