[jira] [Comment Edited] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-29 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17466709#comment-17466709 ] Feng Guo edited comment on LUCENE-10334 at 12/30/21, 7:53 AM: ---

[GitHub] [lucene] dweiss commented on a change in pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2021-12-29 Thread GitBox
dweiss commented on a change in pull request #571: URL: https://github.com/apache/lucene/pull/571#discussion_r776605201 ## File path: gradle/java/modules.gradle ## @@ -237,24 +185,282 @@ allprojects { } +// +// For a source set, create explicit configurations for declaring

[jira] [Comment Edited] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-29 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17466709#comment-17466709 ] Feng Guo edited comment on LUCENE-10334 at 12/30/21, 7:39 AM: ---

[jira] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-29 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334 ] Feng Guo deleted comment on LUCENE-10334: --- was (Author: gf2121): Thanks [~rcmuir] for suggestion! I tried some optimizations on this patch: 1. I replaced {{DirectWriter#unsignedBitsRequired}}

[jira] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-29 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334 ] Feng Guo deleted comment on LUCENE-10334: --- was (Author: gf2121): In the 'detect warm up' approach, I unrolled the block decode codes, speed it up a bit: {code:java}

[jira] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-29 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334 ] Feng Guo deleted comment on LUCENE-10334: --- was (Author: gf2121): If we can not tolerate the regression, another idea coming to my mind to solve the regression is introducing a 'detect warm up

[jira] [Commented] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-29 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17466709#comment-17466709 ] Feng Guo commented on LUCENE-10334: --- In order to save reading time, I deleted some pr

[GitHub] [lucene] mocobeta commented on a change in pull request #571: LUCENE-10328: Module path for compiling and running tests is wrong

2021-12-29 Thread GitBox
mocobeta commented on a change in pull request #571: URL: https://github.com/apache/lucene/pull/571#discussion_r776573308 ## File path: gradle/java/modules.gradle ## @@ -237,24 +185,282 @@ allprojects { } +// +// For a source set, create explicit configurations for declari

[jira] [Commented] (LUCENE-10344) ECJ batch compiler does not support --patch-module at all

2021-12-29 Thread Jennifer gray (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17466602#comment-17466602 ] Jennifer gray commented on LUCENE-10344: My account is hacked. I'm not sure wha

[jira] [Commented] (LUCENE-10344) ECJ batch compiler does not support --patch-module at all

2021-12-29 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17466601#comment-17466601 ] Uwe Schindler commented on LUCENE-10344: Do we really need that just for checki

[jira] [Created] (LUCENE-10344) ECJ batch compiler does not support --patch-module at all

2021-12-29 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10344: Summary: ECJ batch compiler does not support --patch-module at all Key: LUCENE-10344 URL: https://issues.apache.org/jira/browse/LUCENE-10344 Project: Lucene - Core

[jira] [Resolved] (LUCENE-10342) Add (very limited) java.util.logging to Lucene Core

2021-12-29 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-10342. Fix Version/s: 9.1 10.0 (main) Resolution: Fixed > Add (very li

[jira] [Commented] (LUCENE-10342) Add (very limited) java.util.logging to Lucene Core

2021-12-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17466539#comment-17466539 ] ASF subversion and git services commented on LUCENE-10342: -- Co

[jira] [Commented] (LUCENE-10342) Add (very limited) java.util.logging to Lucene Core

2021-12-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17466537#comment-17466537 ] ASF subversion and git services commented on LUCENE-10342: -- Co

[GitHub] [lucene] uschindler merged pull request #572: LUCENE-10342: Add some logging to static initializers to warn users if unmapping or object size calculation does not work

2021-12-29 Thread GitBox
uschindler merged pull request #572: URL: https://github.com/apache/lucene/pull/572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [lucene] uschindler commented on a change in pull request #572: LUCENE-10342: Add some logging to static initializers to warn users if unmapping or object size calculation does not work

2021-12-29 Thread GitBox
uschindler commented on a change in pull request #572: URL: https://github.com/apache/lucene/pull/572#discussion_r776345222 ## File path: lucene/core/src/java/org/apache/lucene/util/RamUsageEstimator.java ## @@ -153,6 +154,19 @@ private RamUsageEstimator() {} }

[GitHub] [lucene] uschindler commented on a change in pull request #572: LUCENE-10342: Add some logging to static initializers to warn users if unmapping or object size calculation does not work

2021-12-29 Thread GitBox
uschindler commented on a change in pull request #572: URL: https://github.com/apache/lucene/pull/572#discussion_r776344665 ## File path: lucene/core/src/java/org/apache/lucene/util/RamUsageEstimator.java ## @@ -153,6 +154,19 @@ private RamUsageEstimator() {} }

[GitHub] [lucene] uschindler commented on a change in pull request #572: LUCENE-10342: Add some logging to static initializers to warn users if unmapping or object size calculation does not work

2021-12-29 Thread GitBox
uschindler commented on a change in pull request #572: URL: https://github.com/apache/lucene/pull/572#discussion_r776343439 ## File path: lucene/core/src/java/org/apache/lucene/util/RamUsageEstimator.java ## @@ -153,6 +154,19 @@ private RamUsageEstimator() {} }

[GitHub] [lucene] sonatype-lift[bot] commented on a change in pull request #570: Lucene-10334: Detected warm up of directreader

2021-12-29 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #570: URL: https://github.com/apache/lucene/pull/570#discussion_r776300137 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectForwardReader.java ## @@ -0,0 +1,461 @@ +/* + * Licensed to the Apache Sof

[GitHub] [lucene] uschindler commented on a change in pull request #572: LUCENE-10342: Add some logging to static initializers to warn users if unmapping or object size calculation does not work

2021-12-29 Thread GitBox
uschindler commented on a change in pull request #572: URL: https://github.com/apache/lucene/pull/572#discussion_r776289498 ## File path: lucene/core/src/java/org/apache/lucene/util/JavaLoggingInfoStream.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [lucene] uschindler commented on pull request #572: LUCENE-10342: Add some logging to static initializers to warn users if unmapping or object size calculation does not work

2021-12-29 Thread GitBox
uschindler commented on pull request #572: URL: https://github.com/apache/lucene/pull/572#issuecomment-1002557840 > I confirmed this log via luke running on OpenJ9 11. > > ``` > 17:32:51 [WARNING] org.apache.lucene.store.MMapDirectory: Unmapping is not supported, because Lucene ca

[jira] [Resolved] (LUCENE-10340) Fix image file location (resource path) in luke module

2021-12-29 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-10340. Resolution: Fixed > Fix image file location (resource path) in luke module >

[GitHub] [lucene] mocobeta edited a comment on pull request #572: LUCENE-10342: Add some logging to static initializers to warn users if unmapping or object size calculation does not work

2021-12-29 Thread GitBox
mocobeta edited a comment on pull request #572: URL: https://github.com/apache/lucene/pull/572#issuecomment-1002460832 I confirmed this log via luke running on OpenJ9 11. ``` 17:32:51 [WARNING] org.apache.lucene.store.MMapDirectory: Unmapping is not supported, because Lucene canno

[GitHub] [lucene] mocobeta edited a comment on pull request #572: LUCENE-10342: Add some logging to static initializers to warn users if unmapping or object size calculation does not work

2021-12-29 Thread GitBox
mocobeta edited a comment on pull request #572: URL: https://github.com/apache/lucene/pull/572#issuecomment-1002460832 I confirmed this log via luke running on OpenJ9 11. ``` 17:32:51 [WARNING] org.apache.lucene.store.MMapDirectory: Unmapping is not supported, because Lucene canno

[GitHub] [lucene] mocobeta edited a comment on pull request #572: LUCENE-10342: Add some logging to static initializers to warn users if unmapping or object size calculation does not work

2021-12-29 Thread GitBox
mocobeta edited a comment on pull request #572: URL: https://github.com/apache/lucene/pull/572#issuecomment-1002460832 I confirmed this log via luke running on OpenJ9 11. ``` 17:32:51 [WARNING] org.apache.lucene.store.MMapDirectory: Unmapping is not supported, because Lucene canno

[GitHub] [lucene] mocobeta commented on pull request #572: LUCENE-10342: Add some logging to static initializers to warn users if unmapping or object size calculation does not work

2021-12-29 Thread GitBox
mocobeta commented on pull request #572: URL: https://github.com/apache/lucene/pull/572#issuecomment-1002460832 I confirmed this log via luke running on OpenJ9 11. ``` 17:32:51 [WARNING] org.apache.lucene.store.MMapDirectory: Unmapping is not supported, because Lucene cannot read

[jira] [Commented] (LUCENE-10304) Make sure IDEs are usable after modules are introduced

2021-12-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17466348#comment-17466348 ] Dawid Weiss commented on LUCENE-10304: -- Uwe noticed that Eclipse has a problem wit

[jira] [Comment Edited] (LUCENE-10304) Make sure IDEs are usable after modules are introduced

2021-12-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17466348#comment-17466348 ] Dawid Weiss edited comment on LUCENE-10304 at 12/29/21, 8:29 AM:

[jira] [Updated] (LUCENE-10304) Make sure IDEs are usable after modules are introduced

2021-12-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10304: - Attachment: screenshot-1.png > Make sure IDEs are usable after modules are introduced > ---