gsmiller opened a new pull request #611:
URL: https://github.com/apache/lucene/pull/611
# Description
Dimension-level counts in SSDV faceting can be inaccurate when docs contain
multiple values under the same dim (the doc will be counted multiple times
towards the dim). This fixes t
[
https://issues.apache.org/jira/browse/LUCENE-10368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477509#comment-17477509
]
Greg Miller commented on LUCENE-10368:
--
Moved both of these PRs out of draft mode
[
https://issues.apache.org/jira/browse/LUCENE-10374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-10374:
-
Priority: Minor (was: Major)
> Track down the "browse" taxonomy faceting qps regression
>
[
https://issues.apache.org/jira/browse/LUCENE-10374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-10374:
-
Issue Type: Task (was: Improvement)
> Track down the "browse" taxonomy faceting qps regression
[
https://issues.apache.org/jira/browse/LUCENE-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477507#comment-17477507
]
Greg Miller commented on LUCENE-10379:
--
This has now been backported to 9.x. Resol
[
https://issues.apache.org/jira/browse/LUCENE-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-10379:
-
Fix Version/s: 9.1
10.0 (main)
> Count directly into the values array in Fas
[
https://issues.apache.org/jira/browse/LUCENE-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller resolved LUCENE-10379.
--
Resolution: Fixed
> Count directly into the values array in FastTaxonomyFacetCounts#countAl
>
gsmiller merged pull request #610:
URL: https://github.com/apache/lucene/pull/610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
[
https://issues.apache.org/jira/browse/LUCENE-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477506#comment-17477506
]
ASF subversion and git services commented on LUCENE-10379:
--
Co
gsmiller opened a new pull request #610:
URL: https://github.com/apache/lucene/pull/610
Backport recent optimizations onto 9.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
[
https://issues.apache.org/jira/browse/LUCENE-10350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477502#comment-17477502
]
ASF subversion and git services commented on LUCENE-10350:
--
Co
gsmiller merged pull request #609:
URL: https://github.com/apache/lucene/pull/609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
[
https://issues.apache.org/jira/browse/LUCENE-10374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477489#comment-17477489
]
Greg Miller commented on LUCENE-10374:
--
As an update here, merging just part of th
gsmiller commented on a change in pull request #606:
URL: https://github.com/apache/lucene/pull/606#discussion_r786337979
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##
@@ -126,23 +126,39 @@ private void countAll(IndexReade
gsmiller commented on a change in pull request #606:
URL: https://github.com/apache/lucene/pull/606#discussion_r786337739
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##
@@ -126,23 +126,39 @@ private void countAll(IndexReade
gsmiller commented on a change in pull request #606:
URL: https://github.com/apache/lucene/pull/606#discussion_r786337003
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##
@@ -126,23 +126,39 @@ private void countAll(IndexReade
mayya-sharipova commented on pull request #416:
URL: https://github.com/apache/lucene/pull/416#issuecomment-1014658302
Thanks everyone for the review. I am closing this PR in favour of
https://github.com/apache/lucene/pull/608 that copies these changes into a new
Lucene91Codec and Lucene91
mayya-sharipova closed pull request #416:
URL: https://github.com/apache/lucene/pull/416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-un
mayya-sharipova opened a new pull request #608:
URL: https://github.com/apache/lucene/pull/608
Currently HNSW has only a single layer.
This patch makes HNSW graph multi-layered.
This PR is based on the following PRs:
#250, #267, #287, #315, #536, #416
Main changes:
-
[
https://issues.apache.org/jira/browse/LUCENE-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477256#comment-17477256
]
Uwe Schindler commented on LUCENE-10366:
This seems to make Hotspot inline the
[
https://issues.apache.org/jira/browse/LUCENE-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477250#comment-17477250
]
Uwe Schindler commented on LUCENE-10376:
I will merge and backport the PR durin
[
https://issues.apache.org/jira/browse/LUCENE-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477249#comment-17477249
]
Uwe Schindler commented on LUCENE-10376:
+1
> Roll up the loop in vint/vlong i
[
https://issues.apache.org/jira/browse/LUCENE-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reassigned LUCENE-10376:
--
Assignee: Uwe Schindler
> Roll up the loop in vint/vlong in DataInput
>
[
https://issues.apache.org/jira/browse/LUCENE-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477248#comment-17477248
]
Uwe Schindler commented on LUCENE-10366:
In PR https://github.com/apache/lucene
[
https://issues.apache.org/jira/browse/LUCENE-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reassigned LUCENE-10366:
--
Assignee: Uwe Schindler
> Reduce the number of valid checks for ByteBufferIndexInput
uschindler commented on pull request #602:
URL: https://github.com/apache/lucene/pull/602#issuecomment-1014573645
I would also take this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
uschindler commented on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1014572990
Hi @jpountz,
if you agree I'd merge this in and backport!
Uwe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
gf2121 commented on a change in pull request #592:
URL: https://github.com/apache/lucene/pull/592#discussion_r786025580
##
File path: lucene/CHANGES.txt
##
@@ -126,6 +126,9 @@ Improvements
Optimizations
-
+* LUCENE-10366: Override #readVInt and #readVLon
uschindler commented on a change in pull request #592:
URL: https://github.com/apache/lucene/pull/592#discussion_r786023119
##
File path: lucene/CHANGES.txt
##
@@ -126,6 +126,9 @@ Improvements
Optimizations
-
+* LUCENE-10366: Override #readVInt and #read
uschindler commented on a change in pull request #592:
URL: https://github.com/apache/lucene/pull/592#discussion_r786023119
##
File path: lucene/CHANGES.txt
##
@@ -126,6 +126,9 @@ Improvements
Optimizations
-
+* LUCENE-10366: Override #readVInt and #read
uschindler commented on a change in pull request #592:
URL: https://github.com/apache/lucene/pull/592#discussion_r786004689
##
File path: lucene/CHANGES.txt
##
@@ -126,6 +126,9 @@ Improvements
Optimizations
-
+* LUCENE-10366: Override #readVInt and #read
uschindler commented on a change in pull request #592:
URL: https://github.com/apache/lucene/pull/592#discussion_r786003953
##
File path: lucene/CHANGES.txt
##
@@ -126,6 +126,9 @@ Improvements
Optimizations
-
+* LUCENE-10366: Override #readVInt and #read
uschindler commented on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1014534594
OK, thanks, so let's keep the hack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gf2121 commented on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1014529950
Here is the report of [making vint
final](https://github.com/apache/lucene/compare/main...gf2121:make_vint_final?expand=1)
(50 repeat * 20 JVM):
```
[
https://issues.apache.org/jira/browse/LUCENE-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-10377.
Fix Version/s: 9.1
10.0 (main)
Resolution: Fixed
> Replace 'sor
[
https://issues.apache.org/jira/browse/LUCENE-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477142#comment-17477142
]
ASF subversion and git services commented on LUCENE-10377:
--
Co
uschindler commented on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1014394276
Although it is unrelated, but could you make that one final for consistency?
https://github.com/apache/lucene/blob/97d669bcdb5e302a4fd79c648d5f621d90a9ac3b/lucene/core/src/java/
gf2121 commented on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1014390791
Thanks @uschindler !
> I was also thinking about the following: Why not make readVInt/readVLong
final in the DataInput class? This should be possible after the refactoring in
[
https://issues.apache.org/jira/browse/LUCENE-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477117#comment-17477117
]
ASF subversion and git services commented on LUCENE-10377:
--
Co
romseygeek merged pull request #603:
URL: https://github.com/apache/lucene/pull/603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
uschindler commented on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1014376367
I was also thinking about the following: Why not make readVInt/readVLong
final in the DataInput class? This should be possible after the refactoring in
#602 !
We should
uschindler commented on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1014373226
I will try out the same on `MemorySegmentIndexInput` (#518).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
iverase opened a new pull request #607:
URL: https://github.com/apache/lucene/pull/607
In LUCENE-9820 we changed the API for PointValues to expose methods to
navigate the BKD tree. One important change is the ability to compute the
number of points below any node of the tree. In order to c
iverase commented on pull request #541:
URL: https://github.com/apache/lucene/pull/541#issuecomment-1014284136
This is looking much better. I tried some of my benchmarks and for points it
looks like:
```
|Approach||Index time (sec)||Force merge time (sec)||Index size (GB)||Reader
[
https://issues.apache.org/jira/browse/LUCENE-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477036#comment-17477036
]
Ignacio Vera edited comment on LUCENE-10288 at 1/17/22, 8:52 AM:
[
https://issues.apache.org/jira/browse/LUCENE-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477036#comment-17477036
]
Ignacio Vera commented on LUCENE-10288:
---
Yes, I think we can compute it cheaply b
46 matches
Mail list logo
