[GitHub] [lucene] jpountz commented on a change in pull request #654: LUCENE-10410: Add more tests for legacy decoding logic in DocIdsWriter

2022-02-07 Thread GitBox
jpountz commented on a change in pull request #654: URL: https://github.com/apache/lucene/pull/654#discussion_r801340328 ## File path: lucene/core/src/test/org/apache/lucene/util/bkd/TestDocIdsWriter.java ## @@ -110,7 +111,11 @@ private void test(Directory dir, int[] ints) thro

[jira] [Commented] (LUCENE-10378) Implement Weight#count on PointRangeQuery

2022-02-07 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488645#comment-17488645 ] Adrien Grand commented on LUCENE-10378: --- [~gworah] Have you had a chance to start

[jira] [Assigned] (LUCENE-10410) Add some more tests for legacy encoding logic in DocIdsWriter

2022-02-07 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Guo reassigned LUCENE-10410: - Assignee: Feng Guo > Add some more tests for legacy encoding logic in DocIdsWriter > -

[jira] [Updated] (LUCENE-10367) Use WANDScorer in CoveringQuery Can accelerate scorer time

2022-02-07 Thread LuYunCheng (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LuYunCheng updated LUCENE-10367: Status: Open (was: Patch Available) > Use WANDScorer in CoveringQuery Can accelerate scorer time

[jira] [Commented] (LUCENE-10409) Improve BKDWriter's DocIdsWriter to better encode decreasing sequences of doc IDs

2022-02-07 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488607#comment-17488607 ] Feng Guo commented on LUCENE-10409: --- +1, Great idea! I'd like to take on this if you

[jira] [Commented] (LUCENE-10382) Allow KnnVectorQuery to operate over a subset of liveDocs

2022-02-07 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488527#comment-17488527 ] Julie Tibshirani commented on LUCENE-10382: --- I had some time to try out the d

[GitHub] [lucene] jtibshirani commented on a change in pull request #656: LUCENE-10382: Support filtering in KnnVectorQuery

2022-02-07 Thread GitBox
jtibshirani commented on a change in pull request #656: URL: https://github.com/apache/lucene/pull/656#discussion_r801192735 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java ## @@ -227,16 +231,36 @@ public TopDocs search(Strin

[GitHub] [lucene] jtibshirani commented on pull request #656: LUCENE-10382: Support filtering in KnnVectorQuery

2022-02-07 Thread GitBox
jtibshirani commented on pull request #656: URL: https://github.com/apache/lucene/pull/656#issuecomment-1032109021 I tried out the around stopping the HNSW search early if it visits too many docs. To test, I modified `KnnGraphTester` to create `acceptDocs` uniformly at random with a certai

[jira] [Commented] (LUCENE-10400) Clean up the constructors' API signature of dictionary classes in kuromoji and nori

2022-02-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488511#comment-17488511 ] ASF subversion and git services commented on LUCENE-10400: -- Co

[GitHub] [lucene-solr] thelabdude merged pull request #2639: SOLR-15587: Don't use the UrlScheme singleton on the client-side

2022-02-07 Thread GitBox
thelabdude merged pull request #2639: URL: https://github.com/apache/lucene-solr/pull/2639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene] mocobeta commented on pull request #655: LUCENE-10400: cleanup obsolete APIs in kuromoji

2022-02-07 Thread GitBox
mocobeta commented on pull request #655: URL: https://github.com/apache/lucene/pull/655#issuecomment-1032088144 I'll backport the test to 9.x. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene] mocobeta merged pull request #655: LUCENE-10400: cleanup obsolete APIs in kuromoji

2022-02-07 Thread GitBox
mocobeta merged pull request #655: URL: https://github.com/apache/lucene/pull/655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [lucene] jtibshirani opened a new pull request #656: LUCENE-10382: Support filtering in KnnVectorQuery

2022-02-07 Thread GitBox
jtibshirani opened a new pull request #656: URL: https://github.com/apache/lucene/pull/656 This PR adds support for a query filter in KnnVectorQuery. First, we gather the query results for each leaf as a bit set. Then the HNSW search skips over the non-matching documents (using the sa

[jira] [Commented] (LUCENE-10216) Add concurrency to addIndexes(CodecReader…) API

2022-02-07 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488470#comment-17488470 ] Vigya Sharma commented on LUCENE-10216: --- Had some thoughts and questions about th

[GitHub] [lucene] jtibshirani merged pull request #645: Rename KnnGraphValues -> HnswGraph

2022-02-07 Thread GitBox
jtibshirani merged pull request #645: URL: https://github.com/apache/lucene/pull/645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [lucene] dweiss commented on pull request #645: Rename KnnGraphValues -> HnswGraph

2022-02-07 Thread GitBox
dweiss commented on pull request #645: URL: https://github.com/apache/lucene/pull/645#issuecomment-1031849263 > It doesn't give special information to git (instead git automatically detects renames by comparing the file contents). Correct. -- This is an automated message from the

[GitHub] [lucene-solr] thelabdude opened a new pull request #2639: SOLR-15587: Don't use the UrlScheme singleton on the client-side

2022-02-07 Thread GitBox
thelabdude opened a new pull request #2639: URL: https://github.com/apache/lucene-solr/pull/2639 Backport of https://github.com/apache/solr/pull/600 to 8_11 branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [lucene] jpountz commented on pull request #649: LUCENE-10408 Better encoding of doc Ids in vectors

2022-02-07 Thread GitBox
jpountz commented on pull request #649: URL: https://github.com/apache/lucene/pull/649#issuecomment-1031754530 Optimizing for the case when all docs have a value makes sense to me. > for a case when only certain documents have vectors, we do delta encoding of doc Ids. In the p

[GitHub] [lucene] jtibshirani commented on pull request #645: Rename KnnGraphValues -> HnswGraph

2022-02-07 Thread GitBox
jtibshirani commented on pull request #645: URL: https://github.com/apache/lucene/pull/645#issuecomment-1031710996 Thanks for the review! My understanding is that `git mv` is the same as `git rm` and `git add`. It doesn't give special information to git (instead git automatically detects r

[GitHub] [lucene] mocobeta edited a comment on pull request #643: LUCENE-10400: revise binary dictionaries' constructor in kuromoji

2022-02-07 Thread GitBox
mocobeta edited a comment on pull request #643: URL: https://github.com/apache/lucene/pull/643#issuecomment-1031541054 I opened https://github.com/apache/lucene/pull/655. I think the diff would be obvious - will merge it tomorrow. -- This is an automated message from the Apache Git Se

[GitHub] [lucene] mocobeta edited a comment on pull request #643: LUCENE-10400: revise binary dictionaries' constructor in kuromoji

2022-02-07 Thread GitBox
mocobeta edited a comment on pull request #643: URL: https://github.com/apache/lucene/pull/643#issuecomment-1031541054 I opened this https://github.com/apache/lucene/pull/655. I think the diff would be obvious - will merge it tomorrow. -- This is an automated message from the Apache G

[GitHub] [lucene] mocobeta commented on pull request #643: LUCENE-10400: revise binary dictionaries' constructor in kuromoji

2022-02-07 Thread GitBox
mocobeta commented on pull request #643: URL: https://github.com/apache/lucene/pull/643#issuecomment-1031541054 I opened this https://github.com/apache/lucene/pull/655/files. I think the diff would be obvious - will merge it tomorrow. -- This is an automated message from the Apache Gi

[GitHub] [lucene] mocobeta opened a new pull request #655: LUCENE-10400: cleanup obsolete APIs in kuromoji

2022-02-07 Thread GitBox
mocobeta opened a new pull request #655: URL: https://github.com/apache/lucene/pull/655 1. Remove deprecated constructors 2. Add / change tests for new constructors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [lucene-solr] noblepaul closed pull request #2638: 174234: We have observed that number of threads increases on one solr node after rebooting the solr node

2022-02-07 Thread GitBox
noblepaul closed pull request #2638: URL: https://github.com/apache/lucene-solr/pull/2638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[jira] [Commented] (LUCENE-10400) Clean up the constructors' API signature of dictionary classes in kuromoji and nori

2022-02-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488020#comment-17488020 ] ASF subversion and git services commented on LUCENE-10400: -- Co

[jira] [Commented] (LUCENE-10400) Clean up the constructors' API signature of dictionary classes in kuromoji and nori

2022-02-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488015#comment-17488015 ] ASF subversion and git services commented on LUCENE-10400: -- Co

[GitHub] [lucene] mocobeta merged pull request #643: LUCENE-10400: revise binary dictionaries' constructor in kuromoji

2022-02-07 Thread GitBox
mocobeta merged pull request #643: URL: https://github.com/apache/lucene/pull/643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [lucene] mocobeta commented on pull request #643: LUCENE-10400: revise binary dictionaries' constructor in kuromoji

2022-02-07 Thread GitBox
mocobeta commented on pull request #643: URL: https://github.com/apache/lucene/pull/643#issuecomment-1031313230 Thanks for reviewing, I'm going to merge this. I will open another pull request to remove the obsolete methods on main. -- This is an automated message from the Apache Git Serv

[GitHub] [lucene] gf2121 opened a new pull request #654: LUCENE-10410: Add more tests for legacy encoding logic in DocIdsWriter

2022-02-07 Thread GitBox
gf2121 opened a new pull request #654: URL: https://github.com/apache/lucene/pull/654 This is a follow-up of https://issues.apache.org/jira/browse/LUCENE-10315 (#541) . Add some more tests for legacy encoding logic in DocIdsWriter. -- This is an automated message from the Apache

[jira] [Created] (LUCENE-10410) Add some more tests for legacy encoding logic in DocIdsWriter

2022-02-07 Thread Feng Guo (Jira)
Feng Guo created LUCENE-10410: - Summary: Add some more tests for legacy encoding logic in DocIdsWriter Key: LUCENE-10410 URL: https://issues.apache.org/jira/browse/LUCENE-10410 Project: Lucene - Core

[jira] [Resolved] (LUCENE-10315) Speed up BKD leaf block ids codec by a 512 ints ForUtil

2022-02-07 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Guo resolved LUCENE-10315. --- Fix Version/s: 9.1 Resolution: Fixed > Speed up BKD leaf block ids codec by a 512 ints ForUt

[jira] [Assigned] (LUCENE-10315) Speed up BKD leaf block ids codec by a 512 ints ForUtil

2022-02-07 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Guo reassigned LUCENE-10315: - Assignee: Feng Guo > Speed up BKD leaf block ids codec by a 512 ints ForUtil > ---

[jira] [Commented] (LUCENE-10315) Speed up BKD leaf block ids codec by a 512 ints ForUtil

2022-02-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487977#comment-17487977 ] ASF subversion and git services commented on LUCENE-10315: -- Co

[GitHub] [lucene] gf2121 merged pull request #652: LUCENE-10315: Speed up BKD leaf block ids codec by a 512 ints ForUtil (backport 9x)

2022-02-07 Thread GitBox
gf2121 merged pull request #652: URL: https://github.com/apache/lucene/pull/652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Created] (LUCENE-10409) Improve BKDWriter's DocIdsWriter to better encode decreasing sequences of doc IDs

2022-02-07 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10409: - Summary: Improve BKDWriter's DocIdsWriter to better encode decreasing sequences of doc IDs Key: LUCENE-10409 URL: https://issues.apache.org/jira/browse/LUCENE-10409

[jira] [Commented] (LUCENE-10315) Speed up BKD leaf block ids codec by a 512 ints ForUtil

2022-02-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487952#comment-17487952 ] ASF subversion and git services commented on LUCENE-10315: -- Co

[GitHub] [lucene] gf2121 merged pull request #653: LUCENE-10315: add CHANGES for #541

2022-02-07 Thread GitBox
gf2121 merged pull request #653: URL: https://github.com/apache/lucene/pull/653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...