LuXugang opened a new pull request #720:
URL: https://github.com/apache/lucene/pull/720
I see IndexOrDocValuesQuery as a fallbackQuery of
IndexSortSortedNumericDocValuesRangeQuery in Elasticsearch, so After
[LUCENE-10442](https://issues.apache.org/jira/browse/LUCENE-10442), we should
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kkewwei updated LUCENE-10448:
-
Description:
We can see the code in *MergeRateLimiter*:
{code:java}
private long maybePause(long
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kkewwei updated LUCENE-10448:
-
Description:
We can see the code in *MergeRateLimiter*:
{code:java}
private long maybePause(long
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kkewwei updated LUCENE-10448:
-
Description:
We can see the code in *MergeRateLimiter*:
{code:java}
private long maybePause(long
[
https://issues.apache.org/jira/browse/LUCENE-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10450:
---
Issue Type: Improvement (was: Bug)
> IndexSortSortedNumericDocValuesRangeQuery could be rewrite
Lu Xugang created LUCENE-10450:
--
Summary: IndexSortSortedNumericDocValuesRangeQuery could be
rewrite to MatchAllDocsQuery
Key: LUCENE-10450
URL: https://issues.apache.org/jira/browse/LUCENE-10450
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kkewwei updated LUCENE-10448:
-
Description:
We can see the code in *MergeRateLimiter*:
{code:java}
private long maybePause(long
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kkewwei updated LUCENE-10448:
-
Description:
We can see the code in *MergeRateLimiter*:
{code:java}
private long maybePause(long
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kkewwei updated LUCENE-10448:
-
Description:
We can see the code in *MergeRateLimiter*:
{code:java}
private long maybePause(long
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kkewwei updated LUCENE-10448:
-
Description:
We can see the code in *MergeRateLimiter*:
{code:java}
private long maybePause(long
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kkewwei updated LUCENE-10448:
-
Description:
We can see the code in *MergeRateLimiter*:
{code:java}
private long maybePause(long
NightOwl888 commented on pull request #540:
URL: https://github.com/apache/lucene/pull/540#issuecomment-1056393563
Hi there. We (the Lucene.NET project) are waiting for approval of this
stemmer before we will accept it into our codebase
(https://github.com/apache/lucenenet/pull/571). We
codaitya commented on a change in pull request #446:
URL: https://github.com/apache/lucene/pull/446#discussion_r817326113
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/index/TestMergeOnFlushMergePolicy.java
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache
mocobeta commented on a change in pull request #717:
URL: https://github.com/apache/lucene/pull/717#discussion_r817317959
##
File path: build.gradle
##
@@ -183,3 +183,5 @@ apply from: file('gradle/hacks/turbocharge-jvm-opts.gradle')
apply from:
mocobeta commented on pull request #717:
URL: https://github.com/apache/lucene/pull/717#issuecomment-1056113863
Yes; it works on macOS.
```
% sw_vers [0][LUCENE-10447]
ProductName: macOS
ProductVersion: 11.6
BuildVersion:
wjp719 commented on pull request #687:
URL: https://github.com/apache/lucene/pull/687#issuecomment-1056088019
@jpountz @iverase now ./gradlew check all passed in my local machine, please
help to run check again
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/LUCENE-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani resolved LUCENE-10391.
---
Resolution: Fixed
> Reuse data structures across HnswGraph invocations
>
[
https://issues.apache.org/jira/browse/LUCENE-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-10391:
--
Fix Version/s: 9.1
> Reuse data structures across HnswGraph invocations
>
gsmiller opened a new pull request #719:
URL: https://github.com/apache/lucene/pull/719
This is a backport of #718. It provides backwards-compatiblity by delegating
existing "sum association faceting" implementations to the new classes. This
also provided an easy way to benchmark the
gsmiller opened a new pull request #718:
URL: https://github.com/apache/lucene/pull/718
# Description
This change adds support for "max" aggregations (in addition to "sum") to
association faceting. It does so in a way that is (somewhat) extensible for
future aggregation
[
https://issues.apache.org/jira/browse/LUCENE-10444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499820#comment-17499820
]
Greg Miller commented on LUCENE-10444:
--
I've got a couple PRs coming shortly for this. I ended up
dblock edited a comment on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1055853457
> > Should we parameterize the number of iterations parameter and use it as
test hook for getting the method to throw IllegalArgumentException?
>
> I'm not sure how
dblock commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1055853457
> > Should we parameterize the number of iterations parameter and use it as
test hook for getting the method to throw IllegalArgumentException?
>
> I'm not sure how useful
vigyasharma commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1055833683
>Should we parameterize the number of iterations parameter and use it as
test hook for getting the method to throw IllegalArgumentException?
I'm not sure how useful
vigyasharma commented on a change in pull request #711:
URL: https://github.com/apache/lucene/pull/711#discussion_r817117987
##
File path:
lucene/core/src/java/org/apache/lucene/search/MaxScoreSumPropagator.java
##
@@ -131,22 +131,28 @@ void setMinCompetitiveScore(float
vigyasharma commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1055823491
@jpountz Out of curiosity, what is the implication of returning whatever
minScore get's computed after 2 iterations? Like we do a best case effort to
converge, but return
dweiss commented on pull request #717:
URL: https://github.com/apache/lucene/pull/717#issuecomment-1055819833
@mocobeta would you give this patch a spin on a mac? Just in case...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/LUCENE-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499732#comment-17499732
]
Dawid Weiss commented on LUCENE-10447:
--
Tests passed, I think the workaround in the PR is fine
[
https://issues.apache.org/jira/browse/LUCENE-10432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499700#comment-17499700
]
Andriy Redko commented on LUCENE-10432:
---
Thanks [~jpountz] , the examples you have provided are
jainankitk commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1055772177
> @jpountz I'd write a test that uses invalid input to do more than 2
iterations and expect `IllegalStateException` with the right
values/description. Otherwise no test
[
https://issues.apache.org/jira/browse/LUCENE-10432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499693#comment-17499693
]
Adrien Grand commented on LUCENE-10432:
---
I'd rather not touch explanation. Since queries don't
dblock edited a comment on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1055741805
@jpountz I'd write a test that uses invalid input to do more than 2
iterations and expect `IllegalStateException` with the right
values/description. Otherwise no test
dblock commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1055743483
Link: https://issues.apache.org/jira/projects/LUCENE/issues/LUCENE-10428 for
future reference.
cc: @jainankitk
--
This is an automated message from the Apache Git
dblock commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1055741805
@jpountz I'd write a test that uses invalid input to do more than 2
iterations and expect `IllegalStateException` with the right values/description.
--
This is an automated
jpountz commented on a change in pull request #446:
URL: https://github.com/apache/lucene/pull/446#discussion_r817039024
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/index/TestMergeOnFlushMergePolicy.java
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache
jpountz commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1055735554
I was hoping for a :+1: from Ankit before merging.
Regarding tests, I was not able to identify the case that would break the
existing logic, so I'm not sure what new test
dblock edited a comment on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1055698281
Definitely needs tests.
What can we do to get this change into the next version of Lucene? I am
worried that we still don't have a consistent way to reproduce this
dblock edited a comment on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1055698281
What can we do to get this change into the next version of Lucene? I am
worried that we still don't have a consistent way to reproduce this issue.
--
This is an automated
dblock commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1055698281
What can we do to get this change into the next version of Lucene?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dweiss commented on pull request #717:
URL: https://github.com/apache/lucene/pull/717#issuecomment-1055645985
This doesn't work yet (on linux). Will take a look later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
codaitya commented on a change in pull request #446:
URL: https://github.com/apache/lucene/pull/446#discussion_r816958364
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/index/TestMergeOnFlushMergePolicy.java
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache
jpountz commented on a change in pull request #446:
URL: https://github.com/apache/lucene/pull/446#discussion_r816924091
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/index/TestMergeOnFlushMergePolicy.java
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache
codaitya commented on a change in pull request #446:
URL: https://github.com/apache/lucene/pull/446#discussion_r816915526
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/index/TestMergeOnFlushMergePolicy.java
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache
codaitya commented on a change in pull request #446:
URL: https://github.com/apache/lucene/pull/446#discussion_r816915526
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/index/TestMergeOnFlushMergePolicy.java
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/LUCENE-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499629#comment-17499629
]
Robert Muir commented on LUCENE-10449:
--
Looks like you aren't using BinaryDocValues, your source
[
https://issues.apache.org/jira/browse/LUCENE-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renaud Delbru updated LUCENE-10449:
---
Summary: Performance regression due to decompressBlock method introduced
with compression
[
https://issues.apache.org/jira/browse/LUCENE-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renaud Delbru updated LUCENE-10449:
---
Summary: Unnecessary decompressBlock method introduced with compression on
binary doc
[
https://issues.apache.org/jira/browse/LUCENE-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renaud Delbru updated LUCENE-10449:
---
Description:
LUCENE-9211 introduced a compression mechanism for binary doc values, which
Renaud Delbru created LUCENE-10449:
--
Summary: Unnecessary ByteArrayDataInput introduced with
compression on binary doc values introduced
Key: LUCENE-10449
URL: https://issues.apache.org/jira/browse/LUCENE-10449
[
https://issues.apache.org/jira/browse/LUCENE-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller resolved LUCENE-10440.
--
Fix Version/s: 9.1
10.0 (main)
Resolution: Fixed
> Reduce
jpountz commented on a change in pull request #446:
URL: https://github.com/apache/lucene/pull/446#discussion_r816815524
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/index/TestMergeOnFlushMergePolicy.java
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/LUCENE-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499566#comment-17499566
]
Adrien Grand commented on LUCENE-10428:
---
Sorry the PR should have been linked automatically in
[
https://issues.apache.org/jira/browse/LUCENE-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499564#comment-17499564
]
Adrien Grand commented on LUCENE-10431:
---
bq. IMO: If you don't want client code to use setters:
[
https://issues.apache.org/jira/browse/LUCENE-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499551#comment-17499551
]
ASF subversion and git services commented on LUCENE-10440:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499549#comment-17499549
]
ASF subversion and git services commented on LUCENE-10440:
--
Commit
gsmiller merged pull request #712:
URL: https://github.com/apache/lucene/pull/712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gsmiller merged pull request #713:
URL: https://github.com/apache/lucene/pull/713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499546#comment-17499546
]
Adrien Grand commented on LUCENE-10446:
---
I agree with you that IndexOrDocValuesQuery sometimes
jpountz commented on pull request #687:
URL: https://github.com/apache/lucene/pull/687#issuecomment-1055460224
One thing I'm not totally happy with is that the change assumes that the
field is either not indexed or indexed with `LongPoint` while this query would
previousy also work with
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kkewwei updated LUCENE-10448:
-
Description:
We can see the code in *MergeRateLimiter*:
{code:java}
private long maybePause(long
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kkewwei updated LUCENE-10448:
-
Description:
We can see the code in *MergeRateLimiter*:
{code:java}
private long maybePause(long
kkewwei created LUCENE-10448:
Summary: MergeRateLimiter doesn't always limit instant rate.
Key: LUCENE-10448
URL: https://issues.apache.org/jira/browse/LUCENE-10448
Project: Lucene - Core
Issue
sonatype-lift[bot] commented on a change in pull request #717:
URL: https://github.com/apache/lucene/pull/717#discussion_r816701565
##
File path: lucene/distribution/src/binary-release/bin/luke.sh
##
@@ -17,5 +17,12 @@
MODULES=`dirname "$0"`/..
MODULES=`cd "$MODULES" &&
[
https://issues.apache.org/jira/browse/LUCENE-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499480#comment-17499480
]
Dawid Weiss commented on LUCENE-10447:
--
This is a quick PR that should pass - it uses the same JVM
[
https://issues.apache.org/jira/browse/LUCENE-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499431#comment-17499431
]
Dawid Weiss commented on LUCENE-10447:
--
There is also a subtle problem here that the forked script
[
https://issues.apache.org/jira/browse/LUCENE-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499428#comment-17499428
]
Dawid Weiss commented on LUCENE-10447:
--
Yep, I know what this is - it's a bug.
> Charset issue in
[
https://issues.apache.org/jira/browse/LUCENE-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499426#comment-17499426
]
Lu Xugang commented on LUCENE-10447:
If I change my Operation System Language to English, Test will
[
https://issues.apache.org/jira/browse/LUCENE-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499425#comment-17499425
]
Lu Xugang commented on LUCENE-10447:
{quote}Can you check what charset is used by default by your
[
https://issues.apache.org/jira/browse/LUCENE-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10447:
---
Attachment: 2.png
> Charset issue in TestScripts#testLukeCanBeLaunched()
>
[
https://issues.apache.org/jira/browse/LUCENE-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499423#comment-17499423
]
Dawid Weiss commented on LUCENE-10447:
--
Just to clarify - I have implemented option (1) in the
[
https://issues.apache.org/jira/browse/LUCENE-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499420#comment-17499420
]
Dawid Weiss commented on LUCENE-10447:
--
Sorry, you're right - we don't:
{code:java}
private
[
https://issues.apache.org/jira/browse/LUCENE-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-10447:
-
Priority: Minor (was: Major)
> Charset issue in TestScripts#testLukeCanBeLaunched()
>
[
https://issues.apache.org/jira/browse/LUCENE-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499416#comment-17499416
]
Dawid Weiss commented on LUCENE-10447:
--
Can you check what charset is used by default by your
Lu Xugang created LUCENE-10447:
--
Summary: Charset issue in TestScripts#testLukeCanBeLaunched()
Key: LUCENE-10447
URL: https://issues.apache.org/jira/browse/LUCENE-10447
Project: Lucene - Core
wjp719 commented on pull request #687:
URL: https://github.com/apache/lucene/pull/687#issuecomment-1055191448
@iverase I have simplify dimensions to 1, please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/LUCENE-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10446:
---
Attachment: LUCENE-10446.patch
> Add a precise cost of score in ScorerSupplier
>
iverase commented on a change in pull request #687:
URL: https://github.com/apache/lucene/pull/687#discussion_r816535481
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java
##
@@ -181,12 +189,159 @@ public int
mogui commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r816533407
##
File path:
lucene/monitor/src/java/org/apache/lucene/monitor/ReadonlyQueryIndex.java
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
78 matches
Mail list logo
