[GitHub] [lucene] mikemccand commented on a change in pull request #633: [WIP] LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-03-04 Thread GitBox
mikemccand commented on a change in pull request #633: URL: https://github.com/apache/lucene/pull/633#discussion_r819703946 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -352,6 +352,14 @@ public FieldDimensions(int dimensionCount, int

[jira] [Resolved] (LUCENE-10432) Add optional 'name' property to org.apache.lucene.search.Explanation

2022-03-04 Thread Andriy Redko (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andriy Redko resolved LUCENE-10432. --- Resolution: Won't Do > Add optional 'name' property to

[jira] [Commented] (LUCENE-10302) PriorityQueue: optimize where we collect then iterate by using O(N) heapify

2022-03-04 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501358#comment-17501358 ] Greg Miller commented on LUCENE-10302: -- As I worked on this a little more, it occurs to me that I

[GitHub] [lucene] mayya-sharipova edited a comment on pull request #728: LUCENE-10194 Buffer KNN vectors on disk

2022-03-04 Thread GitBox
mayya-sharipova edited a comment on pull request #728: URL: https://github.com/apache/lucene/pull/728#issuecomment-1059202174 @msokolov Thanks a lot for your review. >I'm not sure what unset means? I guess it goes to the default 16MB, but I assume you must be doing the same in the

[GitHub] [lucene] mayya-sharipova edited a comment on pull request #728: LUCENE-10194 Buffer KNN vectors on disk

2022-03-04 Thread GitBox
mayya-sharipova edited a comment on pull request #728: URL: https://github.com/apache/lucene/pull/728#issuecomment-1059202174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [lucene] mayya-sharipova edited a comment on pull request #728: LUCENE-10194 Buffer KNN vectors on disk

2022-03-04 Thread GitBox
mayya-sharipova edited a comment on pull request #728: URL: https://github.com/apache/lucene/pull/728#issuecomment-1059202174 @msokolov Thanks a lot for your review. >I'm not sure what unset means? I guess it goes to the default 16MB, but I assume you must be doing the same in the

[GitHub] [lucene] mayya-sharipova commented on pull request #728: LUCENE-10194 Buffer KNN vectors on disk

2022-03-04 Thread GitBox
mayya-sharipova commented on pull request #728: URL: https://github.com/apache/lucene/pull/728#issuecomment-1059210295 @rmuir Thanks a lot for your review and explanation of of IndexWriter behavior. > If IndexWriter shouldn't buffer vectors, then can it simply stream vectors to the

[jira] [Comment Edited] (LUCENE-10302) PriorityQueue: optimize where we collect then iterate by using O(N) heapify

2022-03-04 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500898#comment-17500898 ] Greg Miller edited comment on LUCENE-10302 at 3/4/22, 2:23 PM: --- Thanks

[jira] [Comment Edited] (LUCENE-10302) PriorityQueue: optimize where we collect then iterate by using O(N) heapify

2022-03-04 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500898#comment-17500898 ] Greg Miller edited comment on LUCENE-10302 at 3/4/22, 2:22 PM: --- Thanks

[jira] [Commented] (LUCENE-10302) PriorityQueue: optimize where we collect then iterate by using O(N) heapify

2022-03-04 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501354#comment-17501354 ] Greg Miller commented on LUCENE-10302: -- [~vigyas] ah, it looks like the URL pulled in a trailing

[GitHub] [lucene] mayya-sharipova commented on pull request #728: LUCENE-10194 Buffer KNN vectors on disk

2022-03-04 Thread GitBox
mayya-sharipova commented on pull request #728: URL: https://github.com/apache/lucene/pull/728#issuecomment-1059202282 @jtibshirani Thanks a lot for your review. > If a user had 100 vector fields, then now we might have 100+ files being written concurrently, multiplied by the

[GitHub] [lucene] mayya-sharipova commented on pull request #728: LUCENE-10194 Buffer KNN vectors on disk

2022-03-04 Thread GitBox
mayya-sharipova commented on pull request #728: URL: https://github.com/apache/lucene/pull/728#issuecomment-1059202174 @msokolov Thanks a lot for your review. >I'm not sure what unset means? I guess it goes to the default 16MB, but I assume you must be doing the same in the other

[jira] [Commented] (LUCENE-10430) Literal double quotes cause exception in class RegExp

2022-03-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501341#comment-17501341 ] Robert Muir commented on LUCENE-10430: -- This is a meta character. See grammar in the

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-04 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501314#comment-17501314 ] kkewwei edited comment on LUCENE-10448 at 3/4/22, 1:27 PM: --- Yes, bytes may be

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-04 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501314#comment-17501314 ] kkewwei edited comment on LUCENE-10448 at 3/4/22, 1:26 PM: --- Yes, bytes may be

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-04 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501314#comment-17501314 ] kkewwei edited comment on LUCENE-10448 at 3/4/22, 1:09 PM: --- Yes, bytes may be

[jira] [Commented] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-04 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501314#comment-17501314 ] kkewwei commented on LUCENE-10448: -- Yes, bytes may be bigger than MIN_PAUSE_CHECK_MSEC, because byte[]

[GitHub] [lucene] mocobeta commented on pull request #717: LUCENE-10447: always use utf8 for forked process encoding. Use the sa…

2022-03-04 Thread GitBox
mocobeta commented on pull request #717: URL: https://github.com/apache/lucene/pull/717#issuecomment-1059098369 Thanks, Dawid for taking care of this. It's a hard time, especially in Europe - please stay safe, I believe you are doing well though. -- This is an automated message from the

[jira] [Commented] (LUCENE-10431) AssertionError in BooleanQuery.hashCode()

2022-03-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501292#comment-17501292 ] ASF subversion and git services commented on LUCENE-10431: -- Commit

[jira] [Commented] (LUCENE-10431) AssertionError in BooleanQuery.hashCode()

2022-03-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501291#comment-17501291 ] ASF subversion and git services commented on LUCENE-10431: -- Commit

[GitHub] [lucene] romseygeek merged pull request #727: LUCENE-10431: Don't include rewriteMethod in MTQ hash calculation

2022-03-04 Thread GitBox
romseygeek merged pull request #727: URL: https://github.com/apache/lucene/pull/727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] romseygeek merged pull request #726: LUCENE-10431: Remove MultiTermQuery.setRewriteMethod()

2022-03-04 Thread GitBox
romseygeek merged pull request #726: URL: https://github.com/apache/lucene/pull/726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] rmuir commented on a change in pull request #709: LUCENE-10311: remove complex cost estimation and abstraction leakage around it

2022-03-04 Thread GitBox
rmuir commented on a change in pull request #709: URL: https://github.com/apache/lucene/pull/709#discussion_r819498097 ## File path: lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java ## @@ -181,19 +144,27 @@ public void add(DocIdSetIterator iter) throws

[GitHub] [lucene] rmuir commented on pull request #709: LUCENE-10311: remove complex cost estimation and abstraction leakage around it

2022-03-04 Thread GitBox
rmuir commented on pull request #709: URL: https://github.com/apache/lucene/pull/709#issuecomment-1059085772 For the record this DocIdSetBuilder.Buffer has been so damaging to our code, insanely, I'm still here trying to calm down the explosion of horribleness caused by it. I

[GitHub] [lucene] rmuir commented on a change in pull request #709: LUCENE-10311: remove complex cost estimation and abstraction leakage around it

2022-03-04 Thread GitBox
rmuir commented on a change in pull request #709: URL: https://github.com/apache/lucene/pull/709#discussion_r819493935 ## File path: lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java ## @@ -181,19 +144,27 @@ public void add(DocIdSetIterator iter) throws

[GitHub] [lucene] ldkjdk commented on pull request #730: Create ConjunctionDISI:patcher

2022-03-04 Thread GitBox
ldkjdk commented on pull request #730: URL: https://github.com/apache/lucene/pull/730#issuecomment-1058955767 ![image](https://user-images.githubusercontent.com/12707336/156729170-834477ab-3b2d-4c6d-8889-1e9c06b62736.png) -- This is an automated message from the Apache Git Service.

[GitHub] [lucene] iverase commented on a change in pull request #709: LUCENE-10311: remove complex cost estimation and abstraction leakage around it

2022-03-04 Thread GitBox
iverase commented on a change in pull request #709: URL: https://github.com/apache/lucene/pull/709#discussion_r819367360 ## File path: lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java ## @@ -181,19 +144,27 @@ public void add(DocIdSetIterator iter) throws

[GitHub] [lucene] ldkjdk opened a new pull request #730: Create ConjunctionDISI:patcher

2022-03-04 Thread GitBox
ldkjdk opened a new pull request #730: URL: https://github.com/apache/lucene/pull/730 may be this a performance bug for multiple segment, when docid is 2147483647 shoud do not to continue for search next doc # Description Please provide a short description of the

[GitHub] [lucene] iverase commented on a change in pull request #709: LUCENE-10311: remove complex cost estimation and abstraction leakage around it

2022-03-04 Thread GitBox
iverase commented on a change in pull request #709: URL: https://github.com/apache/lucene/pull/709#discussion_r819354785 ## File path: lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java ## @@ -181,19 +144,27 @@ public void add(DocIdSetIterator iter) throws