vigyasharma commented on pull request #633:
URL: https://github.com/apache/lucene/pull/633#issuecomment-1068485083
`./gradlew check` had passed on my local machine. However, some tests have
randomization and don't always invoke `addIndexes(CodecReaders...)`, and have
failed in the run
[
https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507227#comment-17507227
]
Peter Gromov edited comment on LUCENE-10451 at 3/15/22, 8:54 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507227#comment-17507227
]
Peter Gromov commented on LUCENE-10451:
---
[~dweiss] That'd be nice. Do you approve this backport?
[
https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507197#comment-17507197
]
Dawid Weiss commented on LUCENE-10451:
--
Hi Peter. You may want to backport to branch_9x as well?
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r827351556
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -76,6 +79,7 @@
final String field;
[
https://issues.apache.org/jira/browse/LUCENE-10311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507177#comment-17507177
]
ASF subversion and git services commented on LUCENE-10311:
--
Commit
vigyasharma commented on pull request #633:
URL: https://github.com/apache/lucene/pull/633#issuecomment-1068300899
I think this PR has reasonable test coverage and can come out of WIP now.
Will continue to iterate on the PR comments and suggestions..
--
This is an automated message
vigyasharma commented on pull request #633:
URL: https://github.com/apache/lucene/pull/633#issuecomment-1068299715
### New Changes:
1. `addIndexes(CodecReader...)` merges are abortable now.
* Earlier, `addIndexes(CodecReader...)` triggered merges directly via
SegmentMerger. As
vigyasharma commented on a change in pull request #633:
URL: https://github.com/apache/lucene/pull/633#discussion_r827274463
##
File path: lucene/core/src/java/org/apache/lucene/index/NoMergePolicy.java
##
@@ -39,6 +40,11 @@ public MergeSpecification findMerges(
return
reta commented on pull request #749:
URL: https://github.com/apache/lucene/pull/749#issuecomment-1068292093
@jtibshirani would very appreciate your feedback on the fix, I have tried to
go wild with typed approach (typed sorted ranges / doc values for
int/long/double/float) but went down
vigyasharma commented on a change in pull request #633:
URL: https://github.com/apache/lucene/pull/633#discussion_r827270775
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -3121,147 +3125,265 @@ private void validateMergeReader(CodecReader
[
https://issues.apache.org/jira/browse/LUCENE-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507137#comment-17507137
]
Greg Miller commented on LUCENE-10468:
--
+1, I appreciate the field checking done by the DocValues
[
https://issues.apache.org/jira/browse/LUCENE-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507137#comment-17507137
]
Greg Miller edited comment on LUCENE-10468 at 3/15/22, 6:01 PM:
+1 to
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r827269196
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -190,20 +235,45 @@ private FacetResult
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r827269196
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -190,20 +235,45 @@ private FacetResult
reta opened a new pull request #749:
URL: https://github.com/apache/lucene/pull/749
# Description
IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage
of the LONG-encoded SortField. Using the numeric range query (in case of sorted
index) with anything but
[
https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Gromov closed LUCENE-10451.
-
> Hunspell: don't perform potentially expensive spellchecking after timeout
>
[
https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Gromov resolved LUCENE-10451.
---
Fix Version/s: 9.2
Resolution: Fixed
> Hunspell: don't perform potentially
[
https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507119#comment-17507119
]
ASF subversion and git services commented on LUCENE-10451:
--
Commit
donnerpeter merged pull request #721:
URL: https://github.com/apache/lucene/pull/721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gsmiller commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r827230655
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/sortedset/TestSortedSetDocValuesFacets.java
##
@@ -104,6 +104,65 @@ public void testBasic()
gsmiller commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r826448307
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -414,4 +493,107 @@ public int
[
https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506988#comment-17506988
]
Adrien Grand commented on LUCENE-10078:
---
The more I think about it, the more I like the idea of
wjp719 commented on pull request #731:
URL: https://github.com/apache/lucene/pull/731#issuecomment-1068122549
@iverase Hi, can you help to review this pr, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
wjp719 commented on pull request #687:
URL: https://github.com/apache/lucene/pull/687#issuecomment-1068112283
@jpountz Hi, please help to take some time to review this pr again, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/LUCENE-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506969#comment-17506969
]
Adrien Grand commented on LUCENE-10468:
---
This looks like a feature to me, not a bug. If you are
[
https://issues.apache.org/jira/browse/LUCENE-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10468:
---
Attachment: 1.png
> Do not always do checkField() in DocValues.getXXX(LeafReader, String)
>
Lu Xugang created LUCENE-10468:
--
Summary: Do not always do checkField() in
DocValues.getXXX(LeafReader, String)
Key: LUCENE-10468
URL: https://issues.apache.org/jira/browse/LUCENE-10468
Project: Lucene
[
https://issues.apache.org/jira/browse/LUCENE-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida resolved LUCENE-10463.
Fix Version/s: 10.0 (main)
Resolution: Fixed
> Make smoke tester script work on
mocobeta closed pull request #696:
URL: https://github.com/apache/lucene/pull/696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mocobeta closed pull request #746:
URL: https://github.com/apache/lucene/pull/746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506849#comment-17506849
]
ASF subversion and git services commented on LUCENE-10463:
--
Commit
mocobeta merged pull request #748:
URL: https://github.com/apache/lucene/pull/748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mocobeta commented on pull request #748:
URL: https://github.com/apache/lucene/pull/748#issuecomment-1067841869
I'm skipping Actions CI checks (this does not run the smoke tester as far as
I know).
--
This is an automated message from the Apache Git Service.
To respond to the message,
mocobeta opened a new pull request #748:
URL: https://github.com/apache/lucene/pull/748
Update java version in the smoke tester for main branch. We don't run the
script on CI servers for main; just to make it work on main for testing
purposes etc.
This works for me on main / java 17.
[
https://issues.apache.org/jira/browse/LUCENE-10385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-10385:
--
Fix Version/s: 9.2
(was: 9.1)
> Implement Weight#count on
[
https://issues.apache.org/jira/browse/LUCENE-10385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand reopened LUCENE-10385:
---
> Implement Weight#count on IndexSortSortedNumericDocValuesRangeQuery.
>
mogui commented on pull request #679:
URL: https://github.com/apache/lucene/pull/679#issuecomment-1067734639
@romseygeek I've merged main and restored listeners to the abstarct class,
You were right the sleep was very ugly
--
This is an automated message from the Apache Git Service.
To
38 matches
Mail list logo
