[GitHub] [lucene] Yuti-G commented on a change in pull request #747: LUCENE-10325: Add getTopDims functionality to Facets

2022-03-22 Thread GitBox
Yuti-G commented on a change in pull request #747: URL: https://github.com/apache/lucene/pull/747#discussion_r832745109 ## File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java ## @@ -178,10 +229,23 @@ private FacetResult

[GitHub] [lucene] Yuti-G commented on a change in pull request #747: LUCENE-10325: Add getTopDims functionality to Facets

2022-03-22 Thread GitBox
Yuti-G commented on a change in pull request #747: URL: https://github.com/apache/lucene/pull/747#discussion_r832745109 ## File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java ## @@ -178,10 +229,23 @@ private FacetResult

[GitHub] [lucene] Yuti-G commented on a change in pull request #747: LUCENE-10325: Add getTopDims functionality to Facets

2022-03-22 Thread GitBox
Yuti-G commented on a change in pull request #747: URL: https://github.com/apache/lucene/pull/747#discussion_r832745109 ## File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java ## @@ -178,10 +229,23 @@ private FacetResult

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-03-22 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510880#comment-17510880 ] Mike Drob commented on LUCENE-10481: Hmm... some slightly disappointing results - although we saw

[GitHub] [lucene] gsmiller commented on a change in pull request #747: LUCENE-10325: Add getTopDims functionality to Facets

2022-03-22 Thread GitBox
gsmiller commented on a change in pull request #747: URL: https://github.com/apache/lucene/pull/747#discussion_r832488053 ## File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java ## @@ -178,10 +229,23 @@ private FacetResult

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-03-22 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510809#comment-17510809 ] Mike Drob commented on LUCENE-10481: I _think_ the use case would be to collect facets over only

[GitHub] [lucene] madrob opened a new pull request #760: LUCENE-10481: FacetsCollector will not request scores if it does not use them

2022-03-22 Thread GitBox
madrob opened a new pull request #760: URL: https://github.com/apache/lucene/pull/760 LUCENE-10481: FacetsCollector will not request scores if it does not use them # Description When not collecting any documents, we don't need FacetsCollector to request scores. #

[GitHub] [lucene] madrob commented on pull request #760: LUCENE-10481: FacetsCollector will not request scores if it does not use them

2022-03-22 Thread GitBox
madrob commented on pull request #760: URL: https://github.com/apache/lucene/pull/760#issuecomment-1075437489 Local benchmarks showed a 2x improvement for facet counting when doing a search with filter queries. I'm attempting to replicate this using our existing lucene benchmarks, but

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-03-22 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510793#comment-17510793 ] Adrien Grand commented on LUCENE-10481: --- Your change looks good, but this makes me wonder why the

[jira] [Created] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-03-22 Thread Mike Drob (Jira)
Mike Drob created LUCENE-10481: -- Summary: FacetsCollector does not need scores when not keeping them Key: LUCENE-10481 URL: https://issues.apache.org/jira/browse/LUCENE-10481 Project: Lucene - Core

[jira] [Resolved] (LUCENE-10477) SpanBoostQuery.rewrite was incomplete for boost==1 factor

2022-03-22 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved LUCENE-10477. -- Fix Version/s: 10.0 (main) 9.2 Resolution: Fixed

[jira] [Commented] (LUCENE-10477) SpanBoostQuery.rewrite was incomplete for boost==1 factor

2022-03-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510705#comment-17510705 ] ASF subversion and git services commented on LUCENE-10477: -- Commit

[GitHub] [lucene] madrob opened a new pull request #759: LUCENE-9651 Update benchmark module docs

2022-03-22 Thread GitBox
madrob opened a new pull request #759: URL: https://github.com/apache/lucene/pull/759 LUCENE-9651: Update javadoc and download tasks for benchmarks module # Description Update the Reuters download task to extract data where most of the benchmarks already expect it. Update

[jira] [Commented] (LUCENE-10477) SpanBoostQuery.rewrite was incomplete for boost==1 factor

2022-03-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510702#comment-17510702 ] ASF subversion and git services commented on LUCENE-10477: -- Commit

[GitHub] [lucene] cpoerschke merged pull request #758: LUCENE-10477: mention 'call multiple times' in Query.rewrite javadoc

2022-03-22 Thread GitBox
cpoerschke merged pull request #758: URL: https://github.com/apache/lucene/pull/758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-10477) SpanBoostQuery.rewrite was incomplete for boost==1 factor

2022-03-22 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510680#comment-17510680 ] Christine Poerschke commented on LUCENE-10477: -- bq. ... Would it be worth documenting e.g.

[jira] [Resolved] (LUCENE-10464) unnecessary for-loop in WeightedSpanTermExtractor.extractWeightedSpanTerms

2022-03-22 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved LUCENE-10464. -- Fix Version/s: 10.0 (main) 9.2 Resolution: Fixed >

[GitHub] [lucene] cpoerschke opened a new pull request #758: LUCENE-10477: mention 'call multiple times' in Query.rewrite javadoc

2022-03-22 Thread GitBox
cpoerschke opened a new pull request #758: URL: https://github.com/apache/lucene/pull/758 https://issues.apache.org/jira/browse/LUCENE-10477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Closed] (LUCENE-10382) Allow KnnVectorQuery to operate over a subset of liveDocs

2022-03-22 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand closed LUCENE-10382. - Close after 9.1.0 release. > Allow KnnVectorQuery to operate over a subset of liveDocs >

[jira] [Resolved] (LUCENE-10382) Allow KnnVectorQuery to operate over a subset of liveDocs

2022-03-22 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10382. --- Resolution: Fixed > Allow KnnVectorQuery to operate over a subset of liveDocs >

[jira] [Updated] (LUCENE-10458) BoundedDocSetIdIterator may supply error count in Weigth#count(LeafReaderContext) when missingValue enables

2022-03-22 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-10458: -- Fix Version/s: (was: 9.1) > BoundedDocSetIdIterator may supply error count in >

[jira] [Commented] (LUCENE-10477) SpanBoostQuery.rewrite was incomplete for boost==1 factor

2022-03-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510547#comment-17510547 ] ASF subversion and git services commented on LUCENE-10477: -- Commit

[jira] [Commented] (LUCENE-10477) SpanBoostQuery.rewrite was incomplete for boost==1 factor

2022-03-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510541#comment-17510541 ] ASF subversion and git services commented on LUCENE-10477: -- Commit

[jira] [Commented] (LUCENE-10464) unnecessary for-loop in WeightedSpanTermExtractor.extractWeightedSpanTerms

2022-03-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510540#comment-17510540 ] ASF subversion and git services commented on LUCENE-10464: -- Commit

[GitHub] [lucene] cpoerschke merged pull request #737: LUCENE-10464, LUCENE-10477: WeightedSpanTermExtractor.extractWeightedSpanTerms to rewrite sufficiently

2022-03-22 Thread GitBox
cpoerschke merged pull request #737: URL: https://github.com/apache/lucene/pull/737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (LUCENE-10479) Benchmark documentation referes to non-existent tasks

2022-03-22 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved LUCENE-10479. Resolution: Duplicate > Benchmark documentation referes to non-existent tasks >

[jira] [Created] (LUCENE-10480) Specialize 2-clauses disjunctions

2022-03-22 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10480: - Summary: Specialize 2-clauses disjunctions Key: LUCENE-10480 URL: https://issues.apache.org/jira/browse/LUCENE-10480 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-22 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510491#comment-17510491 ] Adrien Grand commented on LUCENE-10448: --- bq. it is guaranteed that there will be no big chunks

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-22 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510477#comment-17510477 ] kkewwei edited comment on LUCENE-10448 at 3/22/22, 1:09 PM: Optimization

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-22 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510477#comment-17510477 ] kkewwei edited comment on LUCENE-10448 at 3/22/22, 1:08 PM: Optimization

[jira] [Commented] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-22 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510477#comment-17510477 ] kkewwei commented on LUCENE-10448: -- Optimization seems have nothing to do with memory pressure, it is

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-22 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510477#comment-17510477 ] kkewwei edited comment on LUCENE-10448 at 3/22/22, 1:00 PM: Optimization

[GitHub] [lucene] mocobeta commented on pull request #740: LUCENE-10393: Unify binary dictionary and dictionary writer in kuromoji and nori

2022-03-22 Thread GitBox
mocobeta commented on pull request #740: URL: https://github.com/apache/lucene/pull/740#issuecomment-1075037005 I added test modules `analysis/kuromoji.tests` and `analysis/nori.tests` to make sure that both tokenizers correctly load the dictionary resources and work in module-mode. They

[GitHub] [lucene] jpountz commented on a change in pull request #737: LUCENE-10464, LUCENE-10477: WeightedSpanTermExtractor.extractWeightedSpanTerms to rewrite sufficiently

2022-03-22 Thread GitBox
jpountz commented on a change in pull request #737: URL: https://github.com/apache/lucene/pull/737#discussion_r831971359 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTermExtractor.java ## @@ -309,11 +309,12 @@ protected void

[GitHub] [lucene] mocobeta closed pull request #755: Add note for smoke tester --tmp-dir option in rc announcing

2022-03-22 Thread GitBox
mocobeta closed pull request #755: URL: https://github.com/apache/lucene/pull/755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] mocobeta commented on pull request #755: Add note for smoke tester --tmp-dir option in rc announcing

2022-03-22 Thread GitBox
mocobeta commented on pull request #755: URL: https://github.com/apache/lucene/pull/755#issuecomment-1074927120 The test in question was excluded from nightly tests (LUCENE-10478). We may not need to change the smoke tester or release wizard for disk usage - if a test uses lots of disk

[jira] [Commented] (LUCENE-10422) Monitor instantiation configurabilty improvements

2022-03-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510362#comment-17510362 ] ASF subversion and git services commented on LUCENE-10422: -- Commit

[jira] [Commented] (LUCENE-10422) Monitor instantiation configurabilty improvements

2022-03-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510359#comment-17510359 ] ASF subversion and git services commented on LUCENE-10422: -- Commit

[jira] [Resolved] (LUCENE-10478) Mark Test4GBStoredFields as @Monster (it consumes a lot of disk)

2022-03-22 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-10478. Fix Version/s: 10.0 (main) 9.2 Resolution: Fixed > Mark

[jira] [Commented] (LUCENE-10478) Mark Test4GBStoredFields as @Monster (it consumes a lot of disk)

2022-03-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510345#comment-17510345 ] ASF subversion and git services commented on LUCENE-10478: -- Commit

[jira] [Commented] (LUCENE-10478) Mark Test4GBStoredFields as @Monster (it consumes a lot of disk)

2022-03-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510340#comment-17510340 ] ASF subversion and git services commented on LUCENE-10478: -- Commit

[GitHub] [lucene] mocobeta merged pull request #757: LUCENE-10478: mark Test4GBStoredFields as @Monster

2022-03-22 Thread GitBox
mocobeta merged pull request #757: URL: https://github.com/apache/lucene/pull/757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] mocobeta commented on a change in pull request #757: LUCENE-10478: mark Test4GBStoredFields as @Monster

2022-03-22 Thread GitBox
mocobeta commented on a change in pull request #757: URL: https://github.com/apache/lucene/pull/757#discussion_r831910208 ## File path: lucene/core/src/test/org/apache/lucene/index/Test4GBStoredFields.java ## @@ -26,13 +26,15 @@ import