[jira] [Commented] (LUCENE-10456) Implement Weight#count for MultiRangeQuery

2022-03-23 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511561#comment-17511561 ] Gautam Worah commented on LUCENE-10456: --- Thanks for the patch [~wjp719] . I added some comments.

[GitHub] [lucene] gautamworah96 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-23 Thread GitBox
gautamworah96 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r833853974 ## File path: lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestMultiRangeQueries.java ## @@ -761,4 +764,67 @@ public void

[GitHub] [lucene] gautamworah96 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-23 Thread GitBox
gautamworah96 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r833853974 ## File path: lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestMultiRangeQueries.java ## @@ -761,4 +764,67 @@ public void

[GitHub] [lucene] gautamworah96 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-23 Thread GitBox
gautamworah96 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r833834846 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java ## @@ -314,6 +370,32 @@ public Scorer

[jira] [Commented] (LUCENE-9651) Correct javadoc for benchmarks

2022-03-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511459#comment-17511459 ] ASF subversion and git services commented on LUCENE-9651: - Commit

[jira] [Resolved] (LUCENE-9651) Correct javadoc for benchmarks

2022-03-23 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved LUCENE-9651. --- Fix Version/s: 10.0 (main) Assignee: Mike Drob (was: Dawid Weiss) Resolution: Fixed

[GitHub] [lucene] madrob merged pull request #759: LUCENE-9651 Update benchmark module docs

2022-03-23 Thread GitBox
madrob merged pull request #759: URL: https://github.com/apache/lucene/pull/759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] dweiss commented on a change in pull request #759: LUCENE-9651 Update benchmark module docs

2022-03-23 Thread GitBox
dweiss commented on a change in pull request #759: URL: https://github.com/apache/lucene/pull/759#discussion_r833606926 ## File path: lucene/benchmark/conf/readContentSource.alg ## @@ -24,7 +24,7 @@ # # To use this, first cd to benchmark and then run: # -# ant run-task

[GitHub] [lucene] dweiss commented on a change in pull request #759: LUCENE-9651 Update benchmark module docs

2022-03-23 Thread GitBox
dweiss commented on a change in pull request #759: URL: https://github.com/apache/lucene/pull/759#discussion_r833606260 ## File path: gradle/datasets/external-datasets.gradle ## @@ -120,10 +120,9 @@ configure(project(":lucene:benchmark")) { task getReuters(type: Download) {

[jira] [Commented] (LUCENE-10466) IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

2022-03-23 Thread Andriy Redko (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511427#comment-17511427 ] Andriy Redko commented on LUCENE-10466: --- Thanks [~jpountz] , at least `INTEGER` is the one we run

[GitHub] [lucene] mogui commented on pull request #679: Monitor Improvements LUCENE-10422

2022-03-23 Thread GitBox
mogui commented on pull request #679: URL: https://github.com/apache/lucene/pull/679#issuecomment-1076658125 @romseygeek There is something else in roadmap or future ideas regarding this package that I can contribute? Or where I can look to contribute more to the project. I'd like to

[GitHub] [lucene] Yuti-G commented on a change in pull request #747: LUCENE-10325: Add getTopDims functionality to Facets

2022-03-23 Thread GitBox
Yuti-G commented on a change in pull request #747: URL: https://github.com/apache/lucene/pull/747#discussion_r832745109 ## File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java ## @@ -178,10 +229,23 @@ private FacetResult

[GitHub] [lucene] jpountz commented on pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

2022-03-23 Thread GitBox
jpountz commented on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1076562502 FYI https://github.com/apache/lucene/pull/736 is now merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (LUCENE-10466) IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

2022-03-23 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511368#comment-17511368 ] Adrien Grand commented on LUCENE-10466: --- [~reta] I'm curious if there is a specific type of data

[jira] [Commented] (LUCENE-10078) Enable merge-on-refresh by default?

2022-03-23 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511362#comment-17511362 ] Adrien Grand commented on LUCENE-10078: --- Thanks Anand!  > Enable merge-on-refresh by default? >

[jira] [Commented] (LUCENE-10204) Support iteration of sub-matches in join queries (ToParentBlockJoinQuery / ToChildBlockJoinQuery)

2022-03-23 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511359#comment-17511359 ] Adrien Grand commented on LUCENE-10204: --- I have a bias against features that expose the state of

[GitHub] [lucene] jpountz merged pull request #736: LUCENE-10458: BoundedDocSetIdIterator may supply error count in Weigth#count(LeafReaderContext) when missingValue enables

2022-03-23 Thread GitBox
jpountz merged pull request #736: URL: https://github.com/apache/lucene/pull/736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (LUCENE-10458) BoundedDocSetIdIterator may supply error count in Weigth#count(LeafReaderContext) when missingValue enables

2022-03-23 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10458. --- Fix Version/s: 9.2 Resolution: Fixed Thanks for your perseverance [~ChrisLu]! >

[jira] [Commented] (LUCENE-10458) BoundedDocSetIdIterator may supply error count in Weigth#count(LeafReaderContext) when missingValue enables

2022-03-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511302#comment-17511302 ] ASF subversion and git services commented on LUCENE-10458: -- Commit

[jira] [Commented] (LUCENE-10458) BoundedDocSetIdIterator may supply error count in Weigth#count(LeafReaderContext) when missingValue enables

2022-03-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511298#comment-17511298 ] ASF subversion and git services commented on LUCENE-10458: -- Commit

[jira] [Resolved] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-03-23 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved LUCENE-10481. Fix Version/s: 9.2 Assignee: Mike Drob Resolution: Fixed > FacetsCollector does

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-03-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511290#comment-17511290 ] ASF subversion and git services commented on LUCENE-10481: -- Commit

[GitHub] [lucene] madrob merged pull request #760: LUCENE-10481: FacetsCollector will not request scores if it does not use them

2022-03-23 Thread GitBox
madrob merged pull request #760: URL: https://github.com/apache/lucene/pull/760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] madrob commented on a change in pull request #759: LUCENE-9651 Update benchmark module docs

2022-03-23 Thread GitBox
madrob commented on a change in pull request #759: URL: https://github.com/apache/lucene/pull/759#discussion_r833343167 ## File path: lucene/benchmark/conf/readContentSource.alg ## @@ -24,7 +24,7 @@ # # To use this, first cd to benchmark and then run: # -# ant run-task

[GitHub] [lucene] madrob commented on a change in pull request #759: LUCENE-9651 Update benchmark module docs

2022-03-23 Thread GitBox
madrob commented on a change in pull request #759: URL: https://github.com/apache/lucene/pull/759#discussion_r833342739 ## File path: lucene/benchmark/conf/tokenize.alg ## @@ -22,7 +22,7 @@ # # To use this, cd to benchmark and then run: # -# ant run-task

[GitHub] [lucene] madrob commented on a change in pull request #759: LUCENE-9651 Update benchmark module docs

2022-03-23 Thread GitBox
madrob commented on a change in pull request #759: URL: https://github.com/apache/lucene/pull/759#discussion_r833340902 ## File path: lucene/benchmark/conf/readContentSource.alg ## @@ -24,7 +24,7 @@ # # To use this, first cd to benchmark and then run: # -# ant run-task

[GitHub] [lucene] madrob commented on a change in pull request #759: LUCENE-9651 Update benchmark module docs

2022-03-23 Thread GitBox
madrob commented on a change in pull request #759: URL: https://github.com/apache/lucene/pull/759#discussion_r833317662 ## File path: gradle/datasets/external-datasets.gradle ## @@ -120,10 +120,9 @@ configure(project(":lucene:benchmark")) { task getReuters(type: Download) {

[jira] [Resolved] (LUCENE-10473) Address slow testRandomBig runs

2022-03-23 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10473. --- Fix Version/s: 9.2 Resolution: Fixed There's certainly more we can do to speed up

[GitHub] [lucene] mocobeta commented on pull request #740: LUCENE-10393: Unify binary dictionary and dictionary writer in kuromoji and nori

2022-03-23 Thread GitBox
mocobeta commented on pull request #740: URL: https://github.com/apache/lucene/pull/740#issuecomment-1076372738 Hi @rmuir, I just wanted to ping you to let you know that I requested a review (in github) a little while ago. I don't intend to rush you, thanks. -- This is an automated

[GitHub] [lucene] mocobeta edited a comment on pull request #740: LUCENE-10393: Unify binary dictionary and dictionary writer in kuromoji and nori

2022-03-23 Thread GitBox
mocobeta edited a comment on pull request #740: URL: https://github.com/apache/lucene/pull/740#issuecomment-1076194540 To me, this is already self-contained and ready to be merged. This is not perfect though, I think it would be a start point to move forward (having flexibly switchable or

[GitHub] [lucene] mocobeta commented on pull request #740: LUCENE-10393: Unify binary dictionary and dictionary writer in kuromoji and nori

2022-03-23 Thread GitBox
mocobeta commented on pull request #740: URL: https://github.com/apache/lucene/pull/740#issuecomment-1076194540 To me, this is already self-contained and ready to be merged. This is not perfect though, I think it would be a start point to move forward (having flexibly switchable or

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-03-23 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511129#comment-17511129 ] Adrien Grand commented on LUCENE-10481: --- It's still a good change. :) > FacetsCollector does not

[GitHub] [lucene] dweiss commented on a change in pull request #759: LUCENE-9651 Update benchmark module docs

2022-03-23 Thread GitBox
dweiss commented on a change in pull request #759: URL: https://github.com/apache/lucene/pull/759#discussion_r832917684 ## File path: gradle/datasets/external-datasets.gradle ## @@ -120,10 +120,9 @@ configure(project(":lucene:benchmark")) { task getReuters(type: Download) {

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-23 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511062#comment-17511062 ] kkewwei edited comment on LUCENE-10448 at 3/23/22, 7:16 AM: As the instant

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-23 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511062#comment-17511062 ] kkewwei edited comment on LUCENE-10448 at 3/23/22, 7:15 AM: As the instant

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-23 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511062#comment-17511062 ] kkewwei edited comment on LUCENE-10448 at 3/23/22, 7:15 AM: As the instant

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-23 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511062#comment-17511062 ] kkewwei edited comment on LUCENE-10448 at 3/23/22, 7:14 AM: As the instant

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-23 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511062#comment-17511062 ] kkewwei edited comment on LUCENE-10448 at 3/23/22, 7:13 AM: As the instant

[jira] [Commented] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-23 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511062#comment-17511062 ] kkewwei commented on LUCENE-10448: -- As the instant rate limit, the point is whether we care about