[jira] [Commented] (LUCENE-10490) Query implement Cloneable interface

[ https://issues.apache.org/jira/browse/LUCENE-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514469#comment-17514469 ] Adrien Grand commented on LUCENE-10490: --- Sorry I wasn't clear on my comment on LU

[GitHub] [lucene] jpountz commented on a change in pull request #767: LUCENE-10436: Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

jpountz commented on a change in pull request #767: URL: https://github.com/apache/lucene/pull/767#discussion_r837740611 ## File path: lucene/core/src/java/org/apache/lucene/search/DocValuesFieldExistsQuery.java ## @@ -31,42 +28,21 @@ /** * A {@link Query} that matches docu

[GitHub] [lucene] dweiss commented on a change in pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

dweiss commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r838137561 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +164,57 @@ public void testInsertWithOverflow() { assertEqu

[GitHub] [lucene] wjp719 commented on pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

wjp719 commented on pull request #731: URL: https://github.com/apache/lucene/pull/731#issuecomment-1082583137 @jpountz Hi, I have refactor the code according to your suggestions, please review it again, thanks. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [lucene] wjp719 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

wjp719 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r838083031 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java ## @@ -163,6 +165,76 @@ public void visit(QueryVisitor visitor) {

[GitHub] [lucene] wjp719 opened a new pull request #774: LUCENE-10490: Query implement Cloneable interface

wjp719 opened a new pull request #774: URL: https://github.com/apache/lucene/pull/774 Query should implement Cloneable interface, so that subClass of Query can clone itself to create a new instance when only minor modifications are needed especially in Query#rewrite method. Please r

[jira] [Updated] (LUCENE-10490) Query implement Cloneable interface

[ https://issues.apache.org/jira/browse/LUCENE-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jianping weng updated LUCENE-10490: --- Description: *Query* should implement *Cloneable* interface, so that subClass of *Query* ca

[jira] [Created] (LUCENE-10490) Query implement Cloneable interface

jianping weng created LUCENE-10490: -- Summary: Query implement Cloneable interface Key: LUCENE-10490 URL: https://issues.apache.org/jira/browse/LUCENE-10490 Project: Lucene - Core Issue Type:

[GitHub] [lucene] jtibshirani commented on pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

jtibshirani commented on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1082549529 If I'm reading the logic right, it uses a different conversion though (like `Float.floatToRawIntBits`) whereas `SortedNumericDocValuesField` expects `NumericUtils.floatToSorta

[GitHub] [lucene] wjp719 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

wjp719 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r838052074 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java ## @@ -314,6 +386,32 @@ public Scorer scorer(LeafReaderContext co

[GitHub] [lucene] wjp719 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

wjp719 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r838052200 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java ## @@ -163,6 +165,60 @@ public void visit(QueryVisitor visitor) {

[GitHub] [lucene] wjp719 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

wjp719 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r838048975 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java ## @@ -163,6 +165,69 @@ public void visit(QueryVisitor visitor) {

[GitHub] [lucene] reta commented on pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

reta commented on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1082506007 > Thanks! I think `NumericDocValuesField` accepts floating point types as well (see the `FloatDocValuesField` subclass for example). It is the single-valued version of `SortedNumeric

[GitHub] [lucene] jtibshirani commented on pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

jtibshirani commented on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1082501188 Thanks! I think `NumericDocValuesField` accepts floating point types as well (see the `FloatDocValuesField` subclass for example). It is the single-valued version of `SortedNu

[GitHub] [lucene] reta commented on pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

reta commented on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1082488464 Thanks @jtibshirani > I think this only fixes the problem if the documents have SortedNumericDocValuesField but not NumericDocValuesField? That is correct, only for `S

[GitHub] [lucene] gsmiller commented on a change in pull request #718: LUCENE-10444: Support alternate aggregation functions in association facets

gsmiller commented on a change in pull request #718: URL: https://github.com/apache/lucene/pull/718#discussion_r837744334 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FloatTaxonomyFacets.java ## @@ -49,22 +57,24 @@ void rollup() throws IOException {

[GitHub] [lucene] mikemccand commented on pull request #767: LUCENE-10436: Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

mikemccand commented on pull request #767: URL: https://github.com/apache/lucene/pull/767#issuecomment-1082139269 > Quick question: shall I also merge existing test cases from `TestNormsFieldExistsQuery`, `TestKnnVectorFieldExistsQuery` and `TestDocValuesFieldExistsQuery` as well ?

[jira] [Commented] (LUCENE-10427) OLAP likewise rollup during segment merge process

[ https://issues.apache.org/jira/browse/LUCENE-10427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514145#comment-17514145 ] Suhan Mao commented on LUCENE-10427: [~jpountz]  Sorry for the late reply and thank

[GitHub] [lucene] mikemccand commented on a change in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch de

mikemccand commented on a change in pull request #762: URL: https://github.com/apache/lucene/pull/762#discussion_r837531773 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java ## @@ -0,0 +1,95 @@ +/* + *

[GitHub] [lucene] mikemccand commented on a change in pull request #718: LUCENE-10444: Support alternate aggregation functions in association facets

mikemccand commented on a change in pull request #718: URL: https://github.com/apache/lucene/pull/718#discussion_r837510411 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FloatTaxonomyFacets.java ## @@ -49,22 +57,24 @@ void rollup() throws IOException {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to add all collection elements to a PriorityQueue

BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r837475991 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +163,43 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to add all collection elements to a PriorityQueue

BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r837475991 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +163,43 @@ public void testInsertWithOverflow() {

[GitHub] [lucene-solr] smoldenhauer-ish opened a new pull request #2651: SOLR-16110 Using Schema/Config API breaks the File-Upload of Config Set File

smoldenhauer-ish opened a new pull request #2651: URL: https://github.com/apache/lucene-solr/pull/2651 fix: touchConfDir keeps current data at config node (SOLR-16110) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [lucene] jpountz commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

jpountz commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r837397382 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java ## @@ -163,6 +165,76 @@ public void visit(QueryVisitor visitor)

[jira] [Resolved] (LUCENE-10475) Reconsider package structure in kuromoji and nori to mininize classes' visibiilty

[ https://issues.apache.org/jira/browse/LUCENE-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-10475. Fix Version/s: 10.0 (main) Resolution: Fixed > Reconsider package structure in kur

[jira] [Commented] (LUCENE-10475) Reconsider package structure in kuromoji and nori to mininize classes' visibiilty

[ https://issues.apache.org/jira/browse/LUCENE-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514045#comment-17514045 ] ASF subversion and git services commented on LUCENE-10475: -- Co

[GitHub] [lucene] mocobeta merged pull request #772: LUCENE-10475: Merge o.a.l.a.[ja|ko].util into o.a.l.a.[ja|ko].dict

mocobeta merged pull request #772: URL: https://github.com/apache/lucene/pull/772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Resolved] (LUCENE-10184) Move "how to contribute" documentation to the git repo

[ https://issues.apache.org/jira/browse/LUCENE-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-10184. Resolution: Fixed > Move "how to contribute" documentation to the git repo >

[GitHub] [lucene] dweiss commented on a change in pull request #770: Implement method to add all collection elements to a PriorityQueue

dweiss commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r837354373 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +163,43 @@ public void testInsertWithOverflow() { assertEqu

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to add all collection elements to a PriorityQueue

BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r837310904 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +163,43 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to add all collection elements to a PriorityQueue

BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r837310904 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +163,43 @@ public void testInsertWithOverflow() {

[jira] [Created] (LUCENE-10489) Can I use Lucene9.0.0 or Lucene9.1.0 on Android project?

Jeremy Liu created LUCENE-10489: --- Summary: Can I use Lucene9.0.0 or Lucene9.1.0 on Android project? Key: LUCENE-10489 URL: https://issues.apache.org/jira/browse/LUCENE-10489 Project: Lucene - Core

[GitHub] [lucene] wjp719 commented on pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

wjp719 commented on pull request #731: URL: https://github.com/apache/lucene/pull/731#issuecomment-1081609232 @gautamworah96 thank you for your patient reviews. I have run the two new added tests 2000 iterations and all passed. @jpountz @iverase please help to review this pr, thanks

[jira] [Commented] (LUCENE-7634) is there a Lucene that can be used on Android devices

[ https://issues.apache.org/jira/browse/LUCENE-7634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513929#comment-17513929 ] Jeremy Liu commented on LUCENE-7634: How about now? Can you use Lucene 9.0.0 on Andr

[jira] [Commented] (LUCENE-10184) Move "how to contribute" documentation to the git repo

[ https://issues.apache.org/jira/browse/LUCENE-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513900#comment-17513900 ] Adrien Grand commented on LUCENE-10184: --- Thanks [~tomoko], these small things go

[GitHub] [lucene] mocobeta commented on pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.

mocobeta commented on pull request #771: URL: https://github.com/apache/lucene/pull/771#issuecomment-1081544897 Merged. Thank you for your feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-10184) Move "how to contribute" documentation to the git repo

[ https://issues.apache.org/jira/browse/LUCENE-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513892#comment-17513892 ] ASF subversion and git services commented on LUCENE-10184: -- Co

[GitHub] [lucene] mocobeta merged pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.

mocobeta merged pull request #771: URL: https://github.com/apache/lucene/pull/771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.