[GitHub] [lucene] mocobeta commented on pull request #808: LUCENE-10513: Run `gradlew tidy` first

mocobeta commented on PR #808: URL: https://github.com/apache/lucene/pull/808#issuecomment-1097561253 I made minor edits to the contribution guide without losing the information added here. https://github.com/apache/lucene/commit/e6fb74f9090db2bc274af94c17d80739697bdc01 I think

[GitHub] [lucene] mocobeta commented on pull request #805: LUCENE-10493: factor out Viterbi algorithm and share it between kuromoji and nori

mocobeta commented on PR #805: URL: https://github.com/apache/lucene/pull/805#issuecomment-1097541490 @rmuir would you mind reviewing this, or do you think we shouldn't proceed this way? I know it's a bit radical refactoring but I cannot come up with a better way to unify the two

[GitHub] [lucene] mocobeta closed pull request #810: (trivial) revice contributing.md?

mocobeta closed pull request #810: (trivial) revice contributing.md? URL: https://github.com/apache/lucene/pull/810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r848944541 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed to the

[jira] [Commented] (LUCENE-10510) Check module access prior to running gjf/spotless/errorprone tasks

[ https://issues.apache.org/jira/browse/LUCENE-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521323#comment-17521323 ] Dawid Weiss commented on LUCENE-10510: -- Hi Alan. The task graph is fine. When you run 'gradlew

[jira] [Commented] (LUCENE-10204) Support iteration of sub-matches in join queries (ToParentBlockJoinQuery / ToChildBlockJoinQuery)

[ https://issues.apache.org/jira/browse/LUCENE-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521295#comment-17521295 ] Marc D'Mello commented on LUCENE-10204: --- So I talked more with [~gsmiller] about this and we

[GitHub] [lucene] iverase commented on a diff in pull request #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

iverase commented on code in PR #809: URL: https://github.com/apache/lucene/pull/809#discussion_r848675478 ## lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java: ## @@ -257,10 +257,13 @@ public WithinRelation withinLine( boolean ab, double bX, double

[GitHub] [lucene] iverase commented on pull request #756: LUCENE-10470: [Tessellator] Prevent bridges that introduce collinear edges

iverase commented on PR #756: URL: https://github.com/apache/lucene/pull/756#issuecomment-1096983965 Ups I was not expecting so many failures. I prefer to wait until we find what is hopefully some pathological issue that can be fixed. -- This is an automated message from the Apache Git

[GitHub] [lucene] nknize commented on a diff in pull request #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

nknize commented on code in PR #809: URL: https://github.com/apache/lucene/pull/809#discussion_r848570743 ## lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java: ## @@ -257,10 +257,13 @@ public WithinRelation withinLine( boolean ab, double bX, double

[GitHub] [lucene] yixunx commented on pull request #756: LUCENE-10470: [Tessellator] Prevent bridges that introduce collinear edges

yixunx commented on PR #756: URL: https://github.com/apache/lucene/pull/756#issuecomment-1096841552 @iverase The latest run of our indexing pipeline revealed some more shapes that fail to tessellate. This time I made changes so that we get all failing shapes instead of just one. There are

[GitHub] [lucene] mocobeta opened a new pull request, #810: (trivial) revice contributing.md?

mocobeta opened a new pull request, #810: URL: https://github.com/apache/lucene/pull/810 This kind of documentation tends to become bloated. I think it might be good if we maintain only files in [lucene/help](https://github.com/apache/lucene/tree/main/help) and make the guide include

[GitHub] [lucene] mikemccand commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch deci

mikemccand commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r848422770 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache

[GitHub] [lucene] uschindler commented on pull request #807: LUCENE-10512: Grammar: Remove incidents of "the the" in comments.

uschindler commented on PR #807: URL: https://github.com/apache/lucene/pull/807#issuecomment-1096665479 Tidy is the best task name for this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (LUCENE-10513) Make it more obvious how to fix Spotless issues for new users

[ https://issues.apache.org/jira/browse/LUCENE-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rich Bowen resolved LUCENE-10513. - Resolution: Fixed Thank you. PR merged. Closing. > Make it more obvious how to fix Spotless

[GitHub] [lucene] rbowen commented on pull request #808: LUCENE-10513: Run `gradlew tidy` first

rbowen commented on PR #808: URL: https://github.com/apache/lucene/pull/808#issuecomment-1096660870 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (LUCENE-10513) Make it more obvious how to fix Spotless issues for new users

[ https://issues.apache.org/jira/browse/LUCENE-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521112#comment-17521112 ] ASF subversion and git services commented on LUCENE-10513: -- Commit

[GitHub] [lucene] mocobeta merged pull request #808: LUCENE-10513: Run `gradlew tidy` first

mocobeta merged PR #808: URL: https://github.com/apache/lucene/pull/808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] mikemccand commented on pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch decide

mikemccand commented on PR #762: URL: https://github.com/apache/lucene/pull/762#issuecomment-1096620694 > Ooof this new commit was quite a journey. The test case sporadically started failing after I added the two use cases (of testing both the DTR and ARDTR). This led me down to debugging

[jira] [Commented] (LUCENE-10510) Check module access prior to running gjf/spotless/errorprone tasks

[ https://issues.apache.org/jira/browse/LUCENE-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521062#comment-17521062 ] Alan Woodward commented on LUCENE-10510: This has been triggering failures in our elasticsearch

[GitHub] [lucene] iverase opened a new pull request, #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

iverase opened a new pull request, #809: URL: https://github.com/apache/lucene/pull/809 WE currently might return disjoint when a query geometry fully contains a triangle / line / point. This causes issues as when an inner node is fully contained in the query shape, we marked those

[jira] [Created] (LUCENE-10514) Some Component2D#within* implementations inconsistent with Component2D#relate

Ignacio Vera created LUCENE-10514: - Summary: Some Component2D#within* implementations inconsistent with Component2D#relate Key: LUCENE-10514 URL: https://issues.apache.org/jira/browse/LUCENE-10514

[jira] [Commented] (LUCENE-10511) IntersectIterators is not necessary under matchAll case in Facet

[ https://issues.apache.org/jira/browse/LUCENE-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521028#comment-17521028 ] Lu Xugang commented on LUCENE-10511: ConjunctionUtils is lack of the ability of prune

[jira] [Updated] (LUCENE-10511) IntersectIterators is not necessary under matchAll case in Facet

[ https://issues.apache.org/jira/browse/LUCENE-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lu Xugang updated LUCENE-10511: --- Description: If number of hits in FacetsCollector equals reader.maxDoc() and DocValues's cost()

[GitHub] [lucene] iverase commented on pull request #756: LUCENE-10470: [Tessellator] Prevent bridges that introduce collinear edges

iverase commented on PR #756: URL: https://github.com/apache/lucene/pull/756#issuecomment-1096194673 @yixunx if there is no further input I am planning to push this change shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Resolved] (LUCENE-10508) GeoArea failure with degenerated latitude

[ https://issues.apache.org/jira/browse/LUCENE-10508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-10508. --- Fix Version/s: 9.2 Assignee: Ignacio Vera Resolution: Fixed > GeoArea

[jira] [Commented] (LUCENE-10508) GeoArea failure with degenerated latitude

[ https://issues.apache.org/jira/browse/LUCENE-10508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520929#comment-17520929 ] ASF subversion and git services commented on LUCENE-10508: -- Commit

[jira] [Commented] (LUCENE-10508) GeoArea failure with degenerated latitude

[ https://issues.apache.org/jira/browse/LUCENE-10508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520926#comment-17520926 ] ASF subversion and git services commented on LUCENE-10508: -- Commit

[GitHub] [lucene] iverase merged pull request #804: LUCENE-10508: Fixes some failures where a GeoArea is built with degenerated latitudes

iverase merged PR #804: URL: https://github.com/apache/lucene/pull/804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: