[GitHub] [lucene] iverase commented on a diff in pull request #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

2022-04-13 Thread GitBox
iverase commented on code in PR #809: URL: https://github.com/apache/lucene/pull/809#discussion_r850084313 ## lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java: ## @@ -257,10 +257,13 @@ public WithinRelation withinLine( boolean ab, double bX, double

[GitHub] [lucene] nknize commented on a diff in pull request #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

2022-04-13 Thread GitBox
nknize commented on code in PR #809: URL: https://github.com/apache/lucene/pull/809#discussion_r850050047 ## lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java: ## @@ -257,10 +257,13 @@ public WithinRelation withinLine( boolean ab, double bX, double b

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

2022-04-13 Thread GitBox
gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r849963313 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache

[GitHub] [lucene] dweiss commented on pull request #523: LUCENE-10293: adds a stand-alone prepareSonatypeBundle that compiles …

2022-04-13 Thread GitBox
dweiss commented on PR #523: URL: https://github.com/apache/lucene/pull/523#issuecomment-1098490488 When you tried uploading the bundle, did you use this patch, @HoustonPutman ? Because it does "flatten" the artifact structure - ``` eachFile { FileCopyDetails details -> det

[GitHub] [lucene] dweiss commented on pull request #523: LUCENE-10293: adds a stand-alone prepareSonatypeBundle that compiles …

2022-04-13 Thread GitBox
dweiss commented on PR #523: URL: https://github.com/apache/lucene/pull/523#issuecomment-1098488535 Sorry. Working from remote/ holidays and only having 5 minutes to look at things. So the sonatype bundle should be working fine, really. I know about the problem with subfolders but I did hav

[GitHub] [lucene] HoustonPutman commented on pull request #523: LUCENE-10293: adds a stand-alone prepareSonatypeBundle that compiles …

2022-04-13 Thread GitBox
HoustonPutman commented on PR #523: URL: https://github.com/apache/lucene/pull/523#issuecomment-1098479631 I'm fairly confused. The `mavenToApacheReleases` task was authored in October of last year, while this PR is from December, so I assumed that there was an effort to solve this beyond u

[GitHub] [lucene] dweiss commented on pull request #523: LUCENE-10293: adds a stand-alone prepareSonatypeBundle that compiles …

2022-04-13 Thread GitBox
dweiss commented on PR #523: URL: https://github.com/apache/lucene/pull/523#issuecomment-1098339324 > I tried using this method but unfortunately when you do the "upload bundle" there's a bug where it will add additional folder levels to the artifacts that you are uploading (if you have mul

[GitHub] [lucene] dweiss commented on a diff in pull request #811: Add some basic tasks to help/workflow

2022-04-13 Thread GitBox
dweiss commented on code in PR #811: URL: https://github.com/apache/lucene/pull/811#discussion_r849753568 ## help/workflow.txt: ## @@ -25,11 +25,22 @@ Assemble a single module's JAR (here for lucene-core): gradlew -p lucene/core assemble ls lucene/core/build/libs +Assemble a

[GitHub] [lucene] dweiss commented on pull request #808: LUCENE-10513: Run `gradlew tidy` first

2022-04-13 Thread GitBox
dweiss commented on PR #808: URL: https://github.com/apache/lucene/pull/808#issuecomment-1098327441 LGTM, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[jira] [Commented] (LUCENE-10510) Check module access prior to running gjf/spotless/errorprone tasks

2022-04-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521850#comment-17521850 ] Dawid Weiss commented on LUCENE-10510: -- I suspected it might have been the nightly

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

2022-04-13 Thread GitBox
gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r849730444 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache

[GitHub] [lucene] HoustonPutman commented on pull request #523: LUCENE-10293: adds a stand-alone prepareSonatypeBundle that compiles …

2022-04-13 Thread GitBox
HoustonPutman commented on PR #523: URL: https://github.com/apache/lucene/pull/523#issuecomment-1098274229 Hey @dweiss I am finishing up the Solr 9.0.0 release and ran into this issue. It looks like both Lucene 9.0 and 9.1 used the ant command from 8.11 to do the maven upload.

[jira] [Commented] (LUCENE-10274) Implement "hyperrectangle" faceting

2022-04-13 Thread Marc D'Mello (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521784#comment-17521784 ] Marc D'Mello commented on LUCENE-10274: --- I am interested in this issue and would

[GitHub] [lucene] mocobeta commented on pull request #811: Add some basic tasks to help/workflow

2022-04-13 Thread GitBox
mocobeta commented on PR #811: URL: https://github.com/apache/lucene/pull/811#issuecomment-1097940536 @dweiss would you mind taking a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene] mikemccand commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch deci

2022-04-13 Thread GitBox
mikemccand commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r849373865 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache So

[GitHub] [lucene] mocobeta opened a new pull request, #811: Add some basic tasks to help/workflow

2022-04-13 Thread GitBox
mocobeta opened a new pull request, #811: URL: https://github.com/apache/lucene/pull/811 They might be worth adding to `help/workflow.txt`, and to me, it'd be great if we make this file a single entry point for every developer. e.g., we can just add a link to it from https://github.com/apa

[jira] [Commented] (LUCENE-10510) Check module access prior to running gjf/spotless/errorprone tasks

2022-04-13 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521543#comment-17521543 ] Alan Woodward commented on LUCENE-10510: Aha, it's the nightly runs that are fa