[jira] [Commented] (LUCENE-10522) issue with pattern capture group token filter

2022-04-18 Thread Dishant Sharma (Jira)

[ 


[jira] [Updated] (LUCENE-10522) issue with pattern capture group token filter

2022-04-18 Thread Dishant Sharma (Jira)

 [ 
https://issues.apache.org/jira/browse/LUCENE-10522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dishant Sharma 

[jira] [Updated] (LUCENE-10522) issue with pattern capture group token filter

2022-04-18 Thread Dishant Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dishant Sharma updated LUCENE-10522: Description: |The default pattern capture token filter in elastic search gives the same

[jira] [Updated] (LUCENE-10522) issue with pattern capture group token filter

2022-04-18 Thread Dishant Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dishant Sharma updated LUCENE-10522: Description: |The default pattern capture token filter in elastic search gives the same

[jira] [Created] (LUCENE-10522) issue with pattern capture group token filter

2022-04-18 Thread Dishant Sharma (Jira)
Dishant Sharma created LUCENE-10522: --- Summary: issue with pattern capture group token filter Key: LUCENE-10522 URL: https://issues.apache.org/jira/browse/LUCENE-10522 Project: Lucene - Core

[jira] [Commented] (LUCENE-10518) FieldInfos consistency check can refuse to open Lucene 8 index

2022-04-18 Thread Nhat Nguyen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523918#comment-17523918 ] Nhat Nguyen commented on LUCENE-10518: -- [~mayya] Thank you for your response. I understand the

[jira] [Commented] (LUCENE-10482) Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch decide

2022-04-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523903#comment-17523903 ] ASF subversion and git services commented on LUCENE-10482: -- Commit

[jira] [Commented] (LUCENE-10482) Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch decide

2022-04-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523902#comment-17523902 ] ASF subversion and git services commented on LUCENE-10482: -- Commit

[jira] [Created] (LUCENE-10521) Tests in windows are failing for the new testAlwaysRefreshDirectoryTaxonomyReader test

2022-04-18 Thread Gautam Worah (Jira)
Gautam Worah created LUCENE-10521: - Summary: Tests in windows are failing for the new testAlwaysRefreshDirectoryTaxonomyReader test Key: LUCENE-10521 URL: https://issues.apache.org/jira/browse/LUCENE-10521

[GitHub] [lucene] Yuti-G commented on pull request #779: LUCENE-10488: Optimize Facets#getTopDims in IntTaxonomyFacets

2022-04-18 Thread GitBox
Yuti-G commented on PR #779: URL: https://github.com/apache/lucene/pull/779#issuecomment-1101733483 Hi @gautamworah96, thank you so much! I have re-run the benchmark with the up-to-date mainline, and please see the results: ``` TaskQPS baseline

[GitHub] [lucene] rmuir commented on a diff in pull request #816: LUCENE-10519: ThreadLocal.remove under G1GC takes 100% CPU

2022-04-18 Thread GitBox
rmuir commented on code in PR #816: URL: https://github.com/apache/lucene/pull/816#discussion_r852294751 ## lucene/core/src/java/org/apache/lucene/util/CloseableThreadLocal.java: ## @@ -123,12 +121,27 @@ public void close() { // Clear the hard refs; then, the only

[GitHub] [lucene] uschindler commented on pull request #815: Backport LUCENE-10482 Bug Fix: Don't use Instant.now() as prefix for the temp dir name

2022-04-18 Thread GitBox
uschindler commented on PR #815: URL: https://github.com/apache/lucene/pull/815#issuecomment-1101589969 We never create PRs for backports if it is just a simple cherry picking action.no need for that as this is mostly 2 command line actions or 2 mouse clicks. I generally do this in one go.

[GitHub] [lucene] gautamworah96 closed pull request #815: Backport LUCENE-10482 Bug Fix: Don't use Instant.now() as prefix for the temp dir name

2022-04-18 Thread GitBox
gautamworah96 closed pull request #815: Backport LUCENE-10482 Bug Fix: Don't use Instant.now() as prefix for the temp dir name URL: https://github.com/apache/lucene/pull/815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [lucene] gautamworah96 commented on pull request #815: Backport LUCENE-10482 Bug Fix: Don't use Instant.now() as prefix for the temp dir name

2022-04-18 Thread GitBox
gautamworah96 commented on PR #815: URL: https://github.com/apache/lucene/pull/815#issuecomment-1101580017 Closing this PR since the change was manually pushed by @mikemccand in https://github.com/apache/lucene/commit/766c08e475ba31e2f5b7e1cf491cdacbe276ab67 (`branch_9x`) -- This is an

[GitHub] [lucene] uschindler commented on pull request #817: improve spotless error to suggest running 'gradlew tidy'

2022-04-18 Thread GitBox
uschindler commented on PR #817: URL: https://github.com/apache/lucene/pull/817#issuecomment-1101504853 Hihi. Cool fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [lucene] mikemccand commented on pull request #817: improve spotless error to suggest running 'gradlew tidy'

2022-04-18 Thread GitBox
mikemccand commented on PR #817: URL: https://github.com/apache/lucene/pull/817#issuecomment-1101500256 +1 this is awesome @rmuir -- the exception message ought to be crystal clear how to resolve the problems, so that new users (who closely read the suggestions in exception messages) know

[GitHub] [lucene] rmuir commented on pull request #807: LUCENE-10512: Grammar: Remove incidents of "the the" in comments.

2022-04-18 Thread GitBox
rmuir commented on PR #807: URL: https://github.com/apache/lucene/pull/807#issuecomment-1101498697 > bq. Since the Spotless check seems to be fail-fast, maybe we should fix the exception message to just suggest ./gradlew tidy instead? I have a hacky patch:

[GitHub] [lucene] rmuir opened a new pull request, #817: improve spotless error to suggest running 'gradlew tidy'

2022-04-18 Thread GitBox
rmuir opened a new pull request, #817: URL: https://github.com/apache/lucene/pull/817 The current error isn't helpful as it suggests a per-module command. If the user has modified multiple modules, they will be running gradle commands to try to fix each one of them, when it would be

[GitHub] [lucene] mikemccand commented on pull request #807: LUCENE-10512: Grammar: Remove incidents of "the the" in comments.

2022-04-18 Thread GitBox
mikemccand commented on PR #807: URL: https://github.com/apache/lucene/pull/807#issuecomment-1101434176 > bq. Since the Spotless check seems to be fail-fast, maybe we should fix the exception message to just suggest ./gradlew tidy instead? > > Gradle runs tasks in parallel so it's

[jira] [Commented] (LUCENE-10315) Speed up BKD leaf block ids codec by a 512 ints ForUtil

2022-04-18 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523700#comment-17523700 ] Feng Guo commented on LUCENE-10315: --- Thanks [~ivera]! +1 to remove the int24 forutil implementation.

[GitHub] [lucene] mikemccand commented on pull request #808: LUCENE-10513: Run `gradlew tidy` first

2022-04-18 Thread GitBox
mikemccand commented on PR #808: URL: https://github.com/apache/lucene/pull/808#issuecomment-1101418928 > I think I'm too accustomed to the development workflow on this project, so I'm not able to figure out what is the minimum information that should be shown there to introduce new

[GitHub] [lucene] mikemccand commented on pull request #808: LUCENE-10513: Run `gradlew tidy` first

2022-04-18 Thread GitBox
mikemccand commented on PR #808: URL: https://github.com/apache/lucene/pull/808#issuecomment-1101417096 > I followed the commits and I think it shouldn't be the main concern here to edit `CONTRIBUTIONG.md`? I'm not going to be against or hold this. Maybe I'll open another follow-up PR for

[jira] [Updated] (LUCENE-10519) ThreadLocal.remove under G1GC takes 100% CPU

2022-04-18 Thread Boicehuang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boicehuang updated LUCENE-10519: Description: h2. Problem {*}org.apache.lucene.util.CloseableThreadLocal{*}(which is using

[jira] [Commented] (LUCENE-10482) Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch decide

2022-04-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523660#comment-17523660 ] ASF subversion and git services commented on LUCENE-10482: -- Commit

[GitHub] [lucene] mikemccand commented on pull request #815: Backport LUCENE-10482 Bug Fix: Don't use Instant.now() as prefix for the temp dir name

2022-04-18 Thread GitBox
mikemccand commented on PR #815: URL: https://github.com/apache/lucene/pull/815#issuecomment-1101322811 I'll backport this to 9.x now -- sorry I should have done it last night too! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (LUCENE-10520) HTMLCharStripFilter fails on '>' or '<' characters in attribute values

2022-04-18 Thread Alex Alishevskikh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Alishevskikh updated LUCENE-10520: --- Affects Version/s: 9.1 > HTMLCharStripFilter fails on '>' or '<' characters in

[jira] [Updated] (LUCENE-10520) HTMLCharStripFilter fails on '>' or '<' characters in attribute values

2022-04-18 Thread Alex Alishevskikh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Alishevskikh updated LUCENE-10520: --- Fix Version/s: 9.1 > HTMLCharStripFilter fails on '>' or '<' characters in

[jira] [Created] (LUCENE-10520) HTMLCharStripFilter fails on '>' or '<' characters in attribute values

2022-04-18 Thread Alex Alishevskikh (Jira)
Alex Alishevskikh created LUCENE-10520: -- Summary: HTMLCharStripFilter fails on '>' or '<' characters in attribute values Key: LUCENE-10520 URL: https://issues.apache.org/jira/browse/LUCENE-10520

[jira] [Updated] (LUCENE-10519) ThreadLocal.remove under G1GC takes 100% CPU

2022-04-18 Thread Boicehuang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boicehuang updated LUCENE-10519: Description: h2. Problem {*}org.apache.lucene.util.CloseableThreadLocal{*}(which is using

[jira] [Updated] (LUCENE-10519) ThreadLocal.remove under G1GC takes 100% CPU

2022-04-18 Thread Boicehuang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boicehuang updated LUCENE-10519: Description: h2. Problem {*}org.apache.lucene.util.CloseableThreadLocal{*}(which is using

[jira] [Updated] (LUCENE-10519) ThreadLocal.remove under G1GC takes 100% CPU

2022-04-18 Thread Boicehuang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boicehuang updated LUCENE-10519: Description: h2. Problem {*}org.apache.lucene.util.CloseableThreadLocal{*}(which is using

[jira] [Updated] (LUCENE-10519) ThreadLocal.remove under G1GC takes 100% CPU

2022-04-18 Thread Boicehuang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boicehuang updated LUCENE-10519: Description: h2. Problem {*}org.apache.lucene.util.CloseableThreadLocal{*}(which is using

[jira] [Updated] (LUCENE-10519) ThreadLocal.remove under G1GC takes 100% CPU

2022-04-18 Thread Boicehuang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boicehuang updated LUCENE-10519: Description: h2. Problem I found {*}org.apache.lucene.util.CloseableThreadLocal{*}(which is

[jira] [Updated] (LUCENE-10519) ThreadLocal.remove under G1GC takes 100% CPU

2022-04-18 Thread Boicehuang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boicehuang updated LUCENE-10519: Description: h2. Problem I found {*}org.apache.lucene.util.CloseableThreadLocal{*}(which is

[GitHub] [lucene] boicehuang opened a new pull request, #816: LUCENE-10519: ThreadLocal.remove under G1GC takes 100% CPU

2022-04-18 Thread GitBox
boicehuang opened a new pull request, #816: URL: https://github.com/apache/lucene/pull/816 See also: https://issues.apache.org/jira/browse/LUCENE-10519 Solution --- We don't need to store entry twice in the hardRefs And ThreadLocals. Remove ThreadLocal from CloseableThreadLocal

[jira] [Updated] (LUCENE-10519) ThreadLocal.remove under G1GC takes 100% CPU

2022-04-18 Thread Boicehuang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boicehuang updated LUCENE-10519: Description: h2. Problem I found {*}org.apache.lucene.util.CloseableThreadLocal{*}(which is

[jira] [Updated] (LUCENE-10519) ThreadLocal.remove under G1GC takes 100% CPU

2022-04-18 Thread Boicehuang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boicehuang updated LUCENE-10519: Description: h2. Problem I found {*}org.apache.lucene.util.CloseableThreadLocal{*}(which is

[jira] [Updated] (LUCENE-10519) ThreadLocal.remove under G1GC takes 100% CPU

2022-04-18 Thread Boicehuang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boicehuang updated LUCENE-10519: Description: h2. Problem I found {*}org.apache.lucene.util.CloseableThreadLocal{*}(which is

[jira] [Updated] (LUCENE-10519) ThreadLocal.remove under G1GC takes 100% CPU

2022-04-18 Thread Boicehuang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boicehuang updated LUCENE-10519: Description: h2. Problem I found {*}org.apache.lucene.util.CloseableThreadLocal{*}(which is

[jira] [Updated] (LUCENE-10519) ThreadLocal.remove under G1GC takes 100% CPU

2022-04-18 Thread Boicehuang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boicehuang updated LUCENE-10519: Description: h2. Problem I found {*}org.apache.lucene.util.CloseableThreadLocal{*}(which is

[jira] [Updated] (LUCENE-10519) ThreadLocal.remove under G1GC takes 100% CPU

2022-04-18 Thread Boicehuang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boicehuang updated LUCENE-10519: Description: h2. Problem   There is a single ThreadLocalMap stored for each thread, which

[jira] [Created] (LUCENE-10519) ThreadLocal.remove under G1GC takes 100% CPU

2022-04-18 Thread Boicehuang (Jira)
Boicehuang created LUCENE-10519: --- Summary: ThreadLocal.remove under G1GC takes 100% CPU Key: LUCENE-10519 URL: https://issues.apache.org/jira/browse/LUCENE-10519 Project: Lucene - Core Issue

[GitHub] [lucene] wjp719 commented on pull request #786: LUCENE-10499: reduce unnecessary copy data overhead when growing array size

2022-04-18 Thread GitBox
wjp719 commented on PR #786: URL: https://github.com/apache/lucene/pull/786#issuecomment-1101194508 > Thanks, the change looks correct to me. I'm not a fan of the new method's name, but I don't have a better suggestion. I'll merge this change in a few days unless someone objects.

[GitHub] [lucene] uschindler commented on a diff in pull request #815: Backport LUCENE-10482 Bug Fix: Don't use Instant.now() as prefix for the temp dir name

2022-04-18 Thread GitBox
uschindler commented on code in PR #815: URL: https://github.com/apache/lucene/pull/815#discussion_r851923047 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -53,15 +52,15 @@ public class