jpountz commented on code in PR #833:
URL: https://github.com/apache/lucene/pull/833#discussion_r857318802
##
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java:
##
@@ -323,6 +325,35 @@ public int nextDoc() throws IOException {
: sortedSetDocVal
jpountz merged PR #827:
URL: https://github.com/apache/lucene/pull/827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
[
https://issues.apache.org/jira/browse/LUCENE-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527349#comment-17527349
]
ASF subversion and git services commented on LUCENE-8836:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527350#comment-17527350
]
ASF subversion and git services commented on LUCENE-8836:
-
Commi
boicehuang commented on PR #816:
URL: https://github.com/apache/lucene/pull/816#issuecomment-1108216412
> `./gradlew check` still fails.
I have successfully run `gradle :lucene:core:spotlessApply` and `gradle
:lucene:check` locally. Please run the CI again, thanks.
BTW, sorry fo
[
https://issues.apache.org/jira/browse/LUCENE-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-8836.
--
Fix Version/s: 9.2
Resolution: Fixed
I merged a change that only improves lookupOrd, an
[
https://issues.apache.org/jira/browse/LUCENE-10529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527419#comment-17527419
]
Tomoko Uchida commented on LUCENE-10529:
I saw the same test fails but with a d
mocobeta commented on PR #805:
URL: https://github.com/apache/lucene/pull/805#issuecomment-1108428861
I'm merging this and will observe the nightly benchmark (this shouldn't
affect the analysis performance).
--
This is an automated message from the Apache Git Service.
To respond to the me
mocobeta merged PR #805:
URL: https://github.com/apache/lucene/pull/805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache
[
https://issues.apache.org/jira/browse/LUCENE-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527428#comment-17527428
]
ASF subversion and git services commented on LUCENE-10493:
--
Co
dweiss commented on PR #834:
URL: https://github.com/apache/lucene/pull/834#issuecomment-1108438352
I removed the hack and updated spotless. Works fine for me. I just noticed
that any gradle error now returns the 'something went wrong' message though.
![image](https://user-images.gi
uschindler commented on code in PR #834:
URL: https://github.com/apache/lucene/pull/834#discussion_r857519990
##
gradle/validation/spotless.gradle:
##
@@ -110,10 +110,8 @@ configure(project(":lucene").subprojects) { prj ->
check.dependsOn v
v.dependsOn ":checkJdkIntern
iverase commented on PR #756:
URL: https://github.com/apache/lucene/pull/756#issuecomment-1108472913
Hi @yixunx,
I had a look to the polygon and it seems to be a totally different type of
error and I would prefer to handle it as a separate issue. In the meanwhile I
propose to push th
dweiss commented on code in PR #834:
URL: https://github.com/apache/lucene/pull/834#discussion_r857552731
##
gradle/validation/spotless.gradle:
##
@@ -110,10 +110,8 @@ configure(project(":lucene").subprojects) { prj ->
check.dependsOn v
v.dependsOn ":checkJdkInternalsE
dweiss commented on PR #832:
URL: https://github.com/apache/lucene/pull/832#issuecomment-1108486770
I'm fine with this. Reasons for Slow (and other test groups) are various. I
use Slow in projects where certain tests are indeed slow by nature - have to
unpack the distribution/ fork processe
rmuir commented on PR #834:
URL: https://github.com/apache/lucene/pull/834#issuecomment-1108487568
> I just noticed that any gradle error now returns the 'something went
wrong' message though.
This only happens on windows. Something is off with the `%ERRORLEVEL%` stuff
in the .bat fi
dweiss commented on PR #834:
URL: https://github.com/apache/lucene/pull/834#issuecomment-1108489133
Will take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
rmuir commented on PR #834:
URL: https://github.com/apache/lucene/pull/834#issuecomment-1108490605
I took a look, it seems to me at a lance:
* any error from WrapperDownloader will go to `:fail` section via an
explicit GOTO: `IF %ERRORLEVEL% NEQ 0 goto fail`
* any error from gradlew it
dweiss commented on PR #834:
URL: https://github.com/apache/lucene/pull/834#issuecomment-1108492891
Yeah, I have a fix already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
dweiss commented on PR #834:
URL: https://github.com/apache/lucene/pull/834#issuecomment-1108498260
This fixes the script logic for windows:
https://github.com/apache/lucene/pull/835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
[
https://issues.apache.org/jira/browse/LUCENE-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527451#comment-17527451
]
Petr Portnov commented on LUCENE-10386:
---
Hi there!
I've opened a PR with the imp
dweiss merged PR #835:
URL: https://github.com/apache/lucene/pull/835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.o
dweiss commented on PR #835:
URL: https://github.com/apache/lucene/pull/835#issuecomment-1108513010
I think I made a logic mistake when I looked at what Robert pushed to the sh
one, my fault.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
uschindler commented on code in PR #834:
URL: https://github.com/apache/lucene/pull/834#discussion_r857577924
##
gradle/validation/spotless.gradle:
##
@@ -110,10 +110,8 @@ configure(project(":lucene").subprojects) { prj ->
check.dependsOn v
v.dependsOn ":checkJdkIntern
[
https://issues.apache.org/jira/browse/LUCENE-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527459#comment-17527459
]
Dawid Weiss commented on LUCENE-10386:
--
Hi Petr. I saw the PR but I'm not followin
dweiss commented on code in PR #834:
URL: https://github.com/apache/lucene/pull/834#discussion_r857581902
##
gradle/validation/spotless.gradle:
##
@@ -110,10 +110,8 @@ configure(project(":lucene").subprojects) { prj ->
check.dependsOn v
v.dependsOn ":checkJdkInternalsE
dweiss commented on code in PR #834:
URL: https://github.com/apache/lucene/pull/834#discussion_r857583962
##
gradle/validation/spotless.gradle:
##
@@ -110,10 +110,8 @@ configure(project(":lucene").subprojects) { prj ->
check.dependsOn v
v.dependsOn ":checkJdkInternalsE
dweiss merged PR #834:
URL: https://github.com/apache/lucene/pull/834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.o
dweiss commented on PR #834:
URL: https://github.com/apache/lucene/pull/834#issuecomment-1108529546
Thanks @uschindler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
rmuir commented on PR #816:
URL: https://github.com/apache/lucene/pull/816#issuecomment-1108554479
Thanks for getting the tests passing.
I'm honestly torn on this issue, here are my thoughts:
1. If you have 100% cpu in `java.lang.ThreadLocal.remove()`, you are
creating and destroyi
rmuir commented on PR #834:
URL: https://github.com/apache/lucene/pull/834#issuecomment-1108562973
Thank you for patching spotless and integrating the fix @dweiss !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
yixunx commented on PR #756:
URL: https://github.com/apache/lucene/pull/756#issuecomment-1108799875
Sounds good, thank you for looking into this @iverase. I think it makes
sense to merge this PR as you suggested, and I'll open separate tickets for the
latest failing shape and for my questio
Kevin Risden created LUCENE-10533:
-
Summary: SpellChecker.formGrams is missing bounds check
Key: LUCENE-10533
URL: https://issues.apache.org/jira/browse/LUCENE-10533
Project: Lucene - Core
Is
[
https://issues.apache.org/jira/browse/LUCENE-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527666#comment-17527666
]
Bruno Roustant commented on LUCENE-8836:
Thanks [~jpountz] for this simplified i
risdenk opened a new pull request, #836:
URL: https://github.com/apache/lucene/pull/836
# Description
SpellChecker.formGrams is missing a bounds check that results in
NegativeArraySizeException in some cases.
# Solution
This adds a bounds check to SpellChecker.formGrams
[
https://issues.apache.org/jira/browse/LUCENE-10533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10533:
--
Status: Patch Available (was: Open)
> SpellChecker.formGrams is missing bounds check
> -
rmuir commented on PR #836:
URL: https://github.com/apache/lucene/pull/836#issuecomment-1108899794
Should we really return no-results if a user asks to spellcheck the empty
string? Or maybe just a better, more obvious exception?
--
This is an automated message from the Apache Git Service.
risdenk commented on PR #836:
URL: https://github.com/apache/lucene/pull/836#issuecomment-1108904174
Yea thats a 100% valid question and one I'm not sure what the right answer
is. I tried to find a definition of what is expected here. I'm not tied to this
solution, its just the least intrus
rmuir commented on PR #836:
URL: https://github.com/apache/lucene/pull/836#issuecomment-1108916100
OK i looked into some surrounding behavior in suggest module:
Looks like returning empty list is what DirectSpellChecker does:
https://github.com/apache/lucene/blob/main/lucene/su
Kevin Risden created LUCENE-10534:
-
Summary: MinFloatFunction / MaxFloatFunction exists check is slow
Key: LUCENE-10534
URL: https://issues.apache.org/jira/browse/LUCENE-10534
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10534:
--
Summary: MinFloatFunction / MaxFloatFunction exists check can be slow
(was: MinFloatFunction
risdenk opened a new pull request, #837:
URL: https://github.com/apache/lucene/pull/837
# Description
`MinFloatFunction` and `MaxFloatFunction` currently check if values exist
which can happen twice in the worst case.
# Solution
This rearranges the logic to only check if
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10534:
--
Status: Patch Available (was: Open)
> MinFloatFunction / MaxFloatFunction exists check can b
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527735#comment-17527735
]
Kevin Risden commented on LUCENE-10534:
---
FWIW I am not 100% sure how to performan
risdenk merged PR #836:
URL: https://github.com/apache/lucene/pull/836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
[
https://issues.apache.org/jira/browse/LUCENE-10533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527738#comment-17527738
]
ASF subversion and git services commented on LUCENE-10533:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10533:
--
Fix Version/s: 9.1
Resolution: Fixed
Status: Resolved (was: Patch Available
[
https://issues.apache.org/jira/browse/LUCENE-10533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527740#comment-17527740
]
ASF subversion and git services commented on LUCENE-10533:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10533:
--
Fix Version/s: 9.2
(was: 9.1)
> SpellChecker.formGrams is missing boun
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527773#comment-17527773
]
Chris M. Hostetter commented on LUCENE-10534:
-
{quote}This is only needed w
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527778#comment-17527778
]
Chris M. Hostetter commented on LUCENE-10534:
-
Maybe a diff approach to spe
jaisonbi commented on PR #816:
URL: https://github.com/apache/lucene/pull/816#issuecomment-1109236031
This issue has no relationship with "creating and destroying too many
threads", but it's caused by **too many "ThreadLocal" objects created from same
threads**.
Based on the implemen
rmuir commented on PR #816:
URL: https://github.com/apache/lucene/pull/816#issuecomment-1109349516
See this is my problem, applications using threadpools of absurd sizes
(unbounded, 1, etc), and then blaming lucene for their GC woes. at this
point the DSM-IV is needed, because developer
Dawid Weiss created LUCENE-10535:
Summary: The build fails in :checkUnusedConstraints
(ConcurrentModificationException)
Key: LUCENE-10535
URL: https://issues.apache.org/jira/browse/LUCENE-10535
Projec
[
https://issues.apache.org/jira/browse/LUCENE-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss reassigned LUCENE-10535:
Assignee: Dawid Weiss
> The build fails in :checkUnusedConstraints (ConcurrentModificati
[
https://issues.apache.org/jira/browse/LUCENE-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527923#comment-17527923
]
ASF subversion and git services commented on LUCENE-10535:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527924#comment-17527924
]
Dawid Weiss commented on LUCENE-10535:
--
Upgraded the plugin to 2.10.0 - the build
[
https://issues.apache.org/jira/browse/LUCENE-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-10535.
--
Fix Version/s: 10.0 (main)
Resolution: Fixed
> The build fails in :checkUnusedConstrai
58 matches
Mail list logo
