navneet1v commented on code in PR #1017:
URL: https://github.com/apache/lucene/pull/1017#discussion_r919668826
##
lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java:
##
@@ -0,0 +1,844 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
zacharymorn commented on PR #1018:
URL: https://github.com/apache/lucene/pull/1018#issuecomment-1182774748
Benchmark results with `wikinightly.tasks` boolean queries below:
```
TaskQPS baseline StdDevQPS
my_modified_version StdDev
[
https://issues.apache.org/jira/browse/LUCENE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566149#comment-17566149
]
Zach Chen edited comment on LUCENE-10480 at 7/13/22 5:09 AM:
-
{quote}I
[
https://issues.apache.org/jira/browse/LUCENE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566149#comment-17566149
]
Zach Chen commented on LUCENE-10480:
{quote}I wouldn't say blocker, but maybe we could give us time
zacharymorn opened a new pull request, #1018:
URL: https://github.com/apache/lucene/pull/1018
### Description (or a Jira issue link if you have one)
Use BulkScorer to limit BMMScorer to only top-level disjunctions
Note: Tests update pending
--
This is an automated message
msokolov commented on PR #947:
URL: https://github.com/apache/lucene/pull/947#issuecomment-1182694202
OK, this last round of commits moves the new vector encoding parameter out
of IndexableField and FieldInfo into Codec constructor and internally to the
codec, in FieldEntry. It certainly
mocobeta closed issue #38: StackOverflowException on certain issue descriptions
and comment text
URL: https://github.com/apache/lucene-jira-archive/issues/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mocobeta merged PR #39:
URL: https://github.com/apache/lucene-jira-archive/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gsmiller merged PR #1010:
URL: https://github.com/apache/lucene/pull/1010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Knize updated LUCENE-10654:
Fix Version/s: 9.3
> New companion doc value format for LatLonShape and XYShape field types
>
[
https://issues.apache.org/jira/browse/LUCENE-10649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566071#comment-17566071
]
Vigya Sharma commented on LUCENE-10649:
---
Great, thanks for confirming Adrien. I'll open a PR with
nknize opened a new pull request, #1017:
URL: https://github.com/apache/lucene/pull/1017
Adds new doc value field to support LatLonShape and XYShape doc values. The
implementation is inspired by ComponentTree. A binary tree of tessellated
components (point, line, or triangle) is
Yuti-G commented on code in PR #1013:
URL: https://github.com/apache/lucene/pull/1013#discussion_r919502708
##
lucene/facet/src/test/org/apache/lucene/facet/FacetTestCase.java:
##
@@ -264,4 +264,24 @@ protected void assertFloatValuesEquals(FacetResult a,
FacetResult b) {
[
https://issues.apache.org/jira/browse/LUCENE-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Knize updated LUCENE-10654:
Description:
{{XYDocValuesField}} provides doc value support for {{XYPoint}}.
Nick Knize created LUCENE-10654:
---
Summary: New companion doc value format for LatLonShape and
XYShape field types
Key: LUCENE-10654
URL: https://issues.apache.org/jira/browse/LUCENE-10654
Project:
[
https://issues.apache.org/jira/browse/LUCENE-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566026#comment-17566026
]
Mayya Sharipova commented on LUCENE-10471:
--
[~sstolpovskiy] [~sokolov] Thanks for providing
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566015#comment-17566015
]
Michael Sokolov commented on LUCENE-10577:
--
OK, that makes sense to me – I'll see about moving
jpountz commented on code in PR #987:
URL: https://github.com/apache/lucene/pull/987#discussion_r918752313
##
lucene/core/src/java/org/apache/lucene/codecs/compressing/CompressionMode.java:
##
@@ -257,9 +270,13 @@ private static class DeflateCompressor extends Compressor {
mikemccand commented on PR #33:
URL:
https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1181660019
Sorry -- not pushed to the PR yet -- struggling w/ git ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/LUCENE-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565873#comment-17565873
]
ASF subversion and git services commented on LUCENE-10619:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10619.
---
Fix Version/s: 9.3
Resolution: Fixed
> Optimize the writeBytes in TermsHashPerField
mocobeta commented on PR #39:
URL:
https://github.com/apache/lucene-jira-archive/pull/39#issuecomment-1181804695
Thank you @mikemccand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mikemccand commented on PR #33:
URL:
https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1181662032
OK don't merge this -- I somehow messed up and slurped in unrelated (already
previously committed/pushed) changes. I have to drop off for now but will try
to fix this a bit
mocobeta commented on issue #38:
URL:
https://github.com/apache/lucene-jira-archive/issues/38#issuecomment-1181803770
I'll merge it once I confirmed it parses all Jira without any errors. (I
think nobody can review the quick and dirty fix...)
--
This is an automated message from the
tang-hi commented on PR #966:
URL: https://github.com/apache/lucene/pull/966#issuecomment-1181886902
@jpountz thanks for the suggestion . I have changed testWriteBytes to
write small chunks each time
--
This is an automated message from the Apache Git Service.
To respond to the
mikemccand commented on code in PR #39:
URL: https://github.com/apache/lucene-jira-archive/pull/39#discussion_r919015037
##
migration/src/markup/lists.py:
##
@@ -40,6 +40,11 @@ def action(self, tokens: ParseResults) -> str:
for line in tokens:
#
mikemccand commented on PR #33:
URL:
https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1181657754
I pushed a small change to make a best-effort when we hit exceptions from
the converter. Such comments look like this:
[
https://issues.apache.org/jira/browse/LUCENE-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565872#comment-17565872
]
ASF subversion and git services commented on LUCENE-10619:
--
Commit
mikemccand opened a new issue, #38:
URL: https://github.com/apache/lucene-jira-archive/issues/38
Spinoff from #33.
Some issues' text hit a stack overflow exception, e.g. one of the comments
on LUCENE-550:
```
(.venv) beast3:migration[polish_legacy_jira]$ python
mikemccand commented on issue #38:
URL:
https://github.com/apache/lucene-jira-archive/issues/38#issuecomment-1181596940
Note that it is pretty rare -- when I ran the full conversion, I saw four
separate occurrences. Might not be so important to track down? We can just
carry over the raw
jpountz merged PR #966:
URL: https://github.com/apache/lucene/pull/966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565871#comment-17565871
]
Julie Tibshirani commented on LUCENE-10577:
---
I checked out the latest PR changes, and I like
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565919#comment-17565919
]
Julie Tibshirani edited comment on LUCENE-10577 at 7/12/22 4:23 PM:
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565919#comment-17565919
]
Julie Tibshirani commented on LUCENE-10577:
---
I wasn't suggesting making it entirely an
[
https://issues.apache.org/jira/browse/LUCENE-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565944#comment-17565944
]
Marc D'Mello commented on LUCENE-10628:
---
Thanks for taking a look! As for the answer to your
[
https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565384#comment-17565384
]
Adrien Grand commented on LUCENE-10650:
---
{{query.boost}} is the {{query.getBoost()}} from
jpountz commented on PR #987:
URL: https://github.com/apache/lucene/pull/987#issuecomment-1181718918
> if we only using compress method with variants ByteBuffersDataInput in
LUCENE90, we can not using abstract method Compressor.compress, when we want to
use other compression mode.
I
mikemccand opened a new issue, #37:
URL: https://github.com/apache/lucene-jira-archive/issues/37
Spinoff from #33.
This is not a blocker for migration, more because I'm curious how Jira lost
issues and how pervasive this problem might be -- maybe other Apache projects
are affected?
mikemccand commented on PR #33:
URL:
https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1181586767
And thank you for the quick fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mikemccand commented on PR #33:
URL:
https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1181589626
> It looks like a bug introduced in
[cfbc821](https://github.com/apache/lucene-jira-archive/commit/cfbc821390859a7053e43028325b6bc616ec2b5b).
(I have postponed testing it
mocobeta commented on issue #36:
URL:
https://github.com/apache/lucene-jira-archive/issues/36#issuecomment-1181522090
https://docs.python.org/3/howto/logging-cookbook.html#logging-to-a-single-file-from-multiple-processes
--
This is an automated message from the Apache Git Service.
To
mikemccand commented on PR #33:
URL:
https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1181586644
> Sorry there should have been a "catch all" try~except clause. I made a
quick fix in #35.
No worries at all! No need to apologize!
--
This is an automated message
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565914#comment-17565914
]
Michael Sokolov commented on LUCENE-10577:
--
It would be nice if we could make this encoding an
mikemccand commented on PR #33:
URL:
https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1181587514
> I'm also converting the whole Jira issue myself; it looks like it takes
several hours... (recent changes to fix conversion errors could affect the
conversion speed I
mikemccand merged PR #40:
URL: https://github.com/apache/lucene-jira-archive/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jpountz commented on PR #907:
URL: https://github.com/apache/lucene/pull/907#issuecomment-1181518177
@shahrs87 Can you look into removing all other instances of `terms ==
Terms.EMPTY` or `terms != Terms.EMPTY` as well? To do this while keeping tests
passing, I think you'll need to create
mikemccand commented on issue #38:
URL:
https://github.com/apache/lucene-jira-archive/issues/38#issuecomment-1181644356
> I'm trying to find other ways that do not cause infinite recursion while
parsing lists correctly.
Awesome, thanks @mocobeta!
--
This is an automated message
mayya-sharipova commented on code in PR #992:
URL: https://github.com/apache/lucene/pull/992#discussion_r919332844
##
lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldKnnVectorsFormat.java:
##
@@ -102,9 +104,22 @@ private class FieldsWriter extends
mayya-sharipova commented on PR #992:
URL: https://github.com/apache/lucene/pull/992#issuecomment-1182388563
@jtibshirani @jpountz Thank for your review. I've tried to address your
comments, but it looks like we are still not clear how to organize `merge` and
`flush` methods. Would be
[
https://issues.apache.org/jira/browse/LUCENE-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565380#comment-17565380
]
Adrien Grand commented on LUCENE-10653:
---
+1 to doing a bulk heapify
The fact that this scorer
mayya-sharipova commented on code in PR #992:
URL: https://github.com/apache/lucene/pull/992#discussion_r919349095
##
lucene/core/src/java/org/apache/lucene/index/VectorValuesWriter.java:
##
@@ -26,233 +26,153 @@
import org.apache.lucene.codecs.KnnVectorsWriter;
import
mocobeta commented on issue #38:
URL:
https://github.com/apache/lucene-jira-archive/issues/38#issuecomment-1181776008
I opened #39. I cannot really explain _why the ad-hoc fix works_ but it
works. I think there should be a better way though, it would be sufficient for
the one-time batch.
mayya-sharipova commented on code in PR #992:
URL: https://github.com/apache/lucene/pull/992#discussion_r919343914
##
lucene/core/src/java/org/apache/lucene/codecs/lucene93/Lucene93HnswVectorsWriter.java:
##
@@ -266,65 +470,128 @@ private void writeMeta(
}
}
-
mayya-sharipova commented on code in PR #992:
URL: https://github.com/apache/lucene/pull/992#discussion_r919288022
##
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java:
##
@@ -24,28 +24,40 @@
import org.apache.lucene.index.DocIDMerger;
import
luyuncheng commented on code in PR #987:
URL: https://github.com/apache/lucene/pull/987#discussion_r918848057
##
lucene/core/src/java/org/apache/lucene/codecs/compressing/CompressionMode.java:
##
@@ -257,9 +270,13 @@ private static class DeflateCompressor extends Compressor {
[
https://issues.apache.org/jira/browse/LUCENE-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565468#comment-17565468
]
Michael Sokolov commented on LUCENE-10471:
--
We should not be imposing an arbitrary limit that
luyuncheng commented on PR #987:
URL: https://github.com/apache/lucene/pull/987#issuecomment-1181632413
> Would it be possible to remove all `CompressionMode#compress` variants
that take a `byte[]` now that you introduced a new method that takes a
`ByteBuffersDataInput`?
>
> Also
mayya-sharipova commented on code in PR #992:
URL: https://github.com/apache/lucene/pull/992#discussion_r919332844
##
lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldKnnVectorsFormat.java:
##
@@ -102,9 +104,22 @@ private class FieldsWriter extends
[
https://issues.apache.org/jira/browse/LUCENE-10649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565885#comment-17565885
]
Adrien Grand commented on LUCENE-10649:
---
Good catch [~vigyas], it looks related indeed. The bug
mocobeta opened a new pull request, #39:
URL: https://github.com/apache/lucene-jira-archive/pull/39
Close #38
This ad-hoc patch fixes `'maximum recursion depth exceeded'` error, and also
makes the script a bit faster. (8h -> 5h)
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/LUCENE-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565882#comment-17565882
]
Ignacio Vera commented on LUCENE-10628:
---
I have mainly worked with two type of trees in Lucene.
mocobeta commented on PR #33:
URL:
https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1181624324
> Thanks -- I was beginning to wonder if it was normal how long it was
taking ;)
Of course it's not normal; I remember it took two or three hours to convert
the whole
mayya-sharipova commented on code in PR #992:
URL: https://github.com/apache/lucene/pull/992#discussion_r919288022
##
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java:
##
@@ -24,28 +24,40 @@
import org.apache.lucene.index.DocIDMerger;
import
[
https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565402#comment-17565402
]
Adrien Grand commented on LUCENE-10603:
---
+1
> Improve iteration of ords for SortedSetDocValues
>
mayya-sharipova commented on code in PR #992:
URL: https://github.com/apache/lucene/pull/992#discussion_r919288022
##
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java:
##
@@ -24,28 +24,40 @@
import org.apache.lucene.index.DocIDMerger;
import
mikemccand closed pull request #33: Polish wording of Legacy Jira details
header, and each comment footer
URL: https://github.com/apache/lucene-jira-archive/pull/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mikemccand opened a new pull request, #40:
URL: https://github.com/apache/lucene-jira-archive/pull/40
I "rebooted" my PR by downloading the diff off the messed up #33 PR, futzing
it locally, applying, resolving conflicts. Messy messy. I'll try to more
carefully manage the git merging
mikemccand commented on PR #33:
URL:
https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1181821682
I'm closing this messed up PR -- I rebooted it into #40.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jpountz commented on code in PR #1003:
URL: https://github.com/apache/lucene/pull/1003#discussion_r918758391
##
lucene/core/src/java/org/apache/lucene/codecs/compressing/Decompressor.java:
##
@@ -42,6 +44,13 @@ protected Decompressor() {}
public abstract void decompress(
jpountz commented on code in PR #966:
URL: https://github.com/apache/lucene/pull/966#discussion_r918804129
##
lucene/core/src/java/org/apache/lucene/index/TermsHashPerField.java:
##
@@ -230,9 +230,29 @@ final void writeByte(int stream, byte b) {
}
final void
mocobeta commented on issue #38:
URL:
https://github.com/apache/lucene-jira-archive/issues/38#issuecomment-1181605666
Thank you for opening this.
While the stack overflow is rare, this recursion in parsing also causes a
significant slowdown in conversion.
I'm sure the root cause
[
https://issues.apache.org/jira/browse/LUCENE-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-10600:
--
Fix Version/s: 9.3
> SortedSetDocValues#docValueCount should be an int, not long
>
[
https://issues.apache.org/jira/browse/LUCENE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565375#comment-17565375
]
Adrien Grand commented on LUCENE-10480:
---
+1 to explore this in a separate issue.
bq. Do you
mocobeta commented on issue #36:
URL:
https://github.com/apache/lucene-jira-archive/issues/36#issuecomment-1181497062
I found https://pypi.org/project/multiprocessing-logging/, but this works
only on Linux.
--
This is an automated message from the Apache Git Service.
To respond to
mocobeta commented on PR #33:
URL:
https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1181456586
I'm also converting the whole Jira issue myself; it looks like it takes
several hours... (recent changes to fix conversion errors could affect the
conversion speed I think).
mocobeta opened a new issue, #36:
URL: https://github.com/apache/lucene-jira-archive/issues/36
`jira2markdown_imprt.py` is single-threaded and it takes several hours to
convert all Jira issues.
I think it'd be easy to parallelize this with
stefanvodita commented on code in PR #1015:
URL: https://github.com/apache/lucene/pull/1015#discussion_r918597529
##
lucene/facet/src/java/org/apache/lucene/facet/facetset/MatchingFacetSetsCounts.java:
##
@@ -52,8 +52,10 @@ public MatchingFacetSetsCounts(
String field,
77 matches
Mail list logo
