[GitHub] [lucene] luyuncheng commented on a diff in pull request #987: LUCENE-10627: Using ByteBuffersDataInput reduce memory copy on compressing data

2022-07-19 Thread GitBox
luyuncheng commented on code in PR #987: URL: https://github.com/apache/lucene/pull/987#discussion_r925199445 ## lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java: ## @@ -165,6 +165,36 @@ public void readBytes(byte[] arr, int off, int len) throws EOFExcepti

[GitHub] [lucene] luyuncheng commented on a diff in pull request #987: LUCENE-10627: Using ByteBuffersDataInput reduce memory copy on compressing data

2022-07-19 Thread GitBox
luyuncheng commented on code in PR #987: URL: https://github.com/apache/lucene/pull/987#discussion_r925199223 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/DeflateWithPresetDictCompressionMode.java: ## @@ -163,20 +165,22 @@ private static class DeflateWithPresetDictC

[GitHub] [lucene] luyuncheng commented on a diff in pull request #987: LUCENE-10627: Using ByteBuffersDataInput reduce memory copy on compressing data

2022-07-19 Thread GitBox
luyuncheng commented on code in PR #987: URL: https://github.com/apache/lucene/pull/987#discussion_r925199019 ## lucene/core/src/test/org/apache/lucene/codecs/lucene90/compressing/TestCompressingStoredFieldsFormat.java: ## @@ -325,4 +341,160 @@ public void testChunkCleanup() thr

[GitHub] [lucene] vigyasharma commented on pull request #963: LUCENE-10583: Add docstring warning to not lock on Lucene objects

2022-07-19 Thread GitBox
vigyasharma commented on PR #963: URL: https://github.com/apache/lucene/pull/963#issuecomment-1189846909 This is only a docstring change to warn users against locking on Lucene objects in commonly used classes. Do we think it makes sense to add this note? -- This is an automated message f

[jira] [Resolved] (LUCENE-10656) It is unnecessary that using `limit` to check boundary

2022-07-19 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lu Xugang resolved LUCENE-10656. Fix Version/s: 9.3 Resolution: Done > It is unnecessary that using `limit` to check bounda

[GitHub] [lucene] Yuti-G commented on pull request #1013: LUCENE-10644: Facets#getAllChildren testing should ignore child order

2022-07-19 Thread GitBox
Yuti-G commented on PR #1013: URL: https://github.com/apache/lucene/pull/1013#issuecomment-1189821285 Yes, thanks @gsmiller for reviewing this new test approach! I will apply it to all the getAllChildren tests that I previously wrote. -- This is an automated message from the Apac

[jira] [Resolved] (LUCENE-10480) Specialize 2-clauses disjunctions

2022-07-19 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach Chen resolved LUCENE-10480. Assignee: Zach Chen Resolution: Done > Specialize 2-clauses disjunctions >

[GitHub] [lucene] luyuncheng commented on a diff in pull request #987: LUCENE-10627: Using ByteBuffersDataInput reduce memory copy on compressing data

2022-07-19 Thread GitBox
luyuncheng commented on code in PR #987: URL: https://github.com/apache/lucene/pull/987#discussion_r925139050 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/DeflateWithPresetDictCompressionMode.java: ## @@ -198,22 +200,25 @@ private void doCompress(byte[] bytes, int o

[GitHub] [lucene] luyuncheng commented on a diff in pull request #987: LUCENE-10627: Using ByteBuffersDataInput reduce memory copy on compressing data

2022-07-19 Thread GitBox
luyuncheng commented on code in PR #987: URL: https://github.com/apache/lucene/pull/987#discussion_r925139050 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/DeflateWithPresetDictCompressionMode.java: ## @@ -198,22 +200,25 @@ private void doCompress(byte[] bytes, int o

[jira] [Commented] (LUCENE-10480) Specialize 2-clauses disjunctions

2022-07-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568798#comment-17568798 ] ASF subversion and git services commented on LUCENE-10480: -- Co

[GitHub] [lucene] zacharymorn merged pull request #1037: LUCENE-10480: (Backporting) Use BulkScorer to limit BMMScorer to only top-level disjunctions

2022-07-19 Thread GitBox
zacharymorn merged PR #1037: URL: https://github.com/apache/lucene/pull/1037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

[GitHub] [lucene] zacharymorn opened a new pull request, #1037: LUCENE-10480: (Backporting) Use BulkScorer to limit BMMScorer to only top-level disjunctions

2022-07-19 Thread GitBox
zacharymorn opened a new pull request, #1037: URL: https://github.com/apache/lucene/pull/1037 ### Description (or a Jira issue link if you have one) This PR backports https://github.com/apache/lucene/pull/1018 to `branch_9x` -- This is an automated message from the Apache Git Servic

[jira] [Commented] (LUCENE-10656) It is unnecessary that using `limit` to check boundary

2022-07-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568782#comment-17568782 ] ASF subversion and git services commented on LUCENE-10656: -- Co

[GitHub] [lucene] LuXugang merged pull request #1027: LUCENE-10656: It is unnecessary that using `limit` to check boundary

2022-07-19 Thread GitBox
LuXugang merged PR #1027: URL: https://github.com/apache/lucene/pull/1027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[jira] [Commented] (LUCENE-10480) Specialize 2-clauses disjunctions

2022-07-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568781#comment-17568781 ] ASF subversion and git services commented on LUCENE-10480: -- Co

[GitHub] [lucene] zacharymorn merged pull request #1018: LUCENE-10480: Use BulkScorer to limit BMMScorer to only top-level disjunctions

2022-07-19 Thread GitBox
zacharymorn merged PR #1018: URL: https://github.com/apache/lucene/pull/1018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

[GitHub] [lucene] zacharymorn commented on pull request #1018: LUCENE-10480: Use BulkScorer to limit BMMScorer to only top-level disjunctions

2022-07-19 Thread GitBox
zacharymorn commented on PR #1018: URL: https://github.com/apache/lucene/pull/1018#issuecomment-1189719768 > Let's merge this PR to have it in 9.3 and resolve [LUCENE-10480](https://issues.apache.org/jira/browse/LUCENE-10480)? Sure sounds good! -- This is an automated message from

[jira] [Created] (LUCENE-10658) Merges should periodically check for abort

2022-07-19 Thread Nhat Nguyen (Jira)
Nhat Nguyen created LUCENE-10658: Summary: Merges should periodically check for abort Key: LUCENE-10658 URL: https://issues.apache.org/jira/browse/LUCENE-10658 Project: Lucene - Core Issue Ty

[GitHub] [lucene-jira-archive] mocobeta commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
mocobeta commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1189716915 @mikemccand thank you, now I can change the project configuration (again). -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [lucene] gsmiller commented on a diff in pull request #1015: [LUCENE-10629]: Add fast match query support to FacetSets

2022-07-19 Thread GitBox
gsmiller commented on code in PR #1015: URL: https://github.com/apache/lucene/pull/1015#discussion_r925041032 ## lucene/facet/src/java/org/apache/lucene/facet/FacetCountsWithFilterQuery.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Resolved] (LUCENE-10653) Should BlockMaxMaxscoreScorer rebuild its heap in bulk?

2022-07-19 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10653. -- Fix Version/s: 9.3 Assignee: Greg Miller Resolution: Fixed > Should BlockMaxM

[jira] [Updated] (LUCENE-10603) Improve iteration of ords for SortedSetDocValues

2022-07-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-10603: -- Fix Version/s: 9.3 > Improve iteration of ords for SortedSetDocValues > -

[jira] [Resolved] (LUCENE-7713) Optimize TopFieldDocCollector for the sorted case

2022-07-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-7713. -- Resolution: Fixed > Optimize TopFieldDocCollector for the sorted case > --

[jira] [Commented] (LUCENE-7713) Optimize TopFieldDocCollector for the sorted case

2022-07-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568758#comment-17568758 ] Adrien Grand commented on LUCENE-7713: -- Looking at the current code it looks like t

[GitHub] [lucene] gsmiller commented on pull request #1013: LUCENE-10644: Facets#getAllChildren testing should ignore child order

2022-07-19 Thread GitBox
gsmiller commented on PR #1013: URL: https://github.com/apache/lucene/pull/1013#issuecomment-1189595295 Thanks @Yuti-G! This approach looks good to me. Is your plan to iterate on this PR to stop enforcing the ordering checks in all the tests? -- This is an automated message from the Apach

[GitHub] [lucene] gsmiller commented on a diff in pull request #1013: LUCENE-10644: Facets#getAllChildren testing should ignore child order

2022-07-19 Thread GitBox
gsmiller commented on code in PR #1013: URL: https://github.com/apache/lucene/pull/1013#discussion_r924992010 ## lucene/facet/src/test/org/apache/lucene/facet/FacetTestCase.java: ## @@ -254,14 +254,38 @@ protected void assertFloatValuesEquals(FacetResult a, FacetResult b) {

[jira] [Commented] (LUCENE-10151) Add timeout support to IndexSearcher

2022-07-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568757#comment-17568757 ] Adrien Grand commented on LUCENE-10151: --- I backported #996 too. > Add timeout su

[jira] [Commented] (LUCENE-10216) Add concurrency to addIndexes(CodecReader…) API

2022-07-19 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568756#comment-17568756 ] Michael McCandless commented on LUCENE-10216: - I think we can backport to 9

[jira] [Updated] (LUCENE-10216) Add concurrency to addIndexes(CodecReader…) API

2022-07-19 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-10216: Fix Version/s: main > Add concurrency to addIndexes(CodecReader…) API > -

[jira] [Resolved] (LUCENE-10524) Augment CONTRIBUTING.md guide with instructions on how/when to benchmark

2022-07-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10524. --- Fix Version/s: 10.0 (main) Resolution: Fixed > Augment CONTRIBUTING.md guide with in

[GitHub] [lucene] uschindler commented on a diff in pull request #987: LUCENE-10627: Using ByteBuffersDataInput reduce memory copy on compressing data

2022-07-19 Thread GitBox
uschindler commented on code in PR #987: URL: https://github.com/apache/lucene/pull/987#discussion_r924980826 ## lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java: ## @@ -165,6 +165,36 @@ public void readBytes(byte[] arr, int off, int len) throws EOFExcepti

[GitHub] [lucene] uschindler commented on a diff in pull request #987: LUCENE-10627: Using ByteBuffersDataInput reduce memory copy on compressing data

2022-07-19 Thread GitBox
uschindler commented on code in PR #987: URL: https://github.com/apache/lucene/pull/987#discussion_r924980603 ## lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java: ## @@ -165,6 +165,36 @@ public void readBytes(byte[] arr, int off, int len) throws EOFExcepti

[jira] [Resolved] (LUCENE-10605) fix error in 32bit jvm object alignment gap calculation

2022-07-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10605. --- Fix Version/s: 9.3 Resolution: Fixed > fix error in 32bit jvm object alignment gap c

[jira] [Resolved] (LUCENE-10598) SortedSetDocValues#docValueCount() should be always greater than zero

2022-07-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10598. --- Fix Version/s: 9.3 Resolution: Fixed > SortedSetDocValues#docValueCount() should be

[jira] [Resolved] (LUCENE-10648) Fix TestAssertingPointsFormat.testWithExceptions failure

2022-07-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10648. --- Fix Version/s: 10.0 (main) Resolution: Fixed > Fix TestAssertingPointsFormat.testWit

[jira] [Commented] (LUCENE-10216) Add concurrency to addIndexes(CodecReader…) API

2022-07-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568745#comment-17568745 ] Adrien Grand commented on LUCENE-10216: --- Can this issue be resolved? > Add concu

[jira] [Resolved] (LUCENE-10507) Should it be more likely to search concurrently in tests?

2022-07-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10507. --- Fix Version/s: 9.3 Resolution: Fixed > Should it be more likely to search concurrent

[GitHub] [lucene] jpountz commented on pull request #1018: LUCENE-10480: Use BulkScorer to limit BMMScorer to only top-level disjunctions

2022-07-19 Thread GitBox
jpountz commented on PR #1018: URL: https://github.com/apache/lucene/pull/1018#issuecomment-1189574164 Let's merge this PR to have it in 9.3 and resolve LUCENE-10480? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (LUCENE-10653) Should BlockMaxMaxscoreScorer rebuild its heap in bulk?

2022-07-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568742#comment-17568742 ] ASF subversion and git services commented on LUCENE-10653: -- Co

[GitHub] [lucene] jpountz commented on a diff in pull request #987: LUCENE-10627: Using ByteBuffersDataInput reduce memory copy on compressing data

2022-07-19 Thread GitBox
jpountz commented on code in PR #987: URL: https://github.com/apache/lucene/pull/987#discussion_r924959065 ## lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java: ## @@ -165,6 +165,36 @@ public void readBytes(byte[] arr, int off, int len) throws EOFException

[jira] [Commented] (LUCENE-10653) Should BlockMaxMaxscoreScorer rebuild its heap in bulk?

2022-07-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568729#comment-17568729 ] ASF subversion and git services commented on LUCENE-10653: -- Co

[GitHub] [lucene] gsmiller merged pull request #1022: LUCENE-10653: Heapify in BMMScorer

2022-07-19 Thread GitBox
gsmiller merged PR #1022: URL: https://github.com/apache/lucene/pull/1022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] gsmiller commented on pull request #1010: Specialize ordinal encoding for SortedSetDocValues

2022-07-19 Thread GitBox
gsmiller commented on PR #1010: URL: https://github.com/apache/lucene/pull/1010#issuecomment-1189505982 Thanks Adrien! On Tue, Jul 19, 2022 at 12:54 AM Adrien Grand ***@***.***> wrote: > I pushed an annotation, it should be live on the next nightly run. > > — > Reply

[GitHub] [lucene] gsmiller merged pull request #1007: Small tweak to PointRangeQuery#visit logic

2022-07-19 Thread GitBox
gsmiller merged PR #1007: URL: https://github.com/apache/lucene/pull/1007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-19 Thread GitBox
mayya-sharipova commented on code in PR #992: URL: https://github.com/apache/lucene/pull/992#discussion_r924809132 ## lucene/core/src/java/org/apache/lucene/codecs/lucene93/Lucene93HnswVectorsWriter.java: ## @@ -116,7 +120,236 @@ public final class Lucene93HnswVectorsWriter exte

[GitHub] [lucene] nknize commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-19 Thread GitBox
nknize commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r924723448 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [lucene] iverase commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-19 Thread GitBox
iverase commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r924696635 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [lucene] nknize commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-19 Thread GitBox
nknize commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r924694451 ## lucene/core/src/java/org/apache/lucene/document/XYShapeDocValuesBoundingBoxQuery.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [lucene] nknize commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-19 Thread GitBox
nknize commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r924691857 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [lucene] jpountz commented on a diff in pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-19 Thread GitBox
jpountz commented on code in PR #992: URL: https://github.com/apache/lucene/pull/992#discussion_r924655816 ## lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene91/Lucene91HnswVectorsWriter.java: ## @@ -149,6 +146,7 @@ public void writeField(FieldInfo fieldI

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-19 Thread GitBox
mayya-sharipova commented on code in PR #992: URL: https://github.com/apache/lucene/pull/992#discussion_r924635739 ## lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene91/Lucene91HnswVectorsWriter.java: ## @@ -149,6 +146,7 @@ public void writeField(FieldInf

[GitHub] [lucene-jira-archive] mikemccand commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
mikemccand commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1189180010 OK done! Try again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene-jira-archive] mikemccand commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
mikemccand commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1189179872 > @mikemccand I'm really sorry but would you please give me admin access for Lucene Jira again? I would need to silence notifications to issues@ list as suggested in dev@

[GitHub] [lucene] iverase commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-19 Thread GitBox
iverase commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r924605969 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [lucene] gsmiller commented on pull request #1007: Small tweak to PointRangeQuery#visit logic

2022-07-19 Thread GitBox
gsmiller commented on PR #1007: URL: https://github.com/apache/lucene/pull/1007#issuecomment-1189167062 > I wonder that there should be more cases like this in other query implementation, maybe now that we are on it would be nice to find all cases and change them? Thanks for the sugg

[GitHub] [lucene] iverase commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-19 Thread GitBox
iverase commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r924606922 ## lucene/core/src/java/org/apache/lucene/document/XYShapeDocValuesBoundingBoxQuery.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [lucene] iverase commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-19 Thread GitBox
iverase commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r924605969 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [lucene-jira-archive] mocobeta commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
mocobeta commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1189144779 @mikemccand I'm really sorry but would you please give me admin access for Lucene Jira again? I would need to silence notifications to issues@ list, before starting the fin

[GitHub] [lucene] nknize commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-19 Thread GitBox
nknize commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r924571676 ## lucene/core/src/java/org/apache/lucene/document/LatLonShape.java: ## @@ -148,6 +234,18 @@ public static Query newBoxQuery( return new LatLonShapeBoundingBoxQuery(f

[GitHub] [lucene] nknize commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-19 Thread GitBox
nknize commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r924571326 ## lucene/core/src/java/org/apache/lucene/document/BaseShapeDocValuesBoundingBoxQuery.java: ## @@ -0,0 +1,188 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[jira] [Commented] (LUCENE-10633) Dynamic pruning for queries sorted by SORTED(_SET) field

2022-07-19 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568587#comment-17568587 ] Greg Miller commented on LUCENE-10633: -- {quote}It also relates to [~gsmiller] 's w

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #947: LUCENE-10577: enable quantization of HNSW vectors to 8 bits

2022-07-19 Thread GitBox
mayya-sharipova commented on code in PR #947: URL: https://github.com/apache/lucene/pull/947#discussion_r924545508 ## lucene/core/src/java/org/apache/lucene/util/VectorUtil.java: ## @@ -213,4 +213,38 @@ public static void add(float[] u, float[] v) { u[i] += v[i]; }

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #947: LUCENE-10577: enable quantization of HNSW vectors to 8 bits

2022-07-19 Thread GitBox
mayya-sharipova commented on code in PR #947: URL: https://github.com/apache/lucene/pull/947#discussion_r923800118 ## lucene/core/src/java/org/apache/lucene/util/VectorUtil.java: ## @@ -213,4 +213,38 @@ public static void add(float[] u, float[] v) { u[i] += v[i]; }

[GitHub] [lucene] mayya-sharipova commented on pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-19 Thread GitBox
mayya-sharipova commented on PR #992: URL: https://github.com/apache/lucene/pull/992#issuecomment-1189089780 @jpountz Thanks a lot for feedback and refactoring. I will study the refactoring and address your feedback. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene] jpountz commented on pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-19 Thread GitBox
jpountz commented on PR #992: URL: https://github.com/apache/lucene/pull/992#issuecomment-1189087636 @mayya-sharipova I hope you don't mind, I pushed a refactoring for the `maxDoc` issue. Feel free to revert it if you don't like it. -- This is an automated message from the Apache Git Serv

[GitHub] [lucene] jpountz commented on a diff in pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-19 Thread GitBox
jpountz commented on code in PR #992: URL: https://github.com/apache/lucene/pull/992#discussion_r924516199 ## lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene91/Lucene91HnswVectorsWriter.java: ## @@ -149,6 +146,7 @@ public void writeField(FieldInfo fieldI

[GitHub] [lucene] gsmiller commented on a diff in pull request #1022: LUCENE-10653: Heapify in BMMScorer

2022-07-19 Thread GitBox
gsmiller commented on code in PR #1022: URL: https://github.com/apache/lucene/pull/1022#discussion_r924510336 ## lucene/core/src/test/org/apache/lucene/search/TestDisiPriorityQueue.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[jira] [Updated] (LUCENE-10627) Using ByteBuffersDataInput reduce memory copy on compressing data

2022-07-19 Thread LuYunCheng (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LuYunCheng updated LUCENE-10627: Summary: Using ByteBuffersDataInput reduce memory copy on compressing data (was: Using Composite

[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #56: Check issue key when downloading

2022-07-19 Thread GitBox
mocobeta commented on code in PR #56: URL: https://github.com/apache/lucene-jira-archive/pull/56#discussion_r924414496 ## migration/src/download_jira.py: ## @@ -41,9 +41,16 @@ def download_issue(num: int, dump_dir: Path) -> bool: if res.status_code != 200: logger.w

[GitHub] [lucene-jira-archive] mikemccand commented on a diff in pull request #56: Check issue key when downloading

2022-07-19 Thread GitBox
mikemccand commented on code in PR #56: URL: https://github.com/apache/lucene-jira-archive/pull/56#discussion_r924412764 ## migration/src/download_jira.py: ## @@ -41,9 +41,16 @@ def download_issue(num: int, dump_dir: Path) -> bool: if res.status_code != 200: logger

[GitHub] [lucene-jira-archive] mocobeta merged pull request #56: Check issue key when downloading

2022-07-19 Thread GitBox
mocobeta merged PR #56: URL: https://github.com/apache/lucene-jira-archive/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lu

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #56: Check issue key when downloading

2022-07-19 Thread GitBox
mocobeta opened a new pull request, #56: URL: https://github.com/apache/lucene-jira-archive/pull/56 Suggested in #37. If the top-level "key" value does not match the request key, the issue has moved to another issue and should be excluded from migration. ``` (.venv) migratio

[jira] [Commented] (LUCENE-10577) Quantize vector values

2022-07-19 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568490#comment-17568490 ] Mayya Sharipova commented on LUCENE-10577: -- I think it would be valuable to im

[GitHub] [lucene] jpountz commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-19 Thread GitBox
jpountz commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r924326487 ## lucene/core/src/java/org/apache/lucene/document/BaseShapeDocValuesBoundingBoxQuery.java: ## @@ -0,0 +1,188 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [lucene] jpountz commented on pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-19 Thread GitBox
jpountz commented on PR #1017: URL: https://github.com/apache/lucene/pull/1017#issuecomment-1188939297 I'm not familiar enough with the geo logic to comment on it but I left some comments on the Field and Query integration. I support Ignacio's suggestion of not trying to fold it into

[GitHub] [lucene-jira-archive] mocobeta merged pull request #55: Refine label texts

2022-07-19 Thread GitBox
mocobeta merged PR #55: URL: https://github.com/apache/lucene-jira-archive/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lu

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #55: Refine label texts

2022-07-19 Thread GitBox
mocobeta commented on PR #55: URL: https://github.com/apache/lucene-jira-archive/pull/55#issuecomment-1188935720 Verified the attached labels in a migrated issue. ![Screenshot from 2022-07-19 20-26-05](https://user-images.githubusercontent.com/1825333/179739334-05ba16ac-d429-4847-bb6

[GitHub] [lucene-jira-archive] uschindler commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
uschindler commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1188905444 > > Delete is sometimes needed when spammers start to create issues. We had that several times. > > In GitHub, only repository administrators' (infra team) can dele

[GitHub] [lucene-jira-archive] mocobeta commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
mocobeta commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1188903182 > Delete is sometimes needed when spammers start to create issues. We had that several times. In GitHub, only repository administrators' (infra team) can delete issue

[GitHub] [lucene-jira-archive] uschindler commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
uschindler commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1188902177 Delete is sometimes needed when spammers start to create issues. We had that several times. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [lucene-jira-archive] mocobeta commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
mocobeta commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1188901497 I think in GitHub issues we don't have much access control as Jira. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [lucene-jira-archive] mocobeta commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
mocobeta commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1188900076 Thanks, now I'm not able to "Delete" issues, so it's limited to project Admins. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [lucene-jira-archive] mikemccand commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
mikemccand commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1188893684 > @mikemccand So can you please revoke my project admin role? OK, done. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [lucene-jira-archive] mocobeta commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
mocobeta commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-114524 @mikemccand So can you please revoke my project admin role? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [lucene] jpountz commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-19 Thread GitBox
jpountz commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r924326270 ## lucene/core/src/java/org/apache/lucene/document/BaseShapeDocValuesBoundingBoxQuery.java: ## @@ -0,0 +1,188 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [lucene-jira-archive] mikemccand commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
mikemccand commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1188873974 > I found I can delete Lucene issues. With great power comes great responsibility! This permission is limited to PMC members and site/project Administrators.

[GitHub] [lucene-jira-archive] mocobeta commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
mocobeta commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1188869805 I found I can delete Lucene issues. ![Screenshot from 2022-07-19 19-14-34](https://user-images.githubusercontent.com/1825333/179727266-95092c8b-d547-451f-933f-73f9298

[GitHub] [lucene-jira-archive] uschindler commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
uschindler commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1188849317 > ah okay thanks, we can check the top-level "key" field. Important: Check if the returned top-level "key" field differs from the requested key (in REST URL). Do no

[GitHub] [lucene-jira-archive] mocobeta commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
mocobeta commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1188846290 Other than the "Moved" issues, are there ones we shouldn't migrate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [lucene-jira-archive] mocobeta commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
mocobeta commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1188844942 ah okay thanks, we can check the top-level "key" field. LUCENE-4344's dump data: ``` { "expand": "renderedFields,names,schema,operations,editmeta,changelog

[GitHub] [lucene-jira-archive] uschindler commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
uschindler commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1188842474 > I don't see any link for deleting an issue in the latest Lucene Jira, but it is surely possible depending on the configuration (I see "Delete" link in another Jira proj

[GitHub] [lucene-jira-archive] mikemccand commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
mikemccand commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1188840453 > So to detect "moved" issues, just compare returned key with requested key. I remembered that I had the same challenge with [jirasearch](https://jirasearch.mikemcc

[GitHub] [lucene-jira-archive] uschindler commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
uschindler commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1188834761 > This reminds me that we should exclude the moved issues (to Solr or possibly another project) from migration, but can't figure out ways to detect "moved" issues... Jira

[GitHub] [lucene-jira-archive] mocobeta commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
mocobeta commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1188806497 This reminds me that we should exclude the moved issues (to Solr or possibly another project) from migration, but can't figure out ways to detect "moved" issues... Jira API

[GitHub] [lucene-jira-archive] mocobeta commented on issue #37: Why are some Jira issues completely missing?

2022-07-19 Thread GitBox
mocobeta commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1188757962 I found that one issue (LUCENE-4344) had been moved to Solr; it seems the original URL has not been deleted but has been redirected (or forwarded?) to the moved URL in that

[GitHub] [lucene] iverase commented on pull request #1007: Small tweak to PointRangeQuery#visit logic

2022-07-19 Thread GitBox
iverase commented on PR #1007: URL: https://github.com/apache/lucene/pull/1007#issuecomment-1188742961 +1 The method `DocIdSetBuilder.BulkAdder#add(DocIdSetIterator)` is a recent addition to speed up cases where those iterators might be backed by a bitset. In this case, the iterator

[GitHub] [lucene] jpountz commented on pull request #1010: Specialize ordinal encoding for SortedSetDocValues

2022-07-19 Thread GitBox
jpountz commented on PR #1010: URL: https://github.com/apache/lucene/pull/1010#issuecomment-1188722250 I pushed an annotation, it should be live on the next nightly run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Resolved] (LUCENE-10657) CopyBytes now saves one memory copy on ByteBuffersDataOutput

2022-07-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10657. --- Fix Version/s: 9.3 Resolution: Fixed > CopyBytes now saves one memory copy on ByteBu

[GitHub] [lucene] jpountz commented on pull request #1018: LUCENE-10480: Use BulkScorer to limit BMMScorer to only top-level disjunctions

2022-07-19 Thread GitBox
jpountz commented on PR #1018: URL: https://github.com/apache/lucene/pull/1018#issuecomment-1188720176 Sure, thanks for doing all this work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [lucene] jpountz commented on pull request #1010: Specialize ordinal encoding for SortedSetDocValues

2022-07-19 Thread GitBox
jpountz commented on PR #1010: URL: https://github.com/apache/lucene/pull/1010#issuecomment-1188711628 This yielded a big speedup on nightly benchmarks http://people.apache.org/~mikemccand/lucenebench/BrowseDateSSDVFacets.html -- This is an automated message from the Apache Git Service. T

  1   2   >