[jira] [Commented] (LUCENE-10659) Fix random TestDisiPriorityQueue bug

2022-07-22 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570209#comment-17570209 ] Greg Miller commented on LUCENE-10659: -- Another fix here:

[jira] [Commented] (LUCENE-10404) Use hash set for visited nodes in HNSW search?

2022-07-22 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570195#comment-17570195 ] Michael Sokolov commented on LUCENE-10404: -- The default `topK` in KnnGraphTester is 100, so

[GitHub] [lucene] nknize commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-22 Thread GitBox
nknize commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r928013152 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Reopened] (LUCENE-10659) Fix random TestDisiPriorityQueue bug

2022-07-22 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller reopened LUCENE-10659: -- Assignee: Greg Miller There's still an issue with the test. Tripped it again last night.

[jira] [Closed] (LUCENE-10592) Should we build HNSW graph on the fly during indexing

2022-07-22 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova closed LUCENE-10592. > Should we build HNSW graph on the fly during indexing >

[jira] [Resolved] (LUCENE-10592) Should we build HNSW graph on the fly during indexing

2022-07-22 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova resolved LUCENE-10592. -- Fix Version/s: 9.4 Resolution: Fixed > Should we build HNSW graph on the fly

[jira] [Commented] (LUCENE-10592) Should we build HNSW graph on the fly during indexing

2022-07-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570112#comment-17570112 ] ASF subversion and git services commented on LUCENE-10592: -- Commit

[jira] [Commented] (LUCENE-10404) Use hash set for visited nodes in HNSW search?

2022-07-22 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570111#comment-17570111 ] Julie Tibshirani commented on LUCENE-10404: --- Those numbers look good! Is my understanding

[jira] [Commented] (LUCENE-10592) Should we build HNSW graph on the fly during indexing

2022-07-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570098#comment-17570098 ] ASF subversion and git services commented on LUCENE-10592: -- Commit

[GitHub] [lucene] mayya-sharipova merged pull request #1043: LUCENE-10592 Build HNSW Graph on indexing

2022-07-22 Thread GitBox
mayya-sharipova merged PR #1043: URL: https://github.com/apache/lucene/pull/1043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] mayya-sharipova opened a new pull request, #1043: LUCENE-10592 Build HNSW Graph on indexing

2022-07-22 Thread GitBox
mayya-sharipova opened a new pull request, #1043: URL: https://github.com/apache/lucene/pull/1043 Currently, when indexing knn vectors, we buffer them in memory and on flush during a segment construction we build an HNSW graph. As building an HNSW graph is very expensive, this makes

[jira] [Commented] (LUCENE-10592) Should we build HNSW graph on the fly during indexing

2022-07-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570081#comment-17570081 ] ASF subversion and git services commented on LUCENE-10592: -- Commit

[GitHub] [lucene] mayya-sharipova merged pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-22 Thread GitBox
mayya-sharipova merged PR #992: URL: https://github.com/apache/lucene/pull/992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] mayya-sharipova merged pull request #1041: Create Lucene94 Codec and move Lucene92 to backwards_codecs

2022-07-22 Thread GitBox
mayya-sharipova merged PR #1041: URL: https://github.com/apache/lucene/pull/1041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene-jira-archive] mikemccand commented on issue #61: Should we carry over Jira "labels"?

2022-07-22 Thread GitBox
mikemccand commented on issue #61: URL: https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1192483422 I'm trying to find a way in our Jira instance to see all labels Lucene's issues use, to get a global sense of label usage. But the closest I can come to is the

[GitHub] [lucene-jira-archive] mikemccand commented on issue #59: Module label is sometimes missing?

2022-07-22 Thread GitBox
mikemccand commented on issue #59: URL: https://github.com/apache/lucene-jira-archive/issues/59#issuecomment-1192483254 > I'm trying to find a way in our Jira instance to see all labels Lucene's issues use, to get a global sense of label usage. But the closest I can come to is the

[GitHub] [lucene] iverase commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-22 Thread GitBox
iverase commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r927333254 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene-jira-archive] mocobeta commented on issue #59: Module label is sometimes missing?

2022-07-22 Thread GitBox
mocobeta commented on issue #59: URL: https://github.com/apache/lucene-jira-archive/issues/59#issuecomment-1192434735 > Could we maybe make this map picky/brittle (throw an exception during conversion if we come across a component/module that isn't in this map)? Yes, I think it'd be

[GitHub] [lucene-jira-archive] mikemccand commented on issue #59: Module label is sometimes missing?

2022-07-22 Thread GitBox
mikemccand commented on issue #59: URL: https://github.com/apache/lucene-jira-archive/issues/59#issuecomment-1192419660 I'm trying to find a way in our Jira instance to see all labels Lucene's issues use, to get a global sense of label usage. But the closest I can come to is the

[GitHub] [lucene-jira-archive] mikemccand closed issue #58: Errors setting assignee when running `import_github_issues.py`

2022-07-22 Thread GitBox
mikemccand closed issue #58: Errors setting assignee when running `import_github_issues.py` URL: https://github.com/apache/lucene-jira-archive/issues/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-jira-archive] mikemccand commented on issue #58: Errors setting assignee when running `import_github_issues.py`

2022-07-22 Thread GitBox
mikemccand commented on issue #58: URL: https://github.com/apache/lucene-jira-archive/issues/58#issuecomment-1192417612 > You cannot assign accounts that have no push access to the repository. > This is the reason I invited you to my test repository in #8. Aha! OK thanks, so this

[GitHub] [lucene-jira-archive] mikemccand commented on issue #59: Module label is sometimes missing?

2022-07-22 Thread GitBox
mikemccand commented on issue #59: URL: https://github.com/apache/lucene-jira-archive/issues/59#issuecomment-1192416865 Could we maybe make this map picky/brittle (throw an exception during conversion if we come across a component/module that isn't in this map)? It would catch such

[GitHub] [lucene-jira-archive] mikemccand commented on issue #59: Module label is sometimes missing?

2022-07-22 Thread GitBox
mikemccand commented on issue #59: URL: https://github.com/apache/lucene-jira-archive/issues/59#issuecomment-1192415309 > This is a bug (typo) in the label mapping; I'll fix this. Oooh! Awesome, thanks for tracking it down!! -- This is an automated message from the Apache Git

[GitHub] [lucene-jira-archive] mikemccand commented on issue #61: Should we carry over Jira "labels"?

2022-07-22 Thread GitBox
mikemccand commented on issue #61: URL: https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1192414741 > Personally, I don't think we should bloat issue labels in GitHub... should we port all Jira "Labels" to GitHub labels? Well, I don't think it is our position

[GitHub] [lucene] iverase commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-22 Thread GitBox
iverase commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r927333254 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene] iverase commented on a diff in pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-22 Thread GitBox
iverase commented on code in PR #1017: URL: https://github.com/apache/lucene/pull/1017#discussion_r927333254 ## lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or