manishbafna commented on code in PR #75:
URL: https://github.com/apache/lucene-jira-archive/pull/75#discussion_r930634094
##
migration/mappings-data/account-map.csv.20220722.verified:
##
@@ -169,3 +169,4 @@ mharwood,markharwood,Mark Harwood
hossman,hossman,Chris M. Hostetter
[
https://issues.apache.org/jira/browse/LUCENE-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571691#comment-17571691
]
Vigya Sharma commented on LUCENE-10583:
---
{quote}We could perhaps make a best effort to detect on
[
https://issues.apache.org/jira/browse/LUCENE-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Knize updated LUCENE-10654:
Fix Version/s: 9.4
(was: 9.3)
> New companion doc value format for
[
https://issues.apache.org/jira/browse/LUCENE-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571655#comment-17571655
]
Nick Knize commented on LUCENE-10654:
-
As per discussion on the PR I think this is too late for 9.3
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571631#comment-17571631
]
Michael Sokolov commented on LUCENE-10577:
--
OK, I will revive the FieldInfo version of this
[
https://issues.apache.org/jira/browse/LUCENE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571594#comment-17571594
]
Michael Sokolov edited comment on LUCENE-10404 at 7/26/22 8:01 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571594#comment-17571594
]
Michael Sokolov edited comment on LUCENE-10404 at 7/26/22 7:59 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571594#comment-17571594
]
Michael Sokolov commented on LUCENE-10404:
--
Here is a test using GloVe 100-dim vectors plus
[
https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571588#comment-17571588
]
Mike Sokolov commented on LUCENE-10054:
---
what is it with this issue that spammers love so much!?
nknize commented on code in PR #1017:
URL: https://github.com/apache/lucene/pull/1017#discussion_r930257797
##
lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java:
##
@@ -0,0 +1,896 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571529#comment-17571529
]
Marios Trivyzas commented on LUCENE-10662:
--
[~dweiss] Thx! Checkout how it looks like without
[
https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571469#comment-17571469
]
Dawid Weiss commented on LUCENE-10662:
--
I think the compiler should be able to pick the most
mocobeta commented on issue #3:
URL:
https://github.com/apache/lucene-jira-archive/issues/3#issuecomment-1195564497
I'll try to improve candidate generation and verification steps maybe next
week.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marios Trivyzas updated LUCENE-10662:
-
Summary: Make LuceneTestCase to not extend from org.junit.Assert (was:
Make
[
https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571453#comment-17571453
]
Marios Trivyzas edited comment on LUCENE-10662 at 7/26/22 2:14 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571453#comment-17571453
]
Marios Trivyzas commented on LUCENE-10662:
--
{quote}
I wouldn't rename any methods
[
https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571418#comment-17571418
]
Dawid Weiss commented on LUCENE-10662:
--
Changing these methods will require a huge follow-up and
mikemccand commented on issue #1:
URL:
https://github.com/apache/lucene-jira-archive/issues/1#issuecomment-1195457720
> GitHub won't accept labels such as `legacy-jira-label:java11` for some
reason
That's really weird ;)
I was able to apply the label to [this
mocobeta commented on issue #1:
URL:
https://github.com/apache/lucene-jira-archive/issues/1#issuecomment-1195451400
The rehearsal failed - 52 issues won't be imported by errors. The errors
come from recent changes in the conversion script (for example, GitHub won't
accept labels such as
mocobeta commented on PR #64:
URL:
https://github.com/apache/lucene-jira-archive/pull/64#issuecomment-1195443803
Looks like this causes import error for some issues.
```
[2022-07-26 18:53:05,540] ERROR:import_github_issues: Import GitHub issue
matriv commented on PR #1049:
URL: https://github.com/apache/lucene/pull/1049#issuecomment-1195437459
- 4904fedef1a3e0ca0a67f8f0db0961b09db51f30 Renames some methods to avoid
naming conflicts
- b9fe0008b10ecff6b29feb3b61250ba343a1b1bd Removes `extends Assert` from
`LuceneTestCase` and
[
https://issues.apache.org/jira/browse/LUCENE-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571393#comment-17571393
]
Michael McCandless commented on LUCENE-10583:
-
We could perhaps make a best effort to
mocobeta commented on issue #3:
URL:
https://github.com/apache/lucene-jira-archive/issues/3#issuecomment-1195419311
> Could we expand the matching so that if the userid in jira == the userid
in GitHub we strongly suggest a match? E.g. mdmarshmallow would have been
matched this way.
[
https://issues.apache.org/jira/browse/LUCENE-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571383#comment-17571383
]
Michael McCandless commented on LUCENE-10583:
-
[~vigyas] can this be resolved now?
>
mikemccand commented on issue #3:
URL:
https://github.com/apache/lucene-jira-archive/issues/3#issuecomment-1195411445
OK got it.
Could we expand the matching so that if the userid in jira == the userid in
GitHub we strongly suggest a match? E.g. `mdmarshmallow` would have been
mocobeta commented on issue #3:
URL:
https://github.com/apache/lucene-jira-archive/issues/3#issuecomment-1195406408
Properly speaking, the current "verified" account mapping includes both
committers and commit authors. "commit authors" can be committers or
contributors.
```
4.
mocobeta commented on issue #3:
URL:
https://github.com/apache/lucene-jira-archive/issues/3#issuecomment-1195399616
"Authors" are not necessarily committers; they literally pull request
authors (contributors).
For example
mikemccand commented on issue #3:
URL:
https://github.com/apache/lucene-jira-archive/issues/3#issuecomment-1195397098
> We already include merged pull requests' authors (if their GitHub full
names are set to the same string as Jira full names).
Maybe we could also consider all opened
mocobeta commented on issue #3:
URL:
https://github.com/apache/lucene-jira-archive/issues/3#issuecomment-1195389801
We already include merged pull requests' authors (if their GitHub full names
are set to the same string as Jira full names).
Maybe we could also consider all opened pull
[
https://issues.apache.org/jira/browse/LUCENE-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571374#comment-17571374
]
Michael Sokolov commented on LUCENE-10151:
--
oh, too bad. Well this feature is new, so at least
jpountz commented on code in PR #1039:
URL: https://github.com/apache/lucene/pull/1039#discussion_r929867414
##
lucene/core/src/test/org/apache/lucene/search/TestWANDScorer.java:
##
@@ -815,7 +856,7 @@ private void doTestRandomSpecialMaxScore(float maxScore)
throws IOException
jpountz commented on PR #1042:
URL: https://github.com/apache/lucene/pull/1042#issuecomment-1195379555
Thanks @wuwm!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jpountz merged PR #1042:
URL: https://github.com/apache/lucene/pull/1042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571370#comment-17571370
]
Adrien Grand commented on LUCENE-10151:
---
I just noticed that the push of my backport had failed,
[
https://issues.apache.org/jira/browse/LUCENE-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-10660:
--
Fix Version/s: 9.4
(was: 9.3)
> precompute the max level in
[
https://issues.apache.org/jira/browse/LUCENE-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571369#comment-17571369
]
Adrien Grand commented on LUCENE-10660:
---
The change made sense to me and I merged it, thank you
[
https://issues.apache.org/jira/browse/LUCENE-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10660.
---
Fix Version/s: 9.3
Resolution: Fixed
> precompute the max level in LogMergePolicy
>
[
https://issues.apache.org/jira/browse/LUCENE-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571367#comment-17571367
]
ASF subversion and git services commented on LUCENE-10151:
--
Commit
jpountz merged PR #1045:
URL: https://github.com/apache/lucene/pull/1045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jpountz commented on code in PR #1047:
URL: https://github.com/apache/lucene/pull/1047#discussion_r929854326
##
lucene/core/src/java/org/apache/lucene/util/fst/BytesStore.java:
##
@@ -179,6 +179,30 @@ void writeBytes(long dest, byte[] b, int offset, int len) {
}
}
+
matriv opened a new pull request, #1049:
URL: https://github.com/apache/lucene/pull/1049
### Description (or a Jira issue link if you have one)
https://issues.apache.org/jira/browse/LUCENE-10662
--
This is an automated message from the Apache Git Service.
To respond to the message,
Marios Trivyzas created LUCENE-10662:
Summary: Make LuceneTestCase not extending from org.junit.Assert
Key: LUCENE-10662
URL: https://issues.apache.org/jira/browse/LUCENE-10662
Project: Lucene -
[
https://issues.apache.org/jira/browse/LUCENE-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571355#comment-17571355
]
Adrien Grand commented on LUCENE-10592:
---
I just pushed an annotion that should show up in the
mikemccand commented on issue #3:
URL:
https://github.com/apache/lucene-jira-archive/issues/3#issuecomment-1195354814
Could we maybe look for Jira issues that have GitHub PRs attached and
"correlate" the ids of who opened the PR against who commented on the issue?
It would clearly
mikemccand closed issue #27: Improve the `Jira Information` header?
URL: https://github.com/apache/lucene-jira-archive/issues/27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
mikemccand commented on issue #27:
URL:
https://github.com/apache/lucene-jira-archive/issues/27#issuecomment-1195343198
I think this one is done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mikemccand closed issue #79: Carry parent issue over
URL: https://github.com/apache/lucene-jira-archive/issues/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mikemccand merged PR #80:
URL: https://github.com/apache/lucene-jira-archive/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dweiss commented on issue #1048:
URL: https://github.com/apache/lucene/issues/1048#issuecomment-1195234738
If you need constant IDs, use a stored document field. IDs are internal
because they are used for per-segment document ordering and once segments are
merged, any previous document IDs
dweiss closed issue #1048: Why lucene doc id changes after updating or merging?
URL: https://github.com/apache/lucene/issues/1048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/LUCENE-10616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571217#comment-17571217
]
fang hou commented on LUCENE-10616:
---
I think this pr [https://github.com/apache/lucene/pull/1003] is
JoeHF commented on PR #1003:
URL: https://github.com/apache/lucene/pull/1003#issuecomment-1195050814
no obvious regression or perf improvement, guess there are no such cases in
benchmark
wikimedium10k:
TaskQPS baseline StdDevQPS
my_modified_version
52 matches
Mail list logo
