[GitHub] [lucene] dweiss commented on pull request #11960: hunspell: support empty dictionaries, adapt to the hunspell/C++ repo changes

2022-11-22 Thread GitBox
dweiss commented on PR #11960: URL: https://github.com/apache/lucene/pull/11960#issuecomment-1323272071 Sorry if I lost track among all these patches - I thought there would be user facing changes as well. If there are none - no need to add anything. -- This is an automated message from t

[GitHub] [lucene] donnerpeter commented on pull request #11960: hunspell: support empty dictionaries, adapt to the hunspell/C++ repo changes

2022-11-22 Thread GitBox
donnerpeter commented on PR #11960: URL: https://github.com/apache/lucene/pull/11960#issuecomment-1323273222 There are some, but they're just API additions which should be backward-compatible. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [lucene] dweiss commented on pull request #11947: Add self-contained artifact upload script for apache nexus (#11329)

2022-11-22 Thread GitBox
dweiss commented on PR #11947: URL: https://github.com/apache/lucene/pull/11947#issuecomment-1323273394 I wonder if this should be reported to infra though. The fact you can close an upload repository with top-level artifacts is strange... I wonder what would happen if you clicked release o

[GitHub] [lucene] jpountz commented on pull request #11947: Add self-contained artifact upload script for apache nexus (#11329)

2022-11-22 Thread GitBox
jpountz commented on PR #11947: URL: https://github.com/apache/lucene/pull/11947#issuecomment-1323280633 @dweiss So I did release the staged repository with top-level artifacts, and Nexus did not give me any errors either. :( After browsing the content, I saw all the artifacts that I had ex

[GitHub] [lucene] dweiss commented on pull request #11947: Add self-contained artifact upload script for apache nexus (#11329)

2022-11-22 Thread GitBox
dweiss commented on PR #11947: URL: https://github.com/apache/lucene/pull/11947#issuecomment-1323295591 Darn. I see them here: https://repository.apache.org/content/repositories/releases/ But they have not been synced with maven central. I honestly think it's Nexus that's at blame here

[GitHub] [lucene] dweiss commented on pull request #11947: Add self-contained artifact upload script for apache nexus (#11329)

2022-11-22 Thread GitBox
dweiss commented on PR #11947: URL: https://github.com/apache/lucene/pull/11947#issuecomment-1323302321 I filed this question to infra: https://issues.apache.org/jira/browse/INFRA-23931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [lucene] jpountz commented on pull request #11947: Add self-contained artifact upload script for apache nexus (#11329)

2022-11-22 Thread GitBox
jpountz commented on PR #11947: URL: https://github.com/apache/lucene/pull/11947#issuecomment-1323310172 Thanks Dawid! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [lucene] stefanvodita closed issue #11814: Support deletes in IndexRearranger

2022-11-22 Thread GitBox
stefanvodita closed issue #11814: Support deletes in IndexRearranger URL: https://github.com/apache/lucene/issues/11814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [lucene] stefanvodita commented on issue #11814: Support deletes in IndexRearranger

2022-11-22 Thread GitBox
stefanvodita commented on issue #11814: URL: https://github.com/apache/lucene/issues/11814#issuecomment-1323341662 `IndexRearranger` now supports selecting docs for deletion from the original index and applying the deletes to the rearranged index. -- This is an automated message from the

[GitHub] [lucene] dweiss commented on pull request #11947: Add self-contained artifact upload script for apache nexus (#11329)

2022-11-22 Thread GitBox
dweiss commented on PR #11947: URL: https://github.com/apache/lucene/pull/11947#issuecomment-1323346570 Just FYI - Sonatype's nexus wouldn't let you release that staging repository, I've tried: ![image](https://user-images.githubusercontent.com/199470/203274558-06abae96-ee76-4b56-b919-a0

[GitHub] [lucene] dweiss commented on pull request #11947: Add self-contained artifact upload script for apache nexus (#11329)

2022-11-22 Thread GitBox
dweiss commented on PR #11947: URL: https://github.com/apache/lucene/pull/11947#issuecomment-1323347876 I'll follow up with Gavin on the Infra ticket. Seems like the rules at Apache are not as strict. And sorry for this. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [lucene] jpountz commented on pull request #11947: Add self-contained artifact upload script for apache nexus (#11329)

2022-11-22 Thread GitBox
jpountz commented on PR #11947: URL: https://github.com/apache/lucene/pull/11947#issuecomment-1323348632 Again, no worries at all, not your fault. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene] jpountz commented on a diff in pull request #11958: GITHUB-11868: Add FilterIndexInput and FilterIndexOutput wrapper classes

2022-11-22 Thread GitBox
jpountz commented on code in PR #11958: URL: https://github.com/apache/lucene/pull/11958#discussion_r1029188569 ## lucene/core/src/java/org/apache/lucene/store/FilterIndexOutput.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [lucene] jpountz commented on a diff in pull request #11954: Remove QueryTimeout#isTimeoutEnabled method and move check to caller

2022-11-22 Thread GitBox
jpountz commented on code in PR #11954: URL: https://github.com/apache/lucene/pull/11954#discussion_r1029194303 ## lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java: ## @@ -784,7 +770,10 @@ protected DirectoryReader doWrapDirectoryReader(DirectoryReader

[GitHub] [lucene] jpountz commented on a diff in pull request #11950: Fix NPE in BinaryRangeFieldRangeQuery when field does not exist or is of wrong type

2022-11-22 Thread GitBox
jpountz commented on code in PR #11950: URL: https://github.com/apache/lucene/pull/11950#discussion_r1029197613 ## lucene/core/src/java/org/apache/lucene/document/BinaryRangeFieldRangeQuery.java: ## @@ -91,7 +92,11 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOE

[GitHub] [lucene] jpountz opened a new pull request, #11961: Remove VectorValues#EMPTY.

2022-11-22 Thread GitBox
jpountz opened a new pull request, #11961: URL: https://github.com/apache/lucene/pull/11961 This instance is illegal as it reports a number of dimensions equal to zero. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [lucene] jpountz opened a new pull request, #11962: Enforce VectorValues.cost() is equal to size().

2022-11-22 Thread GitBox
jpountz opened a new pull request, #11962: URL: https://github.com/apache/lucene/pull/11962 `VectorValues` have a `cost()` method that reports an approximate number of documents that have a vector, but also a `size()` method that reports the accurate number of vectors in the field. Since KN

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #11954: Remove QueryTimeout#isTimeoutEnabled method and move check to caller

2022-11-22 Thread GitBox
shubhamvishu commented on code in PR #11954: URL: https://github.com/apache/lucene/pull/11954#discussion_r1029256452 ## lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.java: ## @@ -292,7 +296,11 @@ public void testExitablePointValuesIndexReader() throws

[GitHub] [lucene] jpountz opened a new issue, #11963: Improve vector quantization API

2022-11-22 Thread GitBox
jpountz opened a new issue, #11963: URL: https://github.com/apache/lucene/issues/11963 ### Description Follow-up of https://github.com/apache/lucene/pull/11860#discussion_r1027106953: the API for quantization of vectors is a bit surprising at times in that you can index bytes but th

[GitHub] [lucene] jpountz commented on a diff in pull request #11860: GITHUB-11830 Better optimize storage for vector connections

2022-11-22 Thread GitBox
jpountz commented on code in PR #11860: URL: https://github.com/apache/lucene/pull/11860#discussion_r1029282728 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/ExpandingVectorValues.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene] jpountz commented on a diff in pull request #11954: Remove QueryTimeout#isTimeoutEnabled method and move check to caller

2022-11-22 Thread GitBox
jpountz commented on code in PR #11954: URL: https://github.com/apache/lucene/pull/11954#discussion_r1029300137 ## lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java: ## @@ -784,7 +770,10 @@ protected DirectoryReader doWrapDirectoryReader(DirectoryReader

[GitHub] [lucene] benwtrent commented on issue #11963: Improve vector quantization API

2022-11-22 Thread GitBox
benwtrent commented on issue #11963: URL: https://github.com/apache/lucene/issues/11963#issuecomment-1323680557 This is a naive question, but is there a design principle I am missing that makes `VectorValues` out of line? I don't know how often folks will read the vector values direct

[GitHub] [lucene] jpountz opened a new pull request, #11964: Make RandomAccessVectorValues an implementation detail of HNSW implementations rather than a proper API.

2022-11-22 Thread GitBox
jpountz opened a new pull request, #11964: URL: https://github.com/apache/lucene/pull/11964 `RandomAccessVectorValues` is internally used in our HNSW implementation to provide random access to vectors, both at index and search time. In order to better reflect this, this change does the foll

[GitHub] [lucene] jpountz commented on issue #11963: Improve vector quantization API

2022-11-22 Thread GitBox
jpountz commented on issue #11963: URL: https://github.com/apache/lucene/issues/11963#issuecomment-1323732143 I had not considered generics, I guess it would be an option indeed by passing the expected vector array class to `getVectorValues` and `searchNearestNeighbors`. -- This is an au

[GitHub] [lucene] gsmiller commented on a diff in pull request #11950: Fix NPE in BinaryRangeFieldRangeQuery when field does not exist or is of wrong type

2022-11-22 Thread GitBox
gsmiller commented on code in PR #11950: URL: https://github.com/apache/lucene/pull/11950#discussion_r1029458836 ## lucene/core/src/test/org/apache/lucene/search/TestRangeFieldsDocValuesQuery.java: ## @@ -226,4 +228,30 @@ public void testToString() { Query q4 = LongRangeDoc

[GitHub] [lucene] gsmiller commented on a diff in pull request #11950: Fix NPE in BinaryRangeFieldRangeQuery when field does not exist or is of wrong type

2022-11-22 Thread GitBox
gsmiller commented on code in PR #11950: URL: https://github.com/apache/lucene/pull/11950#discussion_r1029466354 ## lucene/core/src/java/org/apache/lucene/document/BinaryRangeFieldRangeQuery.java: ## @@ -91,7 +92,11 @@ public Query rewrite(IndexSearcher indexSearcher) throws IO

[GitHub] [lucene] gsmiller commented on a diff in pull request #11950: Fix NPE in BinaryRangeFieldRangeQuery when field does not exist or is of wrong type

2022-11-22 Thread GitBox
gsmiller commented on code in PR #11950: URL: https://github.com/apache/lucene/pull/11950#discussion_r1029470218 ## lucene/core/src/java/org/apache/lucene/document/BinaryRangeFieldRangeQuery.java: ## @@ -91,7 +92,11 @@ public Query rewrite(IndexSearcher indexSearcher) throws IO

[GitHub] [lucene] gsmiller commented on a diff in pull request #11950: Fix NPE in BinaryRangeFieldRangeQuery when field does not exist or is of wrong type

2022-11-22 Thread GitBox
gsmiller commented on code in PR #11950: URL: https://github.com/apache/lucene/pull/11950#discussion_r1029471303 ## lucene/CHANGES.txt: ## @@ -143,6 +143,9 @@ Bug Fixes * GITHUB#11907: Fix latent casting bugs in BKDWriter. (Ben Trent) +* GITHUB#11950: Fix NPE in BinaryRange

[GitHub] [lucene] gsmiller commented on a diff in pull request #11950: Fix NPE in BinaryRangeFieldRangeQuery when field does not exist or is of wrong type

2022-11-22 Thread GitBox
gsmiller commented on code in PR #11950: URL: https://github.com/apache/lucene/pull/11950#discussion_r1029481972 ## lucene/core/src/java/org/apache/lucene/document/BinaryRangeFieldRangeQuery.java: ## @@ -91,7 +92,11 @@ public Query rewrite(IndexSearcher indexSearcher) throws IO

[GitHub] [lucene] gsmiller commented on a diff in pull request #11950: Fix NPE in BinaryRangeFieldRangeQuery when field does not exist or is of wrong type

2022-11-22 Thread GitBox
gsmiller commented on code in PR #11950: URL: https://github.com/apache/lucene/pull/11950#discussion_r1029494212 ## lucene/CHANGES.txt: ## @@ -143,6 +143,9 @@ Bug Fixes * GITHUB#11907: Fix latent casting bugs in BKDWriter. (Ben Trent) +* GITHUB#11950: Fix NPE in BinaryRange

[GitHub] [lucene] jpountz commented on a diff in pull request #11950: Fix NPE in BinaryRangeFieldRangeQuery when field does not exist or is of wrong type

2022-11-22 Thread GitBox
jpountz commented on code in PR #11950: URL: https://github.com/apache/lucene/pull/11950#discussion_r1029501693 ## lucene/core/src/java/org/apache/lucene/document/BinaryRangeFieldRangeQuery.java: ## @@ -91,7 +92,11 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOE

[GitHub] [lucene] donnerpeter merged pull request #11960: hunspell: support empty dictionaries, adapt to the hunspell/C++ repo changes

2022-11-22 Thread GitBox
donnerpeter merged PR #11960: URL: https://github.com/apache/lucene/pull/11960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

[GitHub] [lucene-solr] risdenk opened a new pull request, #2675: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly (#1184)

2022-11-22 Thread GitBox
risdenk opened a new pull request, #2675: URL: https://github.com/apache/lucene-solr/pull/2675 Backport to branch_8_11 for https://issues.apache.org/jira/browse/SOLR-16555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [lucene-solr] itygh commented on pull request #2675: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly (#1184)

2022-11-22 Thread GitBox
itygh commented on PR #2675: URL: https://github.com/apache/lucene-solr/pull/2675#issuecomment-1324112666 这是来自QQ邮箱的假期自动回复邮件。您好,我最近正在休假中,无法亲自回复您的邮件。我将在假期结束后,尽快给您回复。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [lucene] mdmarshmallow commented on a diff in pull request #11958: GITHUB-11868: Add FilterIndexInput and FilterIndexOutput wrapper classes

2022-11-22 Thread GitBox
mdmarshmallow commented on code in PR #11958: URL: https://github.com/apache/lucene/pull/11958#discussion_r1029879211 ## lucene/core/src/java/org/apache/lucene/store/FilterIndexOutput.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [lucene] rmuir commented on issue #11963: Improve vector quantization API

2022-11-22 Thread GitBox
rmuir commented on issue #11963: URL: https://github.com/apache/lucene/issues/11963#issuecomment-1324355332 as i mentioned on the original issue(s) (there were several PRs closed and opened and many comments were lost...), the problem is right in the title: quantization. there should

[GitHub] [lucene] rmuir commented on issue #11963: Improve vector quantization API

2022-11-22 Thread GitBox
rmuir commented on issue #11963: URL: https://github.com/apache/lucene/issues/11963#issuecomment-1324355812 we can break index backwards compatibility to fix this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR