[GitHub] [lucene] vigyasharma commented on pull request #12013: Clear thread local values on UTF8TaxonomyWriterCache.close()

2022-12-29 Thread GitBox
vigyasharma commented on PR #12013: URL: https://github.com/apache/lucene/pull/12013#issuecomment-1367688658 > ... but I don't understand what this "cache" is doing and why it actually documents that it never frees memory. My understanding is that `TaxonomyWriterCache` caches ordinals

[GitHub] [lucene] mcimadamore commented on pull request #12042: Implement MMapDirectory with Java 20 Project Panama Preview API

2022-12-29 Thread GitBox
mcimadamore commented on PR #12042: URL: https://github.com/apache/lucene/pull/12042#issuecomment-1367601892 Thanks for testing @uschindler! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [lucene] uschindler commented on issue #12041: Replicator tests do not compile with Java 20

2022-12-29 Thread GitBox
uschindler commented on issue #12041: URL: https://github.com/apache/lucene/issues/12041#issuecomment-1367520271 Bug report openend at OpenJDK: https://bugs.openjdk.org/browse/JDK-8299416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene] agorlenko commented on pull request #11946: add similarity threshold for hnsw

2022-12-29 Thread GitBox
agorlenko commented on PR #11946: URL: https://github.com/apache/lucene/pull/11946#issuecomment-1367395855 Ok, it seems that I should close this PR, shouldn't I? It is not difficult to implement such functionality in the code which uses lucene if it is necessary (in contrast to the first im

[GitHub] [lucene] twosom opened a new pull request, #12045: fix typo in KoreanNumberFilter

2022-12-29 Thread GitBox
twosom opened a new pull request, #12045: URL: https://github.com/apache/lucene/pull/12045 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un