Re: [PR] Improve Javadoc for Lucene90StoredFieldsFormat [lucene]

2024-01-25 Thread via GitHub
easyice commented on PR #12984: URL: https://github.com/apache/lucene/pull/12984#issuecomment-1911332265 @slow-J @mikemccand Thank you for reviewing and merging! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Make FSTPostingFormat to build FST off-heap [lucene]

2024-01-25 Thread via GitHub
github-actions[bot] commented on PR #12980: URL: https://github.com/apache/lucene/pull/12980#issuecomment-1911203316 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Make Lucene90 postings format to write FST off heap [lucene]

2024-01-25 Thread via GitHub
github-actions[bot] commented on PR #12985: URL: https://github.com/apache/lucene/pull/12985#issuecomment-1911203278 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

[PR] Specify package versions where necessary [lucene-site]

2024-01-25 Thread via GitHub
stefanvodita opened a new pull request, #75: URL: https://github.com/apache/lucene-site/pull/75 I recently pushed #74 and wanted to test the change locally. I had to downgrade two of the dependencies to be able to build the website (`./build.sh -l`). These are the changes I made. -- This

Re: [I] Reproducible failure in TestGrouping.testRandom [lucene]

2024-01-25 Thread via GitHub
benwtrent commented on issue #13025: URL: https://github.com/apache/lucene/issues/13025#issuecomment-1910857115 git bisect shows this commit as the perpetrator: https://github.com/apache/lucene/commit/6b1538b33136a4737ad0d22b3633e62f3d7f362b -- This is an automated message from the Apache

Re: [PR] Early exit range queries on non-matching segments. [lucene]

2024-01-25 Thread via GitHub
benwtrent commented on code in PR #13033: URL: https://github.com/apache/lucene/pull/13033#discussion_r1466767966 ## lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java: ## @@ -290,6 +290,24 @@ public ScorerSupplier scorerSupplier(LeafReaderContext context) throw

Re: [I] join: repeat BytesRefHash.sort() in TermsQuery after TermsIncludingScoreQuery [lucene]

2024-01-25 Thread via GitHub
cpoerschke commented on issue #13018: URL: https://github.com/apache/lucene/issues/13018#issuecomment-1910558350 re-opening as per https://github.com/apache/lucene/pull/13014#issuecomment-1910553708 -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] join: avoid repeat BytesRefHash.sort() in TermsQuery after TermsIncludingScoreQuery [lucene]

2024-01-25 Thread via GitHub
cpoerschke commented on PR #13019: URL: https://github.com/apache/lucene/pull/13019#issuecomment-1910557979 re-opening as per https://github.com/apache/lucene/pull/13014#issuecomment-1910553708 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Rollback the tmp storage of BytesRefHash to -1 after sort [lucene]

2024-01-25 Thread via GitHub
mikemccand commented on PR #13014: URL: https://github.com/apache/lucene/pull/13014#issuecomment-1910553708 > Wondering if perhaps I was too hasty closing out the naive #13019 change ... WDYT? +1 -- let's reopen? I would rather move towards making this API prevent such abuse than be

Re: [PR] Rollback the tmp storage of BytesRefHash to -1 after sort [lucene]

2024-01-25 Thread via GitHub
cpoerschke commented on PR #13014: URL: https://github.com/apache/lucene/pull/13014#issuecomment-1910527785 > ... Or at least let's fix `TermsQuery` to not do this? Thanks for the input! Wondering if perhaps I was too hasty closing out the naive https://github.com/apache/lucene/pull/1

Re: [PR] Improve Javadoc for Lucene90StoredFieldsFormat [lucene]

2024-01-25 Thread via GitHub
mikemccand merged PR #12984: URL: https://github.com/apache/lucene/pull/12984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

Re: [PR] Improve Javadoc for Lucene90StoredFieldsFormat [lucene]

2024-01-25 Thread via GitHub
mikemccand commented on PR #12984: URL: https://github.com/apache/lucene/pull/12984#issuecomment-1910524445 Thank you for the attention to detail @easyice and the review @slow-J and the bot for bringing this back to the top of my email :) I'll merge shortly. Sorry for the delay. -- Thi

Re: [PR] Rollback the tmp storage of BytesRefHash to -1 after sort [lucene]

2024-01-25 Thread via GitHub
mikemccand commented on PR #13014: URL: https://github.com/apache/lucene/pull/13014#issuecomment-1910518411 Thanks for finding/fixing this @gf2121! > because it could call `sort` more than once on a `BytesRefHash` instance Hmm -- that sounds buggy (on `TermsQuery` part)? Should

Re: [I] join: repeat BytesRefHash.sort() in TermsQuery after TermsIncludingScoreQuery [lucene]

2024-01-25 Thread via GitHub
cpoerschke commented on issue #13018: URL: https://github.com/apache/lucene/issues/13018#issuecomment-1910394165 With the #13014 changes repeat sort calls are no longer problematic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [I] join: repeat BytesRefHash.sort() in TermsQuery after TermsIncludingScoreQuery [lucene]

2024-01-25 Thread via GitHub
cpoerschke closed issue #13018: join: repeat BytesRefHash.sort() in TermsQuery after TermsIncludingScoreQuery URL: https://github.com/apache/lucene/issues/13018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-01-25 Thread via GitHub
benwtrent commented on code in PR #12962: URL: https://github.com/apache/lucene/pull/12962#discussion_r1466483832 ## lucene/core/src/java/org/apache/lucene/index/LeafReader.java: ## @@ -280,12 +289,20 @@ public final TopDocs searchNearestVectors( * @param k the number of doc

Re: [I] Reproducible failure in TestGrouping.testRandom [lucene]

2024-01-25 Thread via GitHub
ChrisHegarty commented on issue #13025: URL: https://github.com/apache/lucene/issues/13025#issuecomment-1909949939 Fails on all 9x branches, but passes for me with the same seed on _main_: ``` git checkout releases/lucene/9.9.0 ./gradlew :lucene:grouping:test --tests "org.apache

Re: [I] Reproducible failure in TestGrouping.testRandom [lucene]

2024-01-25 Thread via GitHub
ChrisHegarty commented on issue #13025: URL: https://github.com/apache/lucene/issues/13025#issuecomment-1909914927 I hit this when testing the upcoming 9.9.2 release. ``` org.apache.lucene.search.grouping.TestGrouping > testRandom FAILED java.lang.AssertionError: expected.total