Re: [PR] Use group-varint encode the positions [lucene]

2024-03-30 Thread via GitHub
github-actions[bot] commented on PR #12842: URL: https://github.com/apache/lucene/pull/12842#issuecomment-2028507574 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Made DocIdsWriter use DISI when reading documents with an IntersectVisitor [lucene]

2024-03-30 Thread via GitHub
antonha commented on PR #13149: URL: https://github.com/apache/lucene/pull/13149#issuecomment-2028487168 Thank you all for helping to get this PR into a better state. The only thing that still irked me is that I couldn't get the tests to execute all newly added methods. I made a few changes

Re: [I] gradlew regenerate fails with current gradle version [lucene]

2024-03-30 Thread via GitHub
dweiss commented on issue #13240: URL: https://github.com/apache/lucene/issues/13240#issuecomment-2028479178 Thank you. I'll get back to this and will try to make it work again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Use Arrays.compareUnsigned instead of iterating compare. [lucene]

2024-03-30 Thread via GitHub
rmuir commented on PR #13252: URL: https://github.com/apache/lucene/pull/13252#issuecomment-2028078833 This looks like a good improvement, these `Arrays` methods become much faster than the home-written loops for longer arrays. -- This is an automated message from the Apache Git Service.

Re: [I] gradlew regenerate fails with current gradle version [lucene]

2024-03-30 Thread via GitHub
rmuir commented on issue #13240: URL: https://github.com/apache/lucene/issues/13240#issuecomment-2028077665 I pushed https://github.com/apache/lucene/commit/e2110e0b8e8a38d93c387db9d0d67fb4fe577181 for now. Enjoy your holidays, there's no urgency to this, I just didn't want anyone else to

Re: [I] gradlew regenerate fails with current gradle version [lucene]

2024-03-30 Thread via GitHub
dweiss commented on issue #13240: URL: https://github.com/apache/lucene/issues/13240#issuecomment-2027965086 Could you leave this issue open for me but add a comment to the help file for now, @rmuir ? I'll take another look at it but Easter holidays are quite intense in this part of the wor

Re: [PR] Avoid SegmentTermsEnumFrame reload block. [lucene]

2024-03-30 Thread via GitHub
vsop-479 commented on PR #13253: URL: https://github.com/apache/lucene/pull/13253#issuecomment-2027961416 @mikemccand Do you think this change is feasible? Though this change is still in progress, it would be nice to get your opinion. -- This is an automated message from the Apache

[PR] Avoid SegmentTermsEnumFrame reload block. [lucene]

2024-03-30 Thread via GitHub
vsop-479 opened a new pull request, #13253: URL: https://github.com/apache/lucene/pull/13253 In `SegmentTermsEnum.seekExact` and `SegmentTermsEnumFrame.seekCeil`, if we seek a less target after seeking a greater target, we set `nextEnt` to -1 in `SegmentTermsEnumFrame.rewind`. Which result