Re: [PR] Add a DoubleValuesSource for scoring full precision vector similarity [lucene]

2025-06-14 Thread via GitHub
vigyasharma commented on PR #14708: URL: https://github.com/apache/lucene/pull/14708#issuecomment-2973495768 Thanks all for reviewing this PR. I've addressed the comments above. Will merge this early next week, unless there is any new feedback. -- This is an automated message from the Apa

Re: [PR] Add a DoubleValuesSource for scoring full precision vector similarity [lucene]

2025-06-14 Thread via GitHub
vigyasharma commented on code in PR #14708: URL: https://github.com/apache/lucene/pull/14708#discussion_r2147424239 ## lucene/core/src/test/org/apache/lucene/search/TestQuantizedVectorSimilarityValueSource.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Add a rescorer that uses DoubleValuesSource values to re-score first pass hits [lucene]

2025-06-14 Thread via GitHub
vigyasharma merged PR #14776: URL: https://github.com/apache/lucene/pull/14776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

[I] compileMain24Java fails with JDK25+ [lucene]

2025-06-14 Thread via GitHub
dweiss opened a new issue, #14782: URL: https://github.com/apache/lucene/issues/14782 ### Description Policeman jenkins complains when compiling against new Java versions, for example: ``` ./gradlew compileMain24Java -Pruntime.java.home=/jdks/jdk-25+27 --rerun-tasks ```

Re: [I] compileMain24Java fails with JDK25+ [lucene]

2025-06-14 Thread via GitHub
dweiss commented on issue #14782: URL: https://github.com/apache/lucene/issues/14782#issuecomment-2973246807 This used to work with JDK 25-beta+11-ea - must be a new warning in the JDK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix usage of deprecated Gradle APIs scheduled to be removed in Gradle 9.0 [lucene]

2025-06-14 Thread via GitHub
dweiss merged PR #14781: URL: https://github.com/apache/lucene/pull/14781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Fix deprecated Gradle groovy dsl syntax on property assignments [lucene]

2025-06-14 Thread via GitHub
dweiss merged PR #14780: URL: https://github.com/apache/lucene/pull/14780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[PR] Fix deprecated Gradle groovy dsl syntax on property assignments [lucene]

2025-06-14 Thread via GitHub
breskeby opened a new pull request, #14780: URL: https://github.com/apache/lucene/pull/14780 ### Description Replaces usages of deprecated Gradle DSL syntax of using "propName value". This will be removed in future Gradle versions and should not be used anymore. -- This is an autom

Re: [PR] Fix usage of deprecated Gradle APIs scheduled to be removed in Gradle 9.0 [lucene]

2025-06-14 Thread via GitHub
github-actions[bot] commented on PR #14781: URL: https://github.com/apache/lucene/pull/14781#issuecomment-2972663012 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

[PR] Fix usage of deprecated Gradle APIs scheduled to be removed in Gradle 9.0 [lucene]

2025-06-14 Thread via GitHub
breskeby opened a new pull request, #14781: URL: https://github.com/apache/lucene/pull/14781 ### Description With Gradle 9.0 approaching soon, this fixes incompatibilities with Gradle 9.0 by fixing two types of deprecated api usage in the build logic: 1. The org.gradle.api.plug

Re: [PR] Fix deprecated Gradle groovy dsl syntax on property assignments [lucene]

2025-06-14 Thread via GitHub
github-actions[bot] commented on PR #14780: URL: https://github.com/apache/lucene/pull/14780#issuecomment-2972620881 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

Re: [PR] Fix deprecated Gradle groovy dsl syntax on property assignments [lucene]

2025-06-14 Thread via GitHub
github-actions[bot] commented on PR #14780: URL: https://github.com/apache/lucene/pull/14780#issuecomment-2972618915 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop