rmuir merged PR #15029:
URL: https://github.com/apache/lucene/pull/15029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir merged PR #15028:
URL: https://github.com/apache/lucene/pull/15028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir merged PR #15031:
URL: https://github.com/apache/lucene/pull/15031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir commented on PR #15031:
URL: https://github.com/apache/lucene/pull/15031#issuecomment-3146183887
Since we don't use the problematic `get_rate_limit` i think the risk is
minimal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rmuir commented on PR #15031:
URL: https://github.com/apache/lucene/pull/15031#issuecomment-3146146200
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
rmuir commented on PR #15029:
URL: https://github.com/apache/lucene/pull/15029#issuecomment-3146146836
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
rmuir merged PR #15030:
URL: https://github.com/apache/lucene/pull/15030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir commented on PR #15030:
URL: https://github.com/apache/lucene/pull/15030#issuecomment-3146075126
This one is always the first to merge for the python dependency updates. The
`ruff` linter only looks at individual `.py` files in isolation, so it won't
detect any integration issues. Thi
corecursion commented on code in PR #15015:
URL: https://github.com/apache/lucene/pull/15015#discussion_r2249017404
##
lucene/core/src/java/org/apache/lucene/index/MultiIndexMergeScheduler.java:
##
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
corecursion commented on code in PR #15015:
URL: https://github.com/apache/lucene/pull/15015#discussion_r2249017250
##
lucene/core/src/java/org/apache/lucene/index/MultiIndexMergeScheduler.java:
##
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
dependabot[bot] opened a new pull request, #15028:
URL: https://github.com/apache/lucene/pull/15028
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.12.1 to 0.12.7.
Release notes
Sourced from https://github.com/astral-sh/ruff/releases";>ruff's releases.
0.12.7
Releas
dependabot[bot] opened a new pull request, #15031:
URL: https://github.com/apache/lucene/pull/15031
Bumps [pygithub](https://github.com/pygithub/pygithub) from 2.6.1 to 2.7.0.
Release notes
Sourced from https://github.com/pygithub/pygithub/releases";>pygithub's
releases.
v2.
dependabot[bot] opened a new pull request, #15030:
URL: https://github.com/apache/lucene/pull/15030
Bumps [basedpyright](https://github.com/detachhead/basedpyright) from 1.29.5
to 1.31.0.
Commits
https://github.com/DetachHead/basedpyright/commit/f9d048fb2c37aca36df6f4d2e1887825
dependabot[bot] opened a new pull request, #15029:
URL: https://github.com/apache/lucene/pull/15029
Bumps [holidays](https://github.com/vacanza/holidays) from 0.75 to 0.77.
Release notes
Sourced from https://github.com/vacanza/holidays/releases";>holidays's
releases.
Version
corecursion commented on code in PR #15015:
URL: https://github.com/apache/lucene/pull/15015#discussion_r2248998062
##
lucene/core/src/java/org/apache/lucene/index/MultiIndexMergeScheduler.java:
##
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
kaivalnp commented on code in PR #14932:
URL: https://github.com/apache/lucene/pull/14932#discussion_r2248977825
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsWriter.java:
##
@@ -342,8 +356,12 @@ private void reconstructAndWriteNeighbours(
}
github-actions[bot] commented on PR #14932:
URL: https://github.com/apache/lucene/pull/14932#issuecomment-3145928338
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
corecursion commented on code in PR #15015:
URL: https://github.com/apache/lucene/pull/15015#discussion_r2248960412
##
lucene/core/src/java/org/apache/lucene/index/MultiIndexMergeScheduler.java:
##
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
aylonsk commented on code in PR #14932:
URL: https://github.com/apache/lucene/pull/14932#discussion_r2248958499
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java:
##
@@ -76,6 +79,7 @@ public final class Lucene99HnswVectorsReader extends
Kn
corecursion commented on code in PR #15015:
URL: https://github.com/apache/lucene/pull/15015#discussion_r2248957089
##
lucene/core/src/java/org/apache/lucene/index/MultiIndexMergeScheduler.java:
##
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
aylonsk commented on code in PR #14932:
URL: https://github.com/apache/lucene/pull/14932#discussion_r2248956741
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene99/Lucene99HnswVectorsFormatV0.java:
##
@@ -0,0 +1,233 @@
+/*
Review Comment:
I added a
kaivalnp commented on code in PR #14932:
URL: https://github.com/apache/lucene/pull/14932#discussion_r2248954947
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java:
##
@@ -76,6 +79,7 @@ public final class Lucene99HnswVectorsReader extends
K
github-actions[bot] commented on PR #14932:
URL: https://github.com/apache/lucene/pull/14932#issuecomment-3145902714
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
yossev commented on PR #15027:
URL: https://github.com/apache/lucene/pull/15027#issuecomment-3145884514
Perfect.
I will be waiting for updates on that matter.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
jpountz commented on PR #15027:
URL: https://github.com/apache/lucene/pull/15027#issuecomment-3145871053
The only missing thing is an entry in lucene/CHANGES.txt but we can deal
with it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
yossev commented on PR #15027:
URL: https://github.com/apache/lucene/pull/15027#issuecomment-3145860795
> Thank you, this looks good. If you have cycles to run benchmarks, this
would be appreciated, you can check out this:
https://github.com/mikemccand/luceneutil/blob/main/README.md#running
vigyasharma commented on code in PR #15015:
URL: https://github.com/apache/lucene/pull/15015#discussion_r2248874888
##
lucene/core/src/java/org/apache/lucene/index/MultiIndexMergeScheduler.java:
##
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jpountz commented on PR #14856:
URL: https://github.com/apache/lucene/pull/14856#issuecomment-3145773701
@gf2121 Let's merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jpountz commented on code in PR #14963:
URL: https://github.com/apache/lucene/pull/14963#discussion_r2248864216
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsFormat.java:
##
@@ -137,9 +144,16 @@ public final class Lucene99HnswVectorsFormat extends
jpountz commented on code in PR #14963:
URL: https://github.com/apache/lucene/pull/14963#discussion_r2248862786
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsFormat.java:
##
@@ -115,6 +115,13 @@ public final class Lucene99HnswVectorsFormat extends
jpountz commented on code in PR #14963:
URL: https://github.com/apache/lucene/pull/14963#discussion_r2248839514
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsFormat.java:
##
@@ -137,9 +144,16 @@ public final class Lucene99HnswVectorsFormat extends
jpountz commented on PR #15027:
URL: https://github.com/apache/lucene/pull/15027#issuecomment-3145718862
Thank you, this looks good. If you have cycles to run benchmarks, this would
be appreciated, you can check out this:
https://github.com/mikemccand/luceneutil/blob/main/README.md#running-
msokolov commented on code in PR #14963:
URL: https://github.com/apache/lucene/pull/14963#discussion_r2248750458
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsFormat.java:
##
@@ -137,9 +144,16 @@ public final class Lucene99HnswVectorsFormat extends
msokolov commented on code in PR #15003:
URL: https://github.com/apache/lucene/pull/15003#discussion_r2248685396
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsWriter.java:
##
@@ -347,12 +350,195 @@ private void reconstructAndWriteNeighbours(
}
yossev commented on issue #15024:
URL: https://github.com/apache/lucene/issues/15024#issuecomment-3145499229
I've submitted a PR with the proposed optimization: #15027
It replaces the prefix sum logic with the faster variant as discussed.
Feedback welcome!
--
This is an automated mes
github-actions[bot] commented on PR #15027:
URL: https://github.com/apache/lucene/pull/15027#issuecomment-3145494478
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
yossev opened a new pull request, #15027:
URL: https://github.com/apache/lucene/pull/15027
Replaced the two-step prefix sum loop in `Lucene99HnswVectorsReader` with a
single-loop variant that avoids redundant memory access and improves
performance.
Previous approach:
- Rea
jpountz commented on PR #15003:
URL: https://github.com/apache/lucene/pull/15003#issuecomment-3145430620
I don't feel qualified to do the review, but I agree with the motivation. I
wonder if this optimization could be applied when there are more than 1 segment
to merge by first applying del
jpountz commented on issue #15024:
URL: https://github.com/apache/lucene/issues/15024#issuecomment-3145419003
Historically, several contributors claimed issues and never actually worked
on them so I'm not too keen on assigning it. Nobody else is working on it.
Given your comment, other cont
jpountz commented on issue #14986:
URL: https://github.com/apache/lucene/issues/14986#issuecomment-3145402961
I was wondering about a variant of your idea that would consist of not
reusing the provided `IndexSearcher` but creating a private one that doesn't
cache (`IndexSearcher#setQueryCac
jpountz commented on code in PR #14932:
URL: https://github.com/apache/lucene/pull/14932#discussion_r2248579183
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java:
##
@@ -76,6 +79,7 @@ public final class Lucene99HnswVectorsReader extends
Kn
kaivalnp commented on code in PR #14932:
URL: https://github.com/apache/lucene/pull/14932#discussion_r2248561198
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java:
##
@@ -76,6 +79,7 @@ public final class Lucene99HnswVectorsReader extends
K
msokolov merged PR #15022:
URL: https://github.com/apache/lucene/pull/15022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
msokolov commented on PR #15022:
URL: https://github.com/apache/lucene/pull/15022#issuecomment-3145252602
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
GovindBalaji-S-Glean commented on issue #14986:
URL: https://github.com/apache/lucene/issues/14986#issuecomment-3145194691
One hack I can think of is that instead of `searcher` here, we send in a
decorator of `searcher` with `IndexSearcher#createWeight(query)` just doing
`query.createWeight
msfroh commented on issue #15017:
URL: https://github.com/apache/lucene/issues/15017#issuecomment-3145183135
> Is there any prior work in this space within Lucene or search engines in
general that anyone is aware of? I haven't seen anything myself, but maybe
there's something else to draw o
smuching202 opened a new issue, #15026:
URL: https://github.com/apache/lucene/issues/15026
# Context
While implementing `Accountable.ramBytesUsed()`, I noticed a discrepancy
between the values returned by `RamUsageEstimator.sizeOf(Query, long)` and
`RamUsageTester.ramUsed(obj)` in Lucene
github-actions[bot] commented on PR #15025:
URL: https://github.com/apache/lucene/pull/15025#issuecomment-3144975495
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
msokolov opened a new pull request, #15025:
URL: https://github.com/apache/lucene/pull/15025
Just monkey-coding based on @mikemccand 's comment in the issue. It makes
sense to me and seems to pass unit tests.
Restores this logic to the way it was before
698f40ad51af0c42b0a4a8321ab899
yossev commented on issue #15024:
URL: https://github.com/apache/lucene/issues/15024#issuecomment-3144904919
Hi @jpountz, I’d like to work on this issue if it’s still available. Could
you please assign it to me or let me know if someone else is already working on
it? Thanks!
--
This is a
aylonsk commented on code in PR #14932:
URL: https://github.com/apache/lucene/pull/14932#discussion_r2248181313
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsFormat.java:
##
@@ -212,7 +213,7 @@ public KnnVectorsReader fieldsReader(SegmentReadState
msokolov merged PR #15019:
URL: https://github.com/apache/lucene/pull/15019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
msokolov closed issue #15005: Optimistic knn query breaks nested vector search
URL: https://github.com/apache/lucene/issues/15005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
msokolov commented on PR #15019:
URL: https://github.com/apache/lucene/pull/15019#issuecomment-3144815083
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
jpountz commented on PR #15023:
URL: https://github.com/apache/lucene/pull/15023#issuecomment-3144623188
Very cool. Have you been able to measure any speedup with this approach?
FYI, this breaks some API contracts, e.g. a `BulkScorer` is expected to
score ranges of doc IDs in doc ID o
jpountz opened a new issue, #15024:
URL: https://github.com/apache/lucene/issues/15024
`Lucene99HnswVectorsReader` computes prefix sums by doing:
```java
currentNeighborsBuffer[0] = dataIn.readVInt();
for (int i = 1; i < arcCount; i++) {
currentNeighb
jpountz commented on code in PR #14932:
URL: https://github.com/apache/lucene/pull/14932#discussion_r2247938079
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java:
##
@@ -76,6 +79,7 @@ public final class Lucene99HnswVectorsReader extends
Kn
jpountz commented on issue #13147:
URL: https://github.com/apache/lucene/issues/13147#issuecomment-3144492229
This has been implemented in #14133.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jpountz closed issue #13147: Try encoding very frequent terms using a dense
bitmap
URL: https://github.com/apache/lucene/issues/13147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
jpountz commented on issue #15020:
URL: https://github.com/apache/lucene/issues/15020#issuecomment-3144489128
For visibility, we are moving the decision between approximate and exact
from the query to `KnnVectorsFormat`:
https://github.com/apache/lucene/pull/14963. This will allow Lucene t
github-actions[bot] commented on PR #15023:
URL: https://github.com/apache/lucene/pull/15023#issuecomment-3143954289
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
atris commented on PR #15023:
URL: https://github.com/apache/lucene/pull/15023#issuecomment-3143952348
@jpountz Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on PR #15023:
URL: https://github.com/apache/lucene/pull/15023#issuecomment-3143919539
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
atris opened a new pull request, #15023:
URL: https://github.com/apache/lucene/pull/15023
Implements a query wrapper that prioritizes document ranges based on their
scoring potential using Lucene's impact information. The implementation
divides the document space into ranges and evaluat
github-actions[bot] commented on PR #15022:
URL: https://github.com/apache/lucene/pull/15022#issuecomment-3143835245
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
viliam-durina opened a new pull request, #15022:
URL: https://github.com/apache/lucene/pull/15022
A little optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
gf2121 commented on issue #15018:
URL: https://github.com/apache/lucene/issues/15018#issuecomment-3143231272
Hi, i think this is a bug (my bad), thanks for catching!
Would you like to open a PR to fix?
--
This is an automated message from the Apache Git Service.
To respond to the me
67 matches
Mail list logo
