Re: [PR] vectorize L2 normalize function [lucene]

2025-08-10 Thread via GitHub
github-actions[bot] commented on PR #15043: URL: https://github.com/apache/lucene/pull/15043#issuecomment-3173347389 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

Re: [PR] Clean up FileTypeHint a bit. [lucene]

2025-08-10 Thread via GitHub
bharath-techie commented on PR #14635: URL: https://github.com/apache/lucene/pull/14635#issuecomment-3173313855 Hi @thecoop @jpountz , I've commented the same in https://github.com/apache/lucene/pull/14510/files#r2265722765 ``` lucene/backward-codecs/src/java/org/apache/lucene/

Re: [PR] Change uses of withReadAdvice to use hints instead [lucene]

2025-08-10 Thread via GitHub
bharath-techie commented on code in PR #14510: URL: https://github.com/apache/lucene/pull/14510#discussion_r2265722765 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene101/Lucene101PostingsReader.java: ## @@ -149,9 +150,9 @@ public Lucene101PostingsRead

Re: [PR] vectorize L2 normalize function [lucene]

2025-08-10 Thread via GitHub
github-actions[bot] commented on PR #15043: URL: https://github.com/apache/lucene/pull/15043#issuecomment-3173290641 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

[PR] vectorize L2 normalize function [lucene]

2025-08-10 Thread via GitHub
RamakrishnaChilaka opened a new pull request, #15043: URL: https://github.com/apache/lucene/pull/15043 ### Description While reviewing [apache/lucene#14896](https://github.com/apache/lucene/pull/14896) I noticed that the post-dot-product division step in VectorUtil.l2normalize was st

Re: [PR] vectorize L2 normalize function [lucene]

2025-08-10 Thread via GitHub
github-actions[bot] commented on PR #15043: URL: https://github.com/apache/lucene/pull/15043#issuecomment-3173286802 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

Re: [PR] Bypass HNSW graph building for tiny segments [lucene]

2025-08-10 Thread via GitHub
shubhamvishu commented on code in PR #14963: URL: https://github.com/apache/lucene/pull/14963#discussion_r2265597285 ## lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsFormat.java: ## @@ -115,6 +115,13 @@ public final class Lucene99HnswVectorsFormat ext

Re: [I] Should we use the new `expectedVisitedNodes` estimator to speed up filtered vector search? [lucene]

2025-08-10 Thread via GitHub
jpountz commented on issue #14845: URL: https://github.com/apache/lucene/issues/14845#issuecomment-3172628725 @akhilesh-k Nobody else is on it that I know of. I expect conflicts with #14963 but I don't think that it should refrain you from giving it a try. -- This is an automated message

Re: [PR] Add AcceptDocs abstraction for accepted KNN docs [lucene]

2025-08-10 Thread via GitHub
github-actions[bot] commented on PR #15011: URL: https://github.com/apache/lucene/pull/15011#issuecomment-3172624440 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

Re: [PR] Add AcceptDocs abstraction for accepted KNN docs [lucene]

2025-08-10 Thread via GitHub
github-actions[bot] commented on PR #15011: URL: https://github.com/apache/lucene/pull/15011#issuecomment-3172624106 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

Re: [PR] Add AcceptDocs abstraction for accepted KNN docs [lucene]

2025-08-10 Thread via GitHub
shubhamvishu commented on code in PR #15011: URL: https://github.com/apache/lucene/pull/15011#discussion_r2265169581 ## lucene/core/src/java/org/apache/lucene/search/AcceptDocs.java: ## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more