alessandrobenedetti commented on PR #12029:
URL: https://github.com/apache/lucene/pull/12029#issuecomment-1361523810
Thanks @rmuir for the prompt answer, I took a look at Query.java, and
couldn't find any particular reason for the Knn query to be immutable(aside
from historical reasons?).
alessandrobenedetti commented on PR #12029:
URL: https://github.com/apache/lucene/pull/12029#issuecomment-1361578619
Thanks, @rmuir for the explanation, it seems reasonable and definitely, I
won't argue with that.
For the sake of my needs, just the getters would be fine(and I'll clone the
alessandrobenedetti commented on PR #12029:
URL: https://github.com/apache/lucene/pull/12029#issuecomment-1361606803
@rmuir you are right again, I gave it another try, using copies, this should
be safe.
If there are still concerns I may move to some Builder/Constructors
approaches, to be
alessandrobenedetti commented on PR #12029:
URL: https://github.com/apache/lucene/pull/12029#issuecomment-1362512997
Thanks again @rmuir, moved to a deep copy!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
alessandrobenedetti commented on PR #12029:
URL: https://github.com/apache/lucene/pull/12029#issuecomment-1398524390
waiting for the checks and then I'll merge tonight!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
