cammiemw commented on pull request #463: URL: https://github.com/apache/lucene/pull/463#issuecomment-1009289345
Hi @cpoerschke! Thank you for your comments. I have made the changes to accept most of your suggestions. For the weight explain methods, I went through and tweaked them so that they are not the same anymore and do a better job of explaining the scores. The only issue I have is that I cannot fix the bot error for the double to float conversion because Math.log returns a double and the lucene API expects a float. Let me know if there is anything else that you think I should do. I have also added additional unit tests. I am going to comment on the jira issue as well to see what Adrien Grand thinks of the functionality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
