codaitya commented on pull request #446:
URL: https://github.com/apache/lucene/pull/446#issuecomment-1054179398
Sorry for the delay in getting back to this, got busy with work and also
needed time to study more details on how Lucene does segment merges.
> Why do we need to exclude
codaitya commented on pull request #446:
URL: https://github.com/apache/lucene/pull/446#issuecomment-993311631
Thanks for the explanation Mikes !. I have updated the PR to leave out
variable max segment size .
--
This is an automated message from the Apache Git Service.
To respond to
codaitya commented on pull request #446:
URL: https://github.com/apache/lucene/pull/446#issuecomment-990921102
I have looked more into the workings of other merge policies (mainly
LogMergePolicy) . I found it is difficult to generalize the change in this PR
to work with all the policies.
codaitya commented on pull request #446:
URL: https://github.com/apache/lucene/pull/446#issuecomment-979706721
got it , I willl try the wrapper approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
codaitya commented on pull request #446:
URL: https://github.com/apache/lucene/pull/446#issuecomment-979228578
>we can inherit FilterMergePolicy rather than TieredMergePolicy
I am not sure how would this make it more generic
I will be passing a TieredMergePolicy to
codaitya commented on pull request #446:
URL: https://github.com/apache/lucene/pull/446#issuecomment-971673541
> Let's rename to `MergeOnFlushTieredMergePolicy` since it technically
merges on flushes, not commits?
>
> I haven't taken a deep look at the code, but is it specific to
