dblock commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1058085879
Thanks for fixing the issue @jpountz and everyone for your support and ideas!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dblock commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057349510
> > I won't argue on this specific approach, but I have hard time accepting
that we can fix a real bug, and write no new tests.
>
> Please feel free to contribute one, this i
dblock commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057349041
Thank you for the detailed explanation, this makes a lot of sense.
> * A bug in other code that breaks assumptions that this code is making,
e.g. a query that produces negati
dblock commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057078347
I think we have a case of floating point here.
If you change `getMinCompetitiveScore` to take a `double` or `minScoreSum`,
it becomes easy to reproduce. It also almost alway
dblock commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1055853457
> > Should we parameterize the number of iterations parameter and use it as
test hook for getting the method to throw IllegalArgumentException?
>
> I'm not sure how useful th
dblock commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1055743483
Link: https://issues.apache.org/jira/projects/LUCENE/issues/LUCENE-10428 for
future reference.
cc: @jainankitk
--
This is an automated message from the Apache Git Service
dblock commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1055741805
@jpountz I'd write a test that uses invalid input to do more than 2
iterations and expect `IllegalStateException` with the right values/description.
--
This is an automated messa
dblock commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1055698281
What can we do to get this change into the next version of Lucene?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
