[GitHub] [lucene] dsmiley commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-18 Thread GitBox
dsmiley commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r771899727 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -383,6 +564,15 @@ public UnifiedHighlighter(Buil

[GitHub] [lucene] dsmiley commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-05 Thread GitBox
dsmiley commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r762601545 ## File path: lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java ## @@ -137,23 +141,24 @@ static UnifiedHighlighter

[GitHub] [lucene] dsmiley commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-04 Thread GitBox
dsmiley commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r762497281 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -113,118 +112,239 @@ protected static final L

[GitHub] [lucene] dsmiley commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-03 Thread GitBox
dsmiley commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r762251761 ## File path: lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighterRanking.java ## @@ -278,8 +274,10 @@ public void testCus

[GitHub] [lucene] dsmiley commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-10-31 Thread GitBox
dsmiley commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r739877887 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -143,88 +135,168 @@ private int cacheFieldV

[GitHub] [lucene] dsmiley commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-10-31 Thread GitBox
dsmiley commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r739877069 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -207,18 +342,22 @@ public void setFieldMatcher(P

[GitHub] [lucene] dsmiley commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-10-30 Thread GitBox
dsmiley commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r739664697 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -165,6 +275,27 @@ public UnifiedHighlighter(Inde

[GitHub] [lucene] dsmiley commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-10-27 Thread GitBox
dsmiley commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r737770485 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -143,6 +143,106 @@ private int cacheFieldVa

[GitHub] [lucene] dsmiley commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-10-25 Thread GitBox
dsmiley commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r735937665 ## File path: lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java ## @@ -638,6 +674,39 @@ protected BreakIterator ge