[GitHub] [lucene] gautamworah96 commented on pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-08-31 Thread GitBox
gautamworah96 commented on pull request #242: URL: https://github.com/apache/lucene/pull/242#issuecomment-908676085 Hmmm. So this is indeed multi-threaded but I am still confused. Does it make sense to have a count API return `-1` as the result if the number of matches are greater than a

[GitHub] [lucene] gautamworah96 commented on pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-08-30 Thread GitBox
gautamworah96 commented on pull request #242: URL: https://github.com/apache/lucene/pull/242#issuecomment-908676085 Hmmm. So this is indeed multi-threaded but I am still confused. Does it make sense to have a count API return `-1` as the result if the number of matches are greater than a

[GitHub] [lucene] gautamworah96 commented on pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-08-18 Thread GitBox
gautamworah96 commented on pull request #242: URL: https://github.com/apache/lucene/pull/242#issuecomment-900757557 > then the top hits collector would not have to collect some documents only for the purpose of counting hits. Not sure I understand this correctly. IIUC, today,

[GitHub] [lucene] gautamworah96 commented on pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-08-17 Thread GitBox
gautamworah96 commented on pull request #242: URL: https://github.com/apache/lucene/pull/242#issuecomment-900757557 > then the top hits collector would not have to collect some documents only for the purpose of counting hits. Not sure I understand this correctly. IIUC, today,