[GitHub] [lucene] gsmiller commented on a change in pull request #255: LUCENE-5309: Optimize facet counting for single-valued SSDV / StringValueFacetCounts

gsmiller commented on a change in pull request #255: URL: https://github.com/apache/lucene/pull/255#discussion_r694150989 ## File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/ConcurrentSortedSetDocValuesFacetCounts.java ## @@ -286,7 +310,7 @@ private final voi

[GitHub] [lucene] gsmiller commented on a change in pull request #255: LUCENE-5309: Optimize facet counting for single-valued SSDV / StringValueFacetCounts

gsmiller commented on a change in pull request #255: URL: https://github.com/apache/lucene/pull/255#discussion_r694149519 ## File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/ConcurrentSortedSetDocValuesFacetCounts.java ## @@ -103,7 +105,7 @@ public FacetResul

[GitHub] [lucene] gsmiller commented on a change in pull request #255: Lucene-5309: Optimize facet counting for single-valued SSDV / StringValueFacetCounts

gsmiller commented on a change in pull request #255: URL: https://github.com/apache/lucene/pull/255#discussion_r693200369 ## File path: lucene/CHANGES.txt ## @@ -415,6 +415,8 @@ Improvements This prevents caching a query clause when it is much more expensive than running

[GitHub] [lucene] gsmiller commented on a change in pull request #255: Lucene-5309: Optimize facet counting for single-valued SSDV / StringValueFacetCounts

gsmiller commented on a change in pull request #255: URL: https://github.com/apache/lucene/pull/255#discussion_r693177498 ## File path: lucene/core/src/java/org/apache/lucene/index/MultiDocValues.java ## @@ -680,9 +673,9 @@ public static SortedSetDocValues getSortedSetValues(fi

[GitHub] [lucene] gsmiller commented on a change in pull request #255: Lucene-5309: Optimize facet counting for single-valued SSDV / StringValueFacetCounts

gsmiller commented on a change in pull request #255: URL: https://github.com/apache/lucene/pull/255#discussion_r693177372 ## File path: lucene/core/src/java/org/apache/lucene/index/MultiDocValues.java ## @@ -452,7 +449,6 @@ public static SortedNumericDocValues getSortedNumericV

[GitHub] [lucene] gsmiller commented on a change in pull request #255: Lucene-5309: Optimize facet counting for single-valued SSDV / StringValueFacetCounts

gsmiller commented on a change in pull request #255: URL: https://github.com/apache/lucene/pull/255#discussion_r693177246 ## File path: lucene/core/src/java/org/apache/lucene/index/MultiDocValues.java ## @@ -82,7 +82,6 @@ public int nextDoc() throws IOException { i