[GitHub] [lucene] gsmiller commented on a diff in pull request #779: LUCENE-10488: Optimize Facets#getTopDims in IntTaxonomyFacets

2022-05-12 Thread GitBox
gsmiller commented on code in PR #779: URL: https://github.com/apache/lucene/pull/779#discussion_r871508282 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java: ## @@ -222,41 +262,162 @@ public FacetResult getTopChildren(int topN, String dim, String

[GitHub] [lucene] gsmiller commented on a diff in pull request #779: LUCENE-10488: Optimize Facets#getTopDims in IntTaxonomyFacets

2022-05-10 Thread GitBox
gsmiller commented on code in PR #779: URL: https://github.com/apache/lucene/pull/779#discussion_r868497732 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java: ## @@ -109,7 +109,23 @@ public boolean childrenLoaded() { * @lucene.experimental */