[GitHub] [lucene] gsmiller commented on a diff in pull request #974: LUCENE-10614: Properly support getTopChildren in RangeFacetCounts

2022-07-11 Thread GitBox
gsmiller commented on code in PR #974: URL: https://github.com/apache/lucene/pull/974#discussion_r918110247 ## lucene/demo/src/java/org/apache/lucene/demo/facet/RangeFacetsExample.java: ## @@ -73,6 +76,35 @@ public void index() throws IOException { indexWriter.addDocument

[GitHub] [lucene] gsmiller commented on a diff in pull request #974: LUCENE-10614: Properly support getTopChildren in RangeFacetCounts

2022-07-07 Thread GitBox
gsmiller commented on code in PR #974: URL: https://github.com/apache/lucene/pull/974#discussion_r916216255 ## lucene/demo/src/java/org/apache/lucene/demo/facet/RangeFacetsExample.java: ## @@ -73,6 +76,35 @@ public void index() throws IOException { indexWriter.addDocument

[GitHub] [lucene] gsmiller commented on a diff in pull request #974: LUCENE-10614: Properly support getTopChildren in RangeFacetCounts

2022-07-05 Thread GitBox
gsmiller commented on code in PR #974: URL: https://github.com/apache/lucene/pull/974#discussion_r914083105 ## lucene/demo/src/java/org/apache/lucene/demo/facet/RangeFacetsExample.java: ## @@ -73,6 +76,30 @@ public void index() throws IOException { indexWriter.addDocument

[GitHub] [lucene] gsmiller commented on a diff in pull request #974: LUCENE-10614: Properly support getTopChildren in RangeFacetCounts

2022-07-05 Thread GitBox
gsmiller commented on code in PR #974: URL: https://github.com/apache/lucene/pull/974#discussion_r914082183 ## lucene/demo/src/java/org/apache/lucene/demo/facet/DistanceFacetsExample.java: ## @@ -212,7 +212,26 @@ public static Query getBoundingBoxQuery( } /** User runs a

[GitHub] [lucene] gsmiller commented on a diff in pull request #974: LUCENE-10614: Properly support getTopChildren in RangeFacetCounts

2022-07-02 Thread GitBox
gsmiller commented on code in PR #974: URL: https://github.com/apache/lucene/pull/974#discussion_r912362078 ## lucene/demo/src/java/org/apache/lucene/demo/facet/DistanceFacetsExample.java: ## @@ -212,7 +212,26 @@ public static Query getBoundingBoxQuery( } /** User runs a

[GitHub] [lucene] gsmiller commented on a diff in pull request #974: LUCENE-10614: Properly support getTopChildren in RangeFacetCounts

2022-07-01 Thread GitBox
gsmiller commented on code in PR #974: URL: https://github.com/apache/lucene/pull/974#discussion_r912001915 ## lucene/demo/src/test/org/apache/lucene/demo/facet/TestRangeFacetsExample.java: ## @@ -27,7 +27,7 @@ public class TestRangeFacetsExample extends LuceneTestCase { publ

[GitHub] [lucene] gsmiller commented on a diff in pull request #974: LUCENE-10614: Properly support getTopChildren in RangeFacetCounts

2022-06-29 Thread GitBox
gsmiller commented on code in PR #974: URL: https://github.com/apache/lucene/pull/974#discussion_r910485371 ## lucene/demo/src/java/org/apache/lucene/demo/facet/DistanceFacetsExample.java: ## @@ -212,7 +212,26 @@ public static Query getBoundingBoxQuery( } /** User runs a

[GitHub] [lucene] gsmiller commented on a diff in pull request #974: LUCENE-10614: Properly support getTopChildren in RangeFacetCounts

2022-06-29 Thread GitBox
gsmiller commented on code in PR #974: URL: https://github.com/apache/lucene/pull/974#discussion_r910480915 ## lucene/facet/src/java/org/apache/lucene/facet/range/RangeFacetCounts.java: ## @@ -232,20 +233,43 @@ public FacetResult getAllChildren(String dim, String... path) throw

[GitHub] [lucene] gsmiller commented on a diff in pull request #974: LUCENE-10614: Properly support getTopChildren in RangeFacetCounts

2022-06-28 Thread GitBox
gsmiller commented on code in PR #974: URL: https://github.com/apache/lucene/pull/974#discussion_r908942536 ## lucene/demo/src/java/org/apache/lucene/demo/facet/DistanceFacetsExample.java: ## @@ -212,7 +212,26 @@ public static Query getBoundingBoxQuery( } /** User runs a

[GitHub] [lucene] gsmiller commented on a diff in pull request #974: LUCENE-10614: Properly support getTopChildren in RangeFacetCounts

2022-06-28 Thread GitBox
gsmiller commented on code in PR #974: URL: https://github.com/apache/lucene/pull/974#discussion_r908941811 ## lucene/facet/src/java/org/apache/lucene/facet/range/RangeFacetCounts.java: ## @@ -232,20 +233,43 @@ public FacetResult getAllChildren(String dim, String... path) throw

[GitHub] [lucene] gsmiller commented on a diff in pull request #974: LUCENE-10614: Properly support getTopChildren in RangeFacetCounts

2022-06-27 Thread GitBox
gsmiller commented on code in PR #974: URL: https://github.com/apache/lucene/pull/974#discussion_r907916354 ## lucene/facet/src/java/org/apache/lucene/facet/range/RangeFacetCounts.java: ## @@ -232,20 +233,43 @@ public FacetResult getAllChildren(String dim, String... path) throw