gsmiller opened a new pull request #611: URL: https://github.com/apache/lucene/pull/611
# Description Dimension-level counts in SSDV faceting can be inaccurate when docs contain multiple values under the same dim (the doc will be counted multiple times towards the dim). This fixes the bug by making sure the count is accurate or set to -1 if we know it's inaccurate but can't provide an accurate one (consistent with taxonomy faceting behavior). # Solution The user can now provide facet config for SSDV faceting. If a dim is configured as multi-dimensional _and_ requires dim counts, the dims will be explicitly indexed so accurate counts can be retrieved. Note that users must provide facet config for this to work or else the logic will default to the default config behavior, assuming dims are single-valued and don't require dim counts. # Tests Updated existing tests to reflect correct behavior. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
