gsmiller opened a new pull request #712: URL: https://github.com/apache/lucene/pull/712
# Description These two classes are really implementation details, meant to hold common logic for our faceting implementations, but they are `public` and could be extended by users. It would be nice to reduce visibility to shrink our API surface area. # Solution Make pkg-private. Also reduce visibility of `protected` methods/fields to pkg-private as a little extra cleanup. Note that I will mark these as `@Deprecated` on the 9x branch to provide advanced notice to any users that might be extending these. # Tests No new testing needed. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x ] I have created a Jira issue and added the issue ID to my pull request title. - [x ] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x ] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
