[GitHub] [lucene] iverase commented on pull request #692: LUCENE-10311: Different implementations of DocIdSetBuilder for points and terms

2022-03-16 Thread GitBox
iverase commented on pull request #692: URL: https://github.com/apache/lucene/pull/692#issuecomment-1069345096 won't happen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [lucene] iverase commented on pull request #692: LUCENE-10311: Different implementations of DocIdSetBuilder for points and terms

2022-02-24 Thread GitBox
iverase commented on pull request #692: URL: https://github.com/apache/lucene/pull/692#issuecomment-1049887302 32 bits will need to be discarded anyway, the issue is where. You either do it at the PointValues level by calling grow like: ``` visitor.grow((int) Math.min(getDo

[GitHub] [lucene] iverase commented on pull request #692: LUCENE-10311: Different implementations of DocIdSetBuilder for points and terms

2022-02-22 Thread GitBox
iverase commented on pull request #692: URL: https://github.com/apache/lucene/pull/692#issuecomment-1047786510 If you go a bit higher top in that class: https://user-images.githubusercontent.com/29038686/155139791-fb87fedb-22a0-44a7-86a6-60b6af84f177.png";> We are throwing 32 b

[GitHub] [lucene] iverase commented on pull request #692: LUCENE-10311: Different implementations of DocIdSetBuilder for points and terms

2022-02-22 Thread GitBox
iverase commented on pull request #692: URL: https://github.com/apache/lucene/pull/692#issuecomment-1047752116 I don't understand all this discussion. Looking at the cost of a DocIdSetIterator: ``` /** * Returns the estimated cost of this {@link DocIdSetIterator}. *

[GitHub] [lucene] iverase commented on pull request #692: LUCENE-10311: Different implementations of DocIdSetBuilder for points and terms

2022-02-20 Thread GitBox
iverase commented on pull request #692: URL: https://github.com/apache/lucene/pull/692#issuecomment-1046560283 I open https://github.com/apache/lucene/pull/698 where I proposed a different way to compute const that reflect that the internal counter of DocIdSetBuilder refers to documents in