iverase commented on pull request #709:
URL: https://github.com/apache/lucene/pull/709#issuecomment-1059725486
I reverted the changes to the BKD tree as it is inconsistent with the
current AssertingLeafReader implementation.
--
This is an automated message from the Apache Git Service.
iverase commented on pull request #709:
URL: https://github.com/apache/lucene/pull/709#issuecomment-1053335430
+1 That would hide the implementation details from users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
iverase commented on pull request #709:
URL: https://github.com/apache/lucene/pull/709#issuecomment-1050884300
What I want to make sure is this is covered in the javadocs and we are not
relying on an implementation detail.
#grow needs to be called with the number of times you are
iverase commented on pull request #709:
URL: https://github.com/apache/lucene/pull/709#issuecomment-1050699040
Oh, but that might still be not correct. The buffers implementation does not
grow with unique documents but with every call of BulkAdder#add because it does
not discard
iverase commented on pull request #709:
URL: https://github.com/apache/lucene/pull/709#issuecomment-1050646004
I remove the parameter `grown` from `addAll` in
[4c6b436](https://github.com/apache/lucene/pull/709/commits/4c6b436c7059742c80a7975a39b72494082c543c)
--
This is an automated
iverase commented on pull request #709:
URL: https://github.com/apache/lucene/pull/709#issuecomment-104552
I don't think the is necessary, we can always added to the IntersectVisitor
instead. Maybe would be worthy to adjust how we call grow() in BKDReader#addAll
as it does not need
