[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r607913700 ## File path: lucene/core/src/test/org/apache/lucene/document/TestPerFieldConsistency.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r607913534 ## File path: lucene/core/src/test/org/apache/lucene/document/TestPerFieldConsistency.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r607913125 ## File path: lucene/MIGRATE.md ## @@ -358,11 +358,21 @@ Rather, an IllegalArgumentException shall be thrown. This is introduced for bett defence and

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r598290999 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexingChain.java ## @@ -1313,4 +1307,118 @@ public void recycleIntBlocks(int[][] blocks, i

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r598288749 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -972,6 +671,64 @@ private boolean assertNotFinished() { return

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r598288722 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -787,7 +557,6 @@ synchronized void setVectorDimensionsAndSearchStrateg

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r598288400 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -972,6 +671,64 @@ private boolean assertNotFinished() { return

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r598287872 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -972,6 +671,64 @@ private boolean assertNotFinished() { return

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r598287549 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() { }

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r598287479 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() { }

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r598287461 ## File path: lucene/MIGRATE.md ## @@ -358,8 +358,10 @@ Rather, an IllegalArgumentException shall be thrown. This is introduced for bett defence and

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r598287420 ## File path: lucene/CHANGES.txt ## @@ -92,6 +92,12 @@ API Changes * LUCENE-9480: Make DataInput's skipBytes(long) abstract as the implementation was

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r598275683 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -796,167 +565,97 @@ public void add(FieldInfos other) { /** Creat

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596397825 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -339,110 +350,17 @@ synchronized int addOrGet( String fieldNa

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596391496 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -796,167 +565,97 @@ public void add(FieldInfos other) { /** Creat

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596388510 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() { }

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596388310 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() { }

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596388235 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() { }

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596387988 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() { }

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596388076 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() { }

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596387798 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() { }

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596373649 ## File path: lucene/core/src/java/org/apache/lucene/index/TermVectorsConsumerPerField.java ## @@ -149,9 +149,6 @@ boolean start(IndexableField field,

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596378537 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() { }

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596378102 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -111,6 +111,43 @@ public FieldInfo( /** Performs internal consiste

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596374710 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -111,6 +111,43 @@ public FieldInfo( /** Performs internal consiste

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596373649 ## File path: lucene/core/src/java/org/apache/lucene/index/TermVectorsConsumerPerField.java ## @@ -149,9 +149,6 @@ boolean start(IndexableField field,

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596299038 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -796,167 +565,97 @@ public void add(FieldInfos other) { /** Creat