[GitHub] [lucene] mikemccand commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-09-01 Thread GitBox
mikemccand commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r699665391 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,140 @@ public FacetLabel

[GitHub] [lucene] mikemccand commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-31 Thread GitBox
mikemccand commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r699665391 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,140 @@ public FacetLabel

[GitHub] [lucene] mikemccand commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-28 Thread GitBox
mikemccand commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r697880899 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyCombined.java ## @@ -366,9 +366,9 @@ public void testReaderBasic()

[GitHub] [lucene] mikemccand commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-27 Thread GitBox
mikemccand commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r697513953 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyReader.java ## @@ -212,6 +212,19 @@ public int getOrdinal(String dim,

[GitHub] [lucene] mikemccand commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-27 Thread GitBox
mikemccand commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r697510650 ## File path: lucene/CHANGES.txt ## @@ -137,6 +137,9 @@ API Changes Improvements +* LUCENE-9476: Add new getBulkPath API to DirectoryTaxonomyReader

[GitHub] [lucene] mikemccand commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-27 Thread GitBox
mikemccand commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r697508778 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,140 @@ public FacetLabel

[GitHub] [lucene] mikemccand commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-20 Thread GitBox
mikemccand commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r69227 ## File path: lucene/CHANGES.txt ## @@ -137,6 +137,9 @@ API Changes Improvements +* LUCENE-9476: Add new getBulkPath API to DirectoryTaxonomyReader

[GitHub] [lucene] mikemccand commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-06-26 Thread GitBox
mikemccand commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r659242645 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +349,139 @@ public FacetLabel