[GitHub] [lucene] mikemccand commented on pull request #807: LUCENE-10512: Grammar: Remove incidents of "the the" in comments.

2022-04-18 Thread GitBox
mikemccand commented on PR #807: URL: https://github.com/apache/lucene/pull/807#issuecomment-1101434176 > bq. Since the Spotless check seems to be fail-fast, maybe we should fix the exception message to just suggest ./gradlew tidy instead? > > Gradle runs tasks in parallel so it's not

[GitHub] [lucene] mikemccand commented on pull request #807: LUCENE-10512: Grammar: Remove incidents of "the the" in comments.

2022-04-11 Thread GitBox
mikemccand commented on PR #807: URL: https://github.com/apache/lucene/pull/807#issuecomment-1095144308 > > You should be able to re-style your code automatically by running `./gradlew :lucene:core:spotlessApply` > > Personally I would not recommend running it this way. I run `./gradl

[GitHub] [lucene] mikemccand commented on pull request #807: LUCENE-10512: Grammar: Remove incidents of "the the" in comments.

2022-04-11 Thread GitBox
mikemccand commented on PR #807: URL: https://github.com/apache/lucene/pull/807#issuecomment-109589 That CI build failure is a code styling issue. Lucene uses a [strict code-styling plugin called Spotless](https://issues.apache.org/jira/browse/LUCENE-9564), which removes all ambiguity

[GitHub] [lucene] mikemccand commented on pull request #807: LUCENE-10512: Grammar: Remove incidents of "the the" in comments.

2022-04-11 Thread GitBox
mikemccand commented on PR #807: URL: https://github.com/apache/lucene/pull/807#issuecomment-1095108824 Whoa, thanks @rbowen for the attention to detail! This reminds me of the world's hardest band for search engines to find: [The The](https://en.wikipedia.org/wiki/The_The). -- This is