[GitHub] [lucene] mikemccand commented on pull request #808: LUCENE-10513: Run `gradlew tidy` first

2022-04-19 Thread GitBox
mikemccand commented on PR #808: URL: https://github.com/apache/lucene/pull/808#issuecomment-1102642347 > oh, I learned that wikipedia has an article on Shoshin (初心) for the first time. It's a common noun in Japanese (and also in Chinese I think) so there are no corresponding articles in th

[GitHub] [lucene] mikemccand commented on pull request #808: LUCENE-10513: Run `gradlew tidy` first

2022-04-18 Thread GitBox
mikemccand commented on PR #808: URL: https://github.com/apache/lucene/pull/808#issuecomment-1101418928 > I think I'm too accustomed to the development workflow on this project, so I'm not able to figure out what is the minimum information that should be shown there to introduce new contrib

[GitHub] [lucene] mikemccand commented on pull request #808: LUCENE-10513: Run `gradlew tidy` first

2022-04-18 Thread GitBox
mikemccand commented on PR #808: URL: https://github.com/apache/lucene/pull/808#issuecomment-1101417096 > I followed the commits and I think it shouldn't be the main concern here to edit `CONTRIBUTIONG.md`? I'm not going to be against or hold this. Maybe I'll open another follow-up PR for i