[GitHub] [lucene] reta commented on a diff in pull request #12016: Upgrade ANTLR to version 4.11.1

2022-12-14 Thread GitBox
reta commented on code in PR #12016: URL: https://github.com/apache/lucene/pull/12016#discussion_r1049019777 ## lucene/expressions/src/java/module-info.java: ## @@ -19,7 +19,7 @@ module org.apache.lucene.expressions { Review Comment: ah ... it is still automatic :( although

[GitHub] [lucene] reta commented on a diff in pull request #12016: Upgrade ANTLR to version 4.11.1

2022-12-14 Thread GitBox
reta commented on code in PR #12016: URL: https://github.com/apache/lucene/pull/12016#discussion_r1049014391 ## lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptCompilerSettings.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (A